[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351578#comment-16351578 ] Hudson commented on HBASE-19919: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4521 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4521/]) HBASE-19919 Tidying up logging; ADDENDUM Fix tests w/ mocked Servers (stack: rev 12f3c82a866eee0436c22136909882581fd19905) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: 0001-HBASE-19919-Tidying-up-logging.patch, > HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351470#comment-16351470 ] Hudson commented on HBASE-19919: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4520 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4520/]) HBASE-19919 Tidying up logging (stack: rev 06dec205826a6e96e2286180460e5fe014b46fc8) * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RSProcedureDispatcher.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChunkCreator.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/StateMachineProcedure.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcConnection.java * (add) hbase-common/src/test/java/org/apache/hadoop/hbase/net/TestAddress.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/SplitLogManager.java * (edit) hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcExecutor.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/ZKPermissionWatcher.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/TableStateManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureCoordinator.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/LogCleaner.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationPeerConfigUpgrader.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitLogManagerCoordination.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java * (edit) hbase-common/src/main/java/org/apache/hadoop/hbase/net/Address.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/procedure/ZKProcedureUtil.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/zookeeper/ReadOnlyZKClient.java * (edit) hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/RemoteProcedureDispatcher.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: 0001-HBASE-19919-Tidying-up-logging.patch, > HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351456#comment-16351456 ] stack commented on HBASE-19919: --- And had to add an addendum subsequent to the master fixup. So, push to branch-2 followed by an addendum and a push to master that was broke, a revert, a repush, and then an addendum. Pardon my mess! > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: 0001-HBASE-19919-Tidying-up-logging.patch, > HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351449#comment-16351449 ] stack commented on HBASE-19919: --- Pushed to master again. > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: 0001-HBASE-19919-Tidying-up-logging.patch, > HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351443#comment-16351443 ] stack commented on HBASE-19919: --- Ugh. Thanks [~Apache9]. I messed up the cherry-pick. Thanks for the revert. Let me fix. > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: 0001-HBASE-19919-Tidying-up-logging.patch, > HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351437#comment-16351437 ] Hudson commented on HBASE-19919: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4519 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4519/]) Revert "HBASE-19919 Tidying up logging" (zhangduo: rev 6519b98ac3115c4442a2778f6ed7b39ce5cd3b83) * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java.rej * (delete) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationPeerConfigUpgrader.java.rej * (delete) hbase-common/src/test/java/org/apache/hadoop/hbase/net/TestAddress.java > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: 0001-HBASE-19919-Tidying-up-logging.patch, > HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351357#comment-16351357 ] Duo Zhang commented on HBASE-19919: --- Wrong patch sir? The compilation of master is broken... https://github.com/apache/hbase/commit/40250f8c5f8efe3016f0c3300d9728b0ee2056c6 Only 3 files? > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: 0001-HBASE-19919-Tidying-up-logging.patch, > HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351341#comment-16351341 ] Hudson commented on HBASE-19919: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4518 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4518/]) HBASE-19919 Tidying up logging (stack: rev 40250f8c5f8efe3016f0c3300d9728b0ee2056c6) * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationPeerConfigUpgrader.java.rej * (add) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java.rej * (add) hbase-common/src/test/java/org/apache/hadoop/hbase/net/TestAddress.java > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: 0001-HBASE-19919-Tidying-up-logging.patch, > HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351285#comment-16351285 ] stack commented on HBASE-19919: --- I went a bit further. Attached is what I pushed to master and branch-2. There is a bunch of work to be done still cutting down thread counts, connections.. etc. Our defaults are sloppy and in need of another tidying. The log narrative needs more passes than this one. Lines are a bit more curt now though. Will do for now. There are more failing unit tests to fix! Thanks for the review [~appy] > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Priority: Major > Attachments: 0001-HBASE-19919-Tidying-up-logging.patch, > HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351151#comment-16351151 ] Appy commented on HBASE-19919: -- That looks pretty. +1 > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Priority: Major > Attachments: HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351132#comment-16351132 ] stack commented on HBASE-19919: --- Thanks for review [~appy]... the toStringWithoutDomain is for thread naming. Here are what log lines look like now on a cluster: 2018-02-01 21:17:29,832 INFO [master/ve0524.halxg.cloudera.com/10.17.240.20:16000] cleaner.CleanerChore: Cleaner pool size is 24 Almost 50% of the log is the thread name of which 3/4 is host name. With toStringWithoutDomain, thread name becomes master/ve0524:1600 I've been doing some parametrization. Let me do some more. Thanks. Reading the logs trying to tell a story from what is in here is a bit tough w/ all the noise. > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Priority: Major > Attachments: HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[
https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16351082#comment-16351082
]
Appy commented on HBASE-19919:
--
toStringWithoutDomain(): Unless all logging of servername changes to this,
it'll be hard to debug tests where one needs to search for RS name and iterates
over all occurrences to get high level story of what's going on...since they'll
miss (part/all?) rpc related stuff (that name is used of rpcserver).
Some log.debug can be converted to parameterized style ("xyz {}").
> Tidying up logging
> --
>
> Key: HBASE-19919
> URL: https://issues.apache.org/jira/browse/HBASE-19919
> Project: HBase
> Issue Type: Bug
>Reporter: stack
>Priority: Major
> Attachments: HBASE-19919.branch-2.001.patch
>
>
> Reading logs, there is a bunch of stuff we don't need, thread names are too
> long, etc. Doing a little tidying.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-19919) Tidying up logging
[ https://issues.apache.org/jira/browse/HBASE-19919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349955#comment-16349955 ] stack commented on HBASE-19919: --- .001 is first batch. Need to test it... Posting here so don't lose what has been done so far. > Tidying up logging > -- > > Key: HBASE-19919 > URL: https://issues.apache.org/jira/browse/HBASE-19919 > Project: HBase > Issue Type: Bug >Reporter: stack >Priority: Major > Attachments: HBASE-19919.branch-2.001.patch > > > Reading logs, there is a bunch of stuff we don't need, thread names are too > long, etc. Doing a little tidying. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
