[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370240#comment-16370240
]
Ted Yu commented on HBASE-19954:
Added warning in javadoc of the test classes.
2 test classes are not
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369765#comment-16369765
]
Mike Drob commented on HBASE-19954:
---
Right, so is it the same thing happening? We start and stop a DFS
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369688#comment-16369688
]
Hadoop QA commented on HBASE-19954:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369672#comment-16369672
]
Hadoop QA commented on HBASE-19954:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369649#comment-16369649
]
Ted Yu commented on HBASE-19954:
Mike:
I re-read HBASE-17922.
See my comment above on which patch added
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369643#comment-16369643
]
Mike Drob commented on HBASE-19954:
---
[~tedyu] - see the discussion on HBASE-17922 please. I suspect it
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369635#comment-16369635
]
Ted Yu commented on HBASE-19954:
In the @After method of TestBlockReorder, shutdownMiniCluster() is
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369617#comment-16369617
]
stack commented on HBASE-19954:
---
What about this question: "Why is the exception seen?/Why in hadoop3 do we
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369613#comment-16369613
]
stack commented on HBASE-19954:
---
bq. Testing block reorder is orthogonal to shutdown hook installation.
No
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369611#comment-16369611
]
Ted Yu commented on HBASE-19954:
Patch v2 adds audience annotation for the ShutdownHookManager class.
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369609#comment-16369609
]
Ted Yu commented on HBASE-19954:
Testing block reorder is orthogonal to shutdown hook installation.
When
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368715#comment-16368715
]
stack commented on HBASE-19954:
---
Good.
So, we need to reinstall the hook for each test? Or break up this
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368420#comment-16368420
]
Ted Yu commented on HBASE-19954:
Did some debugging by installing hadoop-common with additional logging
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368134#comment-16368134
]
stack commented on HBASE-19954:
---
You don't say why it happens. Why in hadoop3 do we get this exception and
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357267#comment-16357267
]
Ted Yu commented on HBASE-19954:
Here is related test output with exception (the first line was added for
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357212#comment-16357212
]
stack commented on HBASE-19954:
---
What is the exception seen? Why does it happen? Why would the manager not
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356879#comment-16356879
]
Ted Yu commented on HBASE-19954:
[~chia7712]:
Can you take a look ?
> ShutdownHook should check whether
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356344#comment-16356344
]
Ted Yu commented on HBASE-19954:
Test failure was not related.
I ran the test locally with patch and it
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356310#comment-16356310
]
Hadoop QA commented on HBASE-19954:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-19954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16356187#comment-16356187
]
Ted Yu commented on HBASE-19954:
Patch v1 simplifies ShutdownHookManager by removing
20 matches
Mail list logo
