[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[
https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445679#comment-16445679
]
Hudson commented on HBASE-20059:
Results for branch master
[build #305 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/305/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/305//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/305//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/305//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Make sure documentation is updated for the offheap Bucket cache usage
> -
>
> Key: HBASE-20059
> URL: https://issues.apache.org/jira/browse/HBASE-20059
> Project: HBase
> Issue Type: Sub-task
> Components: documentation
>Reporter: Anoop Sam John
>Assignee: Anoop Sam John
>Priority: Critical
> Fix For: 2.0.0
>
> Attachments:
> 0001-HBASE-20059-Make-sure-documentation-is-updated-for-t.patch,
> HBASE-20059.patch, HBASE-20059_V2.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445287#comment-16445287 ] Anoop Sam John commented on HBASE-20059: Thanks Stack. > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0001-HBASE-20059-Make-sure-documentation-is-updated-for-t.patch, > HBASE-20059.patch, HBASE-20059_V2.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444980#comment-16444980 ] stack commented on HBASE-20059: --- Attached 001... what I pushed. > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: > 0001-HBASE-20059-Make-sure-documentation-is-updated-for-t.patch, > HBASE-20059.patch, HBASE-20059_V2.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444971#comment-16444971 ] stack commented on HBASE-20059: --- So, I gave the doc a once-over, moved-stuff around, and added a section on offheap read-path and one for offheap write-path. I don't have enough to write up how to do offheap write-path with offheap memstore sizing, MSLAB chunking, and pools, so have just put a TODO there for now. Let me commit what is here. There is work to do still on making it so an operator can tell whether they have setup correctly (they have to know what log line to look for and how to interpret it currently). For offheap write, there seems to be but weak signal in logs that it is in place. There is work to do here still. My guess is that when this gets a bit of testing by others, the holes will be more plain; deferring till then. > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20059.patch, HBASE-20059_V2.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16444927#comment-16444927 ] stack commented on HBASE-20059: --- Where did we decide L1 and L2 should be deprecated? > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20059.patch, HBASE-20059_V2.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439044#comment-16439044 ] Anoop Sam John commented on HBASE-20059: Addressed your comments Stack. The write path off heaping related changed will be done as part of another issue (Under HBASE-15179) Only setting BC IOEngine to off heap will turn on off heaping read path. No extra setting/config is needed. The BBPool at RpcServer end also off heap only. One can change the size and/or #BBs. Added a para about that also. > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20059.patch, HBASE-20059_V2.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429190#comment-16429190 ] Anoop Sam John commented on HBASE-20059: Yes Stack. Both these jiras getting addressed with this patch. Let me fix your comments. We still have the L1 and L2 cache concept in older versions. So how do we put that correctly in doc? We can not fully remove. That is why still the terms present in the doc. Let me check all places, this is correctly mentioned. About UI , yes I believe so we say. May be we should fix in another jira? > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20059.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429039#comment-16429039 ] stack commented on HBASE-20059: --- Is HBASE-19438 related [~anoop.hbase] ? > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20059.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16429035#comment-16429035 ] stack commented on HBASE-20059: --- Is HBASE-17097 related [~anoop.hbase] ? > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20059.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427498#comment-16427498 ] stack commented on HBASE-20059: --- We have L1 and L2 in the UI still? > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20059.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427151#comment-16427151 ] stack commented on HBASE-20059: --- Looks great. A few notes: bq. 2 This feature is available from HBase 2.0.0. We recomend users to switch to off heap Bucket Cache as it will make the RegionServer to work with much lower heap size. Above recommendation is premature? We need to do some testing first beyond what you fellows have done? Long burn ins? Couch it some? Make these into asciidoc links: 685 https://blogs.apache.org/hbase/entry/offheaping_the_read_path_in 686 https://blogs.apache.org/hbase/entry/offheap-read-path-in-production bq. 691 Please note that we have removed the notion of L1 and L2 here. There is no movement of blocks from LruBlockCache to BucketCache or vice versa. This is the 'victim' stuff described earlier? If so, use the term 'victim' to tie it to previous description. We seem to repeat this a few times: the data blocks will always go to BucketCache and index, bloom blocks go to on heap LRUBlockCache. `cacheDataInL1` support is also removed. Should we do an edit to strip notions of L1 and L2 from the refguide? Where is config on enabling offheap read-path and then offheap write-path? How does operator know it enabled? Any metrics or logs the operator should be looking for to see that configs have taken or effectiveness of offheaping? Better review after looking at the patch in context. Thanks A. > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20059.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427153#comment-16427153 ] stack commented on HBASE-20059: --- Hmm.. so this about offheap bucket cache. Do we need another issue for doc'ing offheap readpath/writepath? > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20059.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426767#comment-16426767 ] Anoop Sam John commented on HBASE-20059: [~stack] > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task > Components: documentation >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-20059.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398128#comment-16398128 ] Anoop Sam John commented on HBASE-20059: Added a fat release notes in the parent umbrella jira. We can incorporate these to correct areas in book as well. Pls see it helps or not. Pls ping for any further Qs also [~alex.leblang_impala_e0fc] > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398073#comment-16398073 ] stack commented on HBASE-20059: --- Thanks boss. Our [~alex.leblang_impala_e0fc] wants to take it for a spin... > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16398070#comment-16398070 ] Anoop Sam John commented on HBASE-20059: This issue is about read path. Ya sure. I will add the details. Will add first as a release notes. (All the related things with explanation) .. In book we already have off heap BC relates some info. Need a rewording may be.. Am on to this today Stack. > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16397507#comment-16397507 ] stack commented on HBASE-20059: --- [~anoop.hbase] Want to fill in basic configs here at least sir? Currently all we have is https://blogs.apache.org/hbase/search?q=offheap but need more than just setting block cache to enable offheaped read-path? MSLAB? Bufferpools? HBASE-11425 needs a release note with configs to manipulate. Ditto for HBASE-15179. Thanks. We trying to test on our end. > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20059) Make sure documentation is updated for the offheap Bucket cache usage
[ https://issues.apache.org/jira/browse/HBASE-20059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382983#comment-16382983 ] stack commented on HBASE-20059: --- I think this critical for an important feature. Leaving it in hbase2. > Make sure documentation is updated for the offheap Bucket cache usage > - > > Key: HBASE-20059 > URL: https://issues.apache.org/jira/browse/HBASE-20059 > Project: HBase > Issue Type: Sub-task >Reporter: Anoop Sam John >Assignee: Anoop Sam John >Priority: Critical > Fix For: 2.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
