[jira] [Commented] (HBASE-20094) Import$CellWritableComparable should define equals()

2018-03-21 Thread Ted Yu (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408338#comment-16408338
 ] 

Ted Yu commented on HBASE-20094:


[~dbist13]:
Can we resolve this issue as Dup ?

> Import$CellWritableComparable should define equals()
> 
>
> Key: HBASE-20094
> URL: https://issues.apache.org/jira/browse/HBASE-20094
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Artem Ervits
>Priority: Major
> Attachments: HBASE-20094.v01.patch, HBASE-20094.v02.patch
>
>
> Bug type EQ_COMPARETO_USE_OBJECT_EQUALS
> {code}
> In class org.apache.hadoop.hbase.mapreduce.Import$CellWritableComparable
> In method 
> org.apache.hadoop.hbase.mapreduce.Import$CellWritableComparable.compareTo(Import$CellWritableComparable)
> At Import.java:[line 149]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20094) Import$CellWritableComparable should define equals()

2018-03-13 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397672#comment-16397672
 ] 

stack commented on HBASE-20094:
---

You see comments above [~dbist13] ? Unscheduling from branch-2. Shout if I have 
it wrong. Thanks.

> Import$CellWritableComparable should define equals()
> 
>
> Key: HBASE-20094
> URL: https://issues.apache.org/jira/browse/HBASE-20094
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Artem Ervits
>Priority: Major
> Attachments: HBASE-20094.v01.patch, HBASE-20094.v02.patch
>
>
> Bug type EQ_COMPARETO_USE_OBJECT_EQUALS
> {code}
> In class org.apache.hadoop.hbase.mapreduce.Import$CellWritableComparable
> In method 
> org.apache.hadoop.hbase.mapreduce.Import$CellWritableComparable.compareTo(Import$CellWritableComparable)
> At Import.java:[line 149]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20094) Import$CellWritableComparable should define equals()

2018-03-02 Thread stack (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384143#comment-16384143
 ] 

stack commented on HBASE-20094:
---

[~dbist13] Pardon me. I should have been more clear.

HBASE-20110 "Findbugs in zk and mr caused nightly #409 branch-2 to fail" added 
the below on the compareTo of CellWritableComparable

{code}
221 @edu.umd.cs.findbugs.annotations.SuppressWarnings(value = 
"EQ_COMPARETO_USE_OBJECT_EQUALS",
222 justification = "This is wrong, yes, but we should be purging 
Writables, not fixing them")
{code}

It did this to shutdown the findbugs warning.

The above change echoed the change made in the class above it, 
KeyValueWritableComparator, done for the same reason.

I went this route of shutting down the findbugs warnings rather than addressing 
the complaint as you have done here because these Writable classes need to go. 
Writables are the old Hadoop POJO class serialization. Long time ago, we 
figured the hand-written serializations required of Writables untenable and we 
opted for protobufs. These instances of Writables here are some of the last in 
the codebase. Would rather work on their purge than fill them out more.

Thanks too for the initiative pushing back reopening the issue to address a 
hole.

> Import$CellWritableComparable should define equals()
> 
>
> Key: HBASE-20094
> URL: https://issues.apache.org/jira/browse/HBASE-20094
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Artem Ervits
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-20094.v01.patch, HBASE-20094.v02.patch
>
>
> Bug type EQ_COMPARETO_USE_OBJECT_EQUALS
> {code}
> In class org.apache.hadoop.hbase.mapreduce.Import$CellWritableComparable
> In method 
> org.apache.hadoop.hbase.mapreduce.Import$CellWritableComparable.compareTo(Import$CellWritableComparable)
> At Import.java:[line 149]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20094) Import$CellWritableComparable should define equals()

2018-03-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383910#comment-16383910
 ] 

Hadoop QA commented on HBASE-20094:
---

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
53s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
 8s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
18s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
31s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  5m 
13s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
22m  4s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 15m  
5s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
15s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 55m 43s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20094 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12912799/HBASE-20094.v02.patch 
|
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 8c181f41a5cb 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 
14:43:09 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / 1d25b60831 |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC3 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11780/testReport/ |
| Max. process+thread count | 4127 (vs. ulimit of 1) |
| modules | C: hbase-mapreduce U: hbase-mapreduce |
| Console output | 
https://builds.apache.org/job/PreCommit-HBASE-Build/11780/console |
| Powered by | Apache Yetus 0.7.0   http://yetus.apache.org |


This message was automatically generated.



>

[jira] [Commented] (HBASE-20094) Import$CellWritableComparable should define equals()

2018-03-02 Thread Artem Ervits (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383828#comment-16383828
 ] 

Artem Ervits commented on HBASE-20094:
--

v2 patch addresses the three checkstyle issues found.

> Import$CellWritableComparable should define equals()
> 
>
> Key: HBASE-20094
> URL: https://issues.apache.org/jira/browse/HBASE-20094
> Project: HBase
>  Issue Type: Sub-task
>Reporter: Ted Yu
>Assignee: Artem Ervits
>Priority: Major
> Fix For: 2.0.0
>
> Attachments: HBASE-20094.v01.patch, HBASE-20094.v02.patch
>
>
> Bug type EQ_COMPARETO_USE_OBJECT_EQUALS
> {code}
> In class org.apache.hadoop.hbase.mapreduce.Import$CellWritableComparable
> In method 
> org.apache.hadoop.hbase.mapreduce.Import$CellWritableComparable.compareTo(Import$CellWritableComparable)
> At Import.java:[line 149]
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (HBASE-20094) Import$CellWritableComparable should define equals()

2018-03-02 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HBASE-20094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16383802#comment-16383802
 ] 

Hadoop QA commented on HBASE-20094:
---

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 1 new or modified test 
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  3m 
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
20s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
26s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
34s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
21s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
 6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 
15s{color} | {color:red} hbase-mapreduce: The patch generated 3 new + 51 
unchanged - 0 fixed = 54 total (was 51) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
12s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  6m  
8s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.5. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red}  8m  
7s{color} | {color:red} The patch causes 10 errors with Hadoop v2.7.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m 
15s{color} | {color:red} The patch causes 10 errors with Hadoop v3.0.0. {color} 
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  0m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
12s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 12m  
8s{color} | {color:green} hbase-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
 9s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 16s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20094 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12912795/HBASE-20094.v01.patch 
|
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  shadedjars  
hadoopcheck  hbaseanti  checkstyle  compile  |
| uname | Linux 7d7022168651 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 
13:48:03 UTC 2016 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | 
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
 |
| git revision | master / db131be39a |
| maven | version: Apache Maven 3.5.2 
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| findbugs | v3.1.0-RC3 |
| checkstyle |