[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[
https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430906#comment-16430906
]
Hudson commented on HBASE-20129:
Results for branch HBASE-20046-branch-2
[build #7 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20046-branch-2/7/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20046-branch-2/7//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20046-branch-2/7//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20046-branch-2/7//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add UT for serial replication checker
> -
>
> Key: HBASE-20129
> URL: https://issues.apache.org/jira/browse/HBASE-20129
> Project: HBase
> Issue Type: Sub-task
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20129-v1.patch, HBASE-20129.patch
>
>
> Now it is a separated class so it is much easier to write UT to test the
> corner cases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[
https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430818#comment-16430818
]
Hudson commented on HBASE-20129:
Results for branch branch-2
[build #590 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/590/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/590//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/590//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/590//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Add UT for serial replication checker
> -
>
> Key: HBASE-20129
> URL: https://issues.apache.org/jira/browse/HBASE-20129
> Project: HBase
> Issue Type: Sub-task
> Components: Replication
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0, 2.1.0
>
> Attachments: HBASE-20129-v1.patch, HBASE-20129.patch
>
>
> Now it is a separated class so it is much easier to write UT to test the
> corner cases.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[ https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387837#comment-16387837 ] Hudson commented on HBASE-20129: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #4700 (See [https://builds.apache.org/job/HBase-Trunk_matrix/4700/]) HBASE-20129 Add UT for serial replication checker (zhangduo: rev 1384da71375427b522b09f06862bb5d629cef52f) * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/SerialReplicationChecker.java * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestSerialReplicationChecker.java * (edit) hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java > Add UT for serial replication checker > - > > Key: HBASE-20129 > URL: https://issues.apache.org/jira/browse/HBASE-20129 > Project: HBase > Issue Type: Sub-task > Components: Replication >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20129-v1.patch, HBASE-20129.patch > > > Now it is a separated class so it is much easier to write UT to test the > corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[
https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387255#comment-16387255
]
Hadoop QA commented on HBASE-20129:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
22s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
28s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
17s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
32s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
28s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
21s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
17m 7s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
59s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}151m
36s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
28s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}197m 43s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20129 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12913127/HBASE-20129-v1.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 5fa449b5b396 4.4.0-116-generic #140-Ubuntu SMP Mon Feb 12
21:23:04 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 4a4c012049 |
| maven | version: Apache Maven 3.5.2
(138edd61fd100ec658bfa2d307c43b76940a5d7d; 2017-10-18T07:58:13Z) |
| Default Java | 1.8.0_151 |
| findbugs |
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[ https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387251#comment-16387251 ] Zheng Hu commented on HBASE-20129: -- > Maybe we should use a byte other than 0xFF? In theory, we can use any byte as the escape byte. the diff is that if we use readable byte , will be helpful when we scan meta by shell or zookeeper ( depends on which storage layer we choose). > Add UT for serial replication checker > - > > Key: HBASE-20129 > URL: https://issues.apache.org/jira/browse/HBASE-20129 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-20129-v1.patch, HBASE-20129.patch > > > Now it is a separated class so it is much easier to write UT to test the > corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[ https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387248#comment-16387248 ] Zheng Hu commented on HBASE-20129: -- The UT looks great. +1. > Add UT for serial replication checker > - > > Key: HBASE-20129 > URL: https://issues.apache.org/jira/browse/HBASE-20129 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-20129-v1.patch, HBASE-20129.patch > > > Now it is a separated class so it is much easier to write UT to test the > corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[ https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387234#comment-16387234 ] Duo Zhang commented on HBASE-20129: --- Maybe we should use a byte other than 0xFF? > Add UT for serial replication checker > - > > Key: HBASE-20129 > URL: https://issues.apache.org/jira/browse/HBASE-20129 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-20129-v1.patch, HBASE-20129.patch > > > Now it is a separated class so it is much easier to write UT to test the > corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[ https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387225#comment-16387225 ] Zheng Hu commented on HBASE-20129: -- Oh, 0xFFa will be encoded to 0xFF0xFFa , so seems no problem. > Add UT for serial replication checker > - > > Key: HBASE-20129 > URL: https://issues.apache.org/jira/browse/HBASE-20129 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-20129-v1.patch, HBASE-20129.patch > > > Now it is a separated class so it is much easier to write UT to test the > corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[ https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387223#comment-16387223 ] Duo Zhang commented on HBASE-20129: --- It will be convert to '0xFF 0xFF a' when storing to meta, and then convert to '0xFF a' back when loading from meta. > Add UT for serial replication checker > - > > Key: HBASE-20129 > URL: https://issues.apache.org/jira/browse/HBASE-20129 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-20129-v1.patch, HBASE-20129.patch > > > Now it is a separated class so it is much easier to write UT to test the > corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[ https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387218#comment-16387218 ] Zheng Hu commented on HBASE-20129: -- According the parse method, when region name has a startRowKey 0xFFa , it 'll parse to be 'a' ? > Add UT for serial replication checker > - > > Key: HBASE-20129 > URL: https://issues.apache.org/jira/browse/HBASE-20129 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-20129-v1.patch, HBASE-20129.patch > > > Now it is a separated class so it is much easier to write UT to test the > corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[ https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387053#comment-16387053 ] Duo Zhang commented on HBASE-20129: --- Fix checkstyle issues. > Add UT for serial replication checker > - > > Key: HBASE-20129 > URL: https://issues.apache.org/jira/browse/HBASE-20129 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Attachments: HBASE-20129-v1.patch, HBASE-20129.patch > > > Now it is a separated class so it is much easier to write UT to test the > corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[
https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386227#comment-16386227
]
Hadoop QA commented on HBASE-20129:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
19s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
11s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
58s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
34s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
56s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
58s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
57s{color} | {color:red} hbase-server: The patch generated 2 new + 0 unchanged
- 0 fixed = 2 total (was 0) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
13s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m
9s{color} | {color:red} The patch causes 10 errors with Hadoop v2.6.5. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 8m
5s{color} | {color:red} The patch causes 10 errors with Hadoop v2.7.4. {color} |
| {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m
10s{color} | {color:red} The patch causes 10 errors with Hadoop v3.0.0. {color}
|
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
41s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
57s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}103m
16s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
31s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}141m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 |
| JIRA Issue | HBASE-20129 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12913038/HBASE-20129.patch |
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 71fde037c971 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12
13:48:03 UTC 2016 x86_64 GNU/Linux
[jira] [Commented] (HBASE-20129) Add UT for serial replication checker
[ https://issues.apache.org/jira/browse/HBASE-20129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386044#comment-16386044 ] Duo Zhang commented on HBASE-20129: --- Oh I format the MetaTableAccessor accidently... > Add UT for serial replication checker > - > > Key: HBASE-20129 > URL: https://issues.apache.org/jira/browse/HBASE-20129 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > > Now it is a separated class so it is much easier to write UT to test the > corner cases. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
