[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416665#comment-16416665
]
Hudson commented on HBASE-20178:
Results for branch HBASE-19064
[build #77 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> [AMv2] Throw exception if hostile environment
> -
>
> Key: HBASE-20178
> URL: https://issues.apache.org/jira/browse/HBASE-20178
> Project: HBase
> Issue Type: Sub-task
> Components: amv2
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0
>
> Attachments:
> 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch,
> HBASE-20178.branch-2.001.patch, HBASE-20178.branch-2.002.patch,
> HBASE-20178.branch-2.003.patch, HBASE-20178.branch-2.004.patch,
> HBASE-20178.branch-2.005.patch, HBASE-20178.branch-2.006.patch,
> HBASE-20178.branch-2.007.patch
>
>
> New pattern where we throw exception on procedure construction if cluster is
> going down, hosting master is stopping, table is offline, or table is
> read-only. Fail fast rather than later internal to Procedure so can flag
> caller there is a problem.
> Changed Move/Split/Merge Procedures.
> No point queuing a move region for a table that is offline and which may
> never be re-enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16400400#comment-16400400
]
Hudson commented on HBASE-20178:
Results for branch master
[build #262 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/262/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/262//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/262//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/262//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> [AMv2] Throw exception if hostile environment
> -
>
> Key: HBASE-20178
> URL: https://issues.apache.org/jira/browse/HBASE-20178
> Project: HBase
> Issue Type: Sub-task
> Components: amv2
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0
>
> Attachments:
> 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch,
> HBASE-20178.branch-2.001.patch, HBASE-20178.branch-2.002.patch,
> HBASE-20178.branch-2.003.patch, HBASE-20178.branch-2.004.patch,
> HBASE-20178.branch-2.005.patch, HBASE-20178.branch-2.006.patch,
> HBASE-20178.branch-2.007.patch
>
>
> New pattern where we throw exception on procedure construction if cluster is
> going down, hosting master is stopping, table is offline, or table is
> read-only. Fail fast rather than later internal to Procedure so can flag
> caller there is a problem.
> Changed Move/Split/Merge Procedures.
> No point queuing a move region for a table that is offline and which may
> never be re-enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399921#comment-16399921
]
Hudson commented on HBASE-20178:
Results for branch branch-2.0
[build #40 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/40/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/40//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/40//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/40//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> [AMv2] Throw exception if hostile environment
> -
>
> Key: HBASE-20178
> URL: https://issues.apache.org/jira/browse/HBASE-20178
> Project: HBase
> Issue Type: Sub-task
> Components: amv2
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0
>
> Attachments:
> 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch,
> HBASE-20178.branch-2.001.patch, HBASE-20178.branch-2.002.patch,
> HBASE-20178.branch-2.003.patch, HBASE-20178.branch-2.004.patch,
> HBASE-20178.branch-2.005.patch, HBASE-20178.branch-2.006.patch,
> HBASE-20178.branch-2.007.patch
>
>
> New pattern where we throw exception on procedure construction if cluster is
> going down, hosting master is stopping, table is offline, or table is
> read-only. Fail fast rather than later internal to Procedure so can flag
> caller there is a problem.
> Changed Move/Split/Merge Procedures.
> No point queuing a move region for a table that is offline and which may
> never be re-enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399902#comment-16399902
]
Hudson commented on HBASE-20178:
Results for branch branch-2
[build #486 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/486/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/486//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/486//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/486//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> [AMv2] Throw exception if hostile environment
> -
>
> Key: HBASE-20178
> URL: https://issues.apache.org/jira/browse/HBASE-20178
> Project: HBase
> Issue Type: Sub-task
> Components: amv2
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0
>
> Attachments:
> 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch,
> HBASE-20178.branch-2.001.patch, HBASE-20178.branch-2.002.patch,
> HBASE-20178.branch-2.003.patch, HBASE-20178.branch-2.004.patch,
> HBASE-20178.branch-2.005.patch, HBASE-20178.branch-2.006.patch,
> HBASE-20178.branch-2.007.patch
>
>
> New pattern where we throw exception on procedure construction if cluster is
> going down, hosting master is stopping, table is offline, or table is
> read-only. Fail fast rather than later internal to Procedure so can flag
> caller there is a problem.
> Changed Move/Split/Merge Procedures.
> No point queuing a move region for a table that is offline and which may
> never be re-enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16399231#comment-16399231
]
Hadoop QA commented on HBASE-20178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
44s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 9 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
17s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
56s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
42s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m
47s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 10m
55s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m
47s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
21s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
37s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m
8s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m
30s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 27s{color}
| {color:red} hbase-client generated 1 new + 103 unchanged - 1 fixed = 104
total (was 104) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
12s{color} | {color:green} hbase-client: The patch generated 0 new + 102
unchanged - 1 fixed = 102 total (was 103) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 2m
15s{color} | {color:red} hbase-server: The patch generated 1 new + 587
unchanged - 1 fixed = 588 total (was 588) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
38s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
21m 2s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
15s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
55s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
11s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green}149m
59s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
38s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}229m 6s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-20178 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12914514/HBASE-20178.branch-2.007.patch
|
| Optional Tests | asflicense javac javadoc unit findbugs shadedjars
hadoopcheck hbaseanti checkstyle compile |
| uname | Linux e91a67c2c0ef 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18
11:55:51 UTC 2017 x86_64
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398731#comment-16398731
]
Hadoop QA commented on HBASE-20178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 8 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
16s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
28s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
28s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
55s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 6m
11s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
3s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
27s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
24s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 41s{color}
| {color:red} hbase-client generated 1 new + 103 unchanged - 1 fixed = 104
total (was 104) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
31s{color} | {color:green} hbase-client: The patch generated 0 new + 102
unchanged - 1 fixed = 102 total (was 103) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
19s{color} | {color:red} hbase-server: The patch generated 1 new + 587
unchanged - 1 fixed = 588 total (was 588) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
7s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 8s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
56s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}146m 31s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
36s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}194m 31s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.master.locking.TestLockManager |
| | hadoop.hbase.master.procedure.TestTruncateTableProcedure |
| | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:9f2f2db |
| JIRA Issue | HBASE-20178 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12914403/HBASE-20178.branch-2.006.patch
|
|
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[ https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398071#comment-16398071 ] stack commented on HBASE-20178: --- Failures are good ones. Come mostly of our now failing fast or our making an assert that doesn't hold. .006 does fixes. > [AMv2] Throw exception if hostile environment > - > > Key: HBASE-20178 > URL: https://issues.apache.org/jira/browse/HBASE-20178 > Project: HBase > Issue Type: Sub-task > Components: amv2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: > 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch, > HBASE-20178.branch-2.001.patch, HBASE-20178.branch-2.002.patch, > HBASE-20178.branch-2.003.patch, HBASE-20178.branch-2.004.patch, > HBASE-20178.branch-2.005.patch, HBASE-20178.branch-2.006.patch > > > New pattern where we throw exception on procedure construction if cluster is > going down, hosting master is stopping, table is offline, or table is > read-only. Fail fast rather than later internal to Procedure so can flag > caller there is a problem. > Changed Move/Split/Merge Procedures. > No point queuing a move region for a table that is offline and which may > never be re-enabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397715#comment-16397715
]
Hadoop QA commented on HBASE-20178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
25s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 6 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
1s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
2s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
8s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
28s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
54s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
49s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
49s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
0s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 0m 32s{color}
| {color:red} hbase-client generated 1 new + 103 unchanged - 1 fixed = 104
total (was 104) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
26s{color} | {color:green} hbase-client: The patch generated 0 new + 102
unchanged - 1 fixed = 102 total (was 103) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
1s{color} | {color:green} hbase-server: The patch generated 0 new + 585
unchanged - 1 fixed = 585 total (was 586) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
31s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
12m 54s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
58s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}179m 28s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
37s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}224m 14s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.coprocessor.TestIncrementTimeRange |
| | hadoop.hbase.security.access.TestAccessController |
| | hadoop.hbase.client.TestFromClientSide |
| | hadoop.hbase.namespace.TestNamespaceAuditor |
| | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure |
| | hadoop.hbase.client.TestTableFavoredNodes |
| | hadoop.hbase.master.procedure.TestDisableTableProcedure |
| |
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397561#comment-16397561
]
Hadoop QA commented on HBASE-20178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
32s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
21s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
52s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
22s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
48s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
50s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
56s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
57s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} hbase-client: The patch generated 0 new + 36
unchanged - 1 fixed = 36 total (was 37) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
18s{color} | {color:green} hbase-server: The patch generated 0 new + 582
unchanged - 1 fixed = 582 total (was 583) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
56s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 59s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
54s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}151m 53s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
40s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}200m 47s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.coprocessor.TestRegionObserverInterface |
| | hadoop.hbase.client.TestMobRestoreSnapshotFromClient |
| | hadoop.hbase.master.cleaner.TestSnapshotFromMaster |
| | hadoop.hbase.master.TestMasterOperationsForRegionReplicas |
| | hadoop.hbase.TestAcidGuaranteesWithBasicPolicy |
| | hadoop.hbase.security.access.TestAccessController |
| | hadoop.hbase.regionserver.wal.TestSecureAsyncWALReplay |
| | hadoop.hbase.master.TestRollingRestart |
| |
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[ https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397383#comment-16397383 ] stack commented on HBASE-20178: --- .005 cleanup the tablestate usage; confusing (Class called TableState has enum State... and statics to check which state... Make state checking more natural) > [AMv2] Throw exception if hostile environment > - > > Key: HBASE-20178 > URL: https://issues.apache.org/jira/browse/HBASE-20178 > Project: HBase > Issue Type: Sub-task > Components: amv2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: > 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch, > HBASE-20178.branch-2.001.patch, HBASE-20178.branch-2.002.patch, > HBASE-20178.branch-2.003.patch, HBASE-20178.branch-2.004.patch, > HBASE-20178.branch-2.005.patch > > > New pattern where we throw exception on procedure construction if cluster is > going down, hosting master is stopping, table is offline, or table is > read-only. Fail fast rather than later internal to Procedure so can flag > caller there is a problem. > Changed Move/Split/Merge Procedures. > No point queuing a move region for a table that is offline and which may > never be re-enabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[ https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397227#comment-16397227 ] stack commented on HBASE-20178: --- .004 checkstyle, findbugs, test fixes > [AMv2] Throw exception if hostile environment > - > > Key: HBASE-20178 > URL: https://issues.apache.org/jira/browse/HBASE-20178 > Project: HBase > Issue Type: Sub-task > Components: amv2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: > 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch, > HBASE-20178.branch-2.001.patch, HBASE-20178.branch-2.002.patch, > HBASE-20178.branch-2.003.patch, HBASE-20178.branch-2.004.patch > > > New pattern where we throw exception on procedure construction if cluster is > going down, hosting master is stopping, table is offline, or table is > read-only. Fail fast rather than later internal to Procedure so can flag > caller there is a problem. > Changed Move/Split/Merge Procedures. > No point queuing a move region for a table that is offline and which may > never be re-enabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16397090#comment-16397090
]
Hadoop QA commented on HBASE-20178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m
16s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 5 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
21s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
10s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
49s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 7m
12s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
5s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
12s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
23s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
9s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 1m 35s{color}
| {color:red} hbase-server generated 1 new + 187 unchanged - 1 fixed = 188
total (was 188) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
28s{color} | {color:red} hbase-client: The patch generated 1 new + 36 unchanged
- 1 fixed = 37 total (was 37) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
15s{color} | {color:green} hbase-server: The patch generated 0 new + 582
unchanged - 1 fixed = 582 total (was 583) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
21s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 45s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m
5s{color} | {color:red} hbase-server generated 1 new + 0 unchanged - 0 fixed =
1 total (was 0) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
55s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 25m 19s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
21s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 76m 11s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
| | Call to
org.apache.hadoop.hbase.client.TableState.equals(org.apache.hadoop.hbase.client.TableState$State)
in org.apache.hadoop.hbase.master.TableNamespaceManager.isTableEnabled() At
TableNamespaceManager.java: At TableNamespaceManager.java:[line 323] |
| Failed junit tests | hadoop.hbase.TestClientClusterMetrics |
\\
\\
|| Subsystem || Report/Notes ||
| Docker |
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[ https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396966#comment-16396966 ] stack commented on HBASE-20178: --- .003 My isDisabled TableState was incorrectly done. Fixed. > [AMv2] Throw exception if hostile environment > - > > Key: HBASE-20178 > URL: https://issues.apache.org/jira/browse/HBASE-20178 > Project: HBase > Issue Type: Sub-task > Components: amv2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: > 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch, > HBASE-20178.branch-2.001.patch, HBASE-20178.branch-2.002.patch, > HBASE-20178.branch-2.003.patch > > > New pattern where we throw exception on procedure construction if cluster is > going down, hosting master is stopping, table is offline, or table is > read-only. Fail fast rather than later internal to Procedure so can flag > caller there is a problem. > Changed Move/Split/Merge Procedures. > No point queuing a move region for a table that is offline and which may > never be re-enabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396656#comment-16396656
]
Hadoop QA commented on HBASE-20178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
44s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
7s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
53s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
19s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
39s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
31s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
57s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
52s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
26s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
28s{color} | {color:green} The patch hbase-client passed checkstyle {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
5s{color} | {color:green} hbase-server: The patch generated 0 new + 485
unchanged - 1 fixed = 485 total (was 486) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
52s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 12s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
3s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}195m 14s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
44s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}245m 24s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.regionserver.TestRegionMove |
| | hadoop.hbase.coprocessor.TestIncrementTimeRange |
| | hadoop.hbase.snapshot.TestFlushSnapshotFromClient |
| | hadoop.hbase.client.TestAdmin1 |
| | hadoop.hbase.regionserver.TestSplitTransactionOnCluster |
| | hadoop.hbase.master.procedure.TestRestoreSnapshotProcedure |
| | hadoop.hbase.master.TestAssignmentListener |
| | hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster |
| | hadoop.hbase.TestSequenceIdMonotonicallyIncreasing |
| |
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[ https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396501#comment-16396501 ] stack commented on HBASE-20178: --- .002 Had check for enable wrong-way around in check if table enabled. Fix checkstyle too. > [AMv2] Throw exception if hostile environment > - > > Key: HBASE-20178 > URL: https://issues.apache.org/jira/browse/HBASE-20178 > Project: HBase > Issue Type: Sub-task > Components: amv2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: > 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch, > HBASE-20178.branch-2.001.patch, HBASE-20178.branch-2.002.patch > > > New pattern where we throw exception on procedure construction if cluster is > going down, hosting master is stopping, table is offline, or table is > read-only. Fail fast rather than later internal to Procedure so can flag > caller there is a problem. > Changed Move/Split/Merge Procedures. > No point queuing a move region for a table that is offline and which may > never be re-enabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396434#comment-16396434
]
Hadoop QA commented on HBASE-20178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
21s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 4 new or modified test
files. {color} |
|| || || || {color:brown} branch-2 Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
48s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
23s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
47s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
47s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
55s{color} | {color:green} branch-2 passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} branch-2 passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
28s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
14s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
14s{color} | {color:red} hbase-server: The patch generated 7 new + 524
unchanged - 1 fixed = 531 total (was 525) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
8s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
15m 0s{color} | {color:green} Patch does not cause any errors with Hadoop
2.6.5 2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m
5s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m
0s{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}150m 26s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
55s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}197m 44s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestAsyncRegionAdminApi |
| | hadoop.hbase.master.assignment.TestMergeTableRegionsProcedure |
| | hadoop.hbase.master.assignment.TestAssignmentManager |
| | hadoop.hbase.regionserver.wal.TestAsyncWALReplayCompressed |
| | hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient |
| | hadoop.hbase.master.TestTableStateManager |
| | hadoop.hbase.quotas.TestMasterSpaceQuotaObserver |
| | hadoop.hbase.client.TestScannersFromClientSide |
| | hadoop.hbase.TestNamespace |
| | hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster |
| | hadoop.hbase.regionserver.wal.TestWALReplayCompressed |
| | hadoop.hbase.client.TestMobCloneSnapshotFromClient
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[ https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16396230#comment-16396230 ] stack commented on HBASE-20178: --- .002 rebase > [AMv2] Throw exception if hostile environment > - > > Key: HBASE-20178 > URL: https://issues.apache.org/jira/browse/HBASE-20178 > Project: HBase > Issue Type: Sub-task > Components: amv2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: > 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch, > HBASE-20178.branch-2.001.patch > > > New pattern where we throw exception on procedure construction if cluster is > going down, hosting master is stopping, table is offline, or table is > read-only. Fail fast rather than later internal to Procedure so can flag > caller there is a problem. > Changed Move/Split/Merge Procedures. > No point queuing a move region for a table that is offline and which may > never be re-enabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[
https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395779#comment-16395779
]
Hadoop QA commented on HBASE-20178:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 4s{color}
| {color:red} HBASE-20178 does not apply to master. Rebase required? Wrong
Branch? See https://yetus.apache.org/documentation/0.7.0/precommit-patchnames
for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HBASE-20178 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12914106/0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch
|
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/11920/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> [AMv2] Throw exception if hostile environment
> -
>
> Key: HBASE-20178
> URL: https://issues.apache.org/jira/browse/HBASE-20178
> Project: HBase
> Issue Type: Sub-task
> Components: amv2
>Reporter: stack
>Assignee: stack
>Priority: Major
> Fix For: 2.0.0
>
> Attachments:
> 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch
>
>
> New pattern where we throw exception on procedure construction if cluster is
> going down, hosting master is stopping, table is offline, or table is
> read-only. Fail fast rather than later internal to Procedure so can flag
> caller there is a problem.
> Changed Move/Split/Merge Procedures.
> No point queuing a move region for a table that is offline and which may
> never be re-enabled.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-20178) [AMv2] Throw exception if hostile environment
[ https://issues.apache.org/jira/browse/HBASE-20178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16395764#comment-16395764 ] stack commented on HBASE-20178: --- .001 Fail-fast by throwing exception out of Procedure constructor if move but table is disabled, etc. M hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMove.java Test stolen from HBASE-20131 M hbase-client/src/main/java/org/apache/hadoop/hbase/client/TableState.java Add convenience isEnabled/isDisabled M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java Promote assert state to throw exception. M hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterServices.java Add isClusterUp M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java Move constructor now throws exception M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MoveRegionProcedure.java M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java M hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/DisableTableProcedure.java M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ModifyTableProcedure.java M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/RestoreSnapshotProcedure.java M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/TruncateTableProcedure.java Do environment check at construction and fail-fast if hostile. M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/AbstractStateMachineTableProcedure.java Ad checkTableOnline utility method. M hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/GCMergedRegionsProcedure.java Moved to procedure package. Will probably provoke test failures. Let me see. > [AMv2] Throw exception if hostile environment > - > > Key: HBASE-20178 > URL: https://issues.apache.org/jira/browse/HBASE-20178 > Project: HBase > Issue Type: Sub-task > Components: amv2 >Reporter: stack >Priority: Major > Fix For: 2.0.0 > > Attachments: > 0001-HBASE-20178-AMv2-Throw-exception-if-hostile-environm.patch > > > New pattern where we throw exception on procedure construction if cluster is > going down, hosting master is stopping, table is offline, or table is > read-only. Fail fast rather than later internal to Procedure so can flag > caller there is a problem. > Changed Move/Split/Merge Procedures. > No point queuing a move region for a table that is offline and which may > never be re-enabled. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
