[jira] [Commented] (HBASE-20242) The open sequence number will grow if we fail to open a region after writing the max sequence id file
[ https://issues.apache.org/jira/browse/HBASE-20242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430914#comment-16430914 ] Hudson commented on HBASE-20242: Results for branch HBASE-20046-branch-2 [build #7 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20046-branch-2/7/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20046-branch-2/7//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20046-branch-2/7//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-20046-branch-2/7//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > The open sequence number will grow if we fail to open a region after writing > the max sequence id file > - > > Key: HBASE-20242 > URL: https://issues.apache.org/jira/browse/HBASE-20242 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.1.0 > > Attachments: HBASE-20242.patch > > > We write the current max sequence id plus one as the new max sequence id so > if we fail before report RIT to master, when assign next time the open > sequence number will increase by one. > But it is possible that we fail before writing the open region marker so > there will no actual WAL with the sequence id which is the open sequence > number minus one. This will cause the serial replication to be stuck. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20242) The open sequence number will grow if we fail to open a region after writing the max sequence id file
[ https://issues.apache.org/jira/browse/HBASE-20242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430826#comment-16430826 ] Hudson commented on HBASE-20242: Results for branch branch-2 [build #590 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/590/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/590//General_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/590//JDK8_Nightly_Build_Report_(Hadoop2)/] (/) {color:green}+1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/590//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > The open sequence number will grow if we fail to open a region after writing > the max sequence id file > - > > Key: HBASE-20242 > URL: https://issues.apache.org/jira/browse/HBASE-20242 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0, 2.1.0 > > Attachments: HBASE-20242.patch > > > We write the current max sequence id plus one as the new max sequence id so > if we fail before report RIT to master, when assign next time the open > sequence number will increase by one. > But it is possible that we fail before writing the open region marker so > there will no actual WAL with the sequence id which is the open sequence > number minus one. This will cause the serial replication to be stuck. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20242) The open sequence number will grow if we fail to open a region after writing the max sequence id file
[ https://issues.apache.org/jira/browse/HBASE-20242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416683#comment-16416683 ] Hudson commented on HBASE-20242: Results for branch HBASE-19064 [build #77 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/HBASE-19064/77//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > The open sequence number will grow if we fail to open a region after writing > the max sequence id file > - > > Key: HBASE-20242 > URL: https://issues.apache.org/jira/browse/HBASE-20242 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20242.patch > > > We write the current max sequence id plus one as the new max sequence id so > if we fail before report RIT to master, when assign next time the open > sequence number will increase by one. > But it is possible that we fail before writing the open region marker so > there will no actual WAL with the sequence id which is the open sequence > number minus one. This will cause the serial replication to be stuck. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20242) The open sequence number will grow if we fail to open a region after writing the max sequence id file
[ https://issues.apache.org/jira/browse/HBASE-20242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16409597#comment-16409597 ] Hudson commented on HBASE-20242: Results for branch master [build #269 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/269/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/269//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/269//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/269//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > The open sequence number will grow if we fail to open a region after writing > the max sequence id file > - > > Key: HBASE-20242 > URL: https://issues.apache.org/jira/browse/HBASE-20242 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20242.patch > > > We write the current max sequence id plus one as the new max sequence id so > if we fail before report RIT to master, when assign next time the open > sequence number will increase by one. > But it is possible that we fail before writing the open region marker so > there will no actual WAL with the sequence id which is the open sequence > number minus one. This will cause the serial replication to be stuck. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20242) The open sequence number will grow if we fail to open a region after writing the max sequence id file
[ https://issues.apache.org/jira/browse/HBASE-20242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408246#comment-16408246 ] Hadoop QA commented on HBASE-20242: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 19s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 13s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 55s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 55s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 33s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 40s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 48s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 19m 22s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.4 or 3.0.0. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 28s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green}150m 57s{color} | {color:green} hbase-server in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 24s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}196m 11s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:eee3b01 | | JIRA Issue | HBASE-20242 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12915481/HBASE-20242.patch | | Optional Tests | asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 26f85cc20341 3.13.0-137-generic #186-Ubuntu SMP Mon Dec 4 19:09:19 UTC 2017 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 8ab7b20f48 | | maven | version: Apache Maven 3.5.3 (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T19:49:05Z) | | Default Java | 1.8.0_151 | | findbugs | v3.1.0-RC3 | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/12056/testReport/ | | Max. process+thread count | 4564 (vs. ulimit of 1) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/12056/console | | Powered by | Apache Yetus 0.7.0 http://yetus.apache.org | This message was automatically generated. > The open sequence num
[jira] [Commented] (HBASE-20242) The open sequence number will grow if we fail to open a region after writing the max sequence id file
[ https://issues.apache.org/jira/browse/HBASE-20242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407975#comment-16407975 ] Zheng Hu commented on HBASE-20242: -- Looks good to me if the Hadoop QA says OK. > The open sequence number will grow if we fail to open a region after writing > the max sequence id file > - > > Key: HBASE-20242 > URL: https://issues.apache.org/jira/browse/HBASE-20242 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20242.patch > > > We write the current max sequence id plus one as the new max sequence id so > if we fail before report RIT to master, when assign next time the open > sequence number will increase by one. > But it is possible that we fail before writing the open region marker so > there will no actual WAL with the sequence id which is the open sequence > number minus one. This will cause the serial replication to be stuck. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-20242) The open sequence number will grow if we fail to open a region after writing the max sequence id file
[ https://issues.apache.org/jira/browse/HBASE-20242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16407913#comment-16407913 ] Duo Zhang commented on HBASE-20242: --- The fix is very simple. Just write 'nextSeqId - 1' instead of 'nextSeqId'. Add a UT to confirm it works. [~zghaobac] [~openinx] PTAL. > The open sequence number will grow if we fail to open a region after writing > the max sequence id file > - > > Key: HBASE-20242 > URL: https://issues.apache.org/jira/browse/HBASE-20242 > Project: HBase > Issue Type: Sub-task >Reporter: Duo Zhang >Assignee: Duo Zhang >Priority: Major > Fix For: 3.0.0 > > Attachments: HBASE-20242.patch > > > We write the current max sequence id plus one as the new max sequence id so > if we fail before report RIT to master, when assign next time the open > sequence number will increase by one. > But it is possible that we fail before writing the open region marker so > there will no actual WAL with the sequence id which is the open sequence > number minus one. This will cause the serial replication to be stuck. -- This message was sent by Atlassian JIRA (v7.6.3#76005)