[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-12-14 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721174#comment-16721174 ] Hudson commented on HBASE-20401: Results for branch branch-1.3 [build #576 on

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-12-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720784#comment-16720784 ] Hudson commented on HBASE-20401: SUCCESS: Integrated in Jenkins build HBase-1.3-IT #509 (See

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553796#comment-16553796 ] Hudson commented on HBASE-20401: Results for branch branch-1 [build #390 on

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553352#comment-16553352 ] Hudson commented on HBASE-20401: Results for branch branch-1.4 [build #394 on

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552877#comment-16552877 ] Hudson commented on HBASE-20401: Results for branch master [build #405 on

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552676#comment-16552676 ] Hudson commented on HBASE-20401: Results for branch branch-2 [build #1015 on

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552628#comment-16552628 ] Hudson commented on HBASE-20401: Results for branch branch-2.0 [build #581 on

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552607#comment-16552607 ] Hudson commented on HBASE-20401: Results for branch branch-2.1 [build #93 on

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-23 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552537#comment-16552537 ] Reid Chan commented on HBASE-20401: --- Unrelated failed UTs. Pushed to branch-1 and branch-1.4. > Make

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552477#comment-16552477 ] Hadoop QA commented on HBASE-20401: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-22 Thread Tak Lon (Stephen) Wu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552324#comment-16552324 ] Tak Lon (Stephen) Wu commented on HBASE-20401: -- [~reidchan] Thanks, it seems that I will

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-22 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552322#comment-16552322 ] Reid Chan commented on HBASE-20401: --- Let's wait for branch-1 QA results > Make `MAX_WAIT` and

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-22 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552226#comment-16552226 ] Reid Chan commented on HBASE-20401: --- Pushed to master, branch-2, branch-2.0, branch-2.1. Thanks for

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551953#comment-16551953 ] Hadoop QA commented on HBASE-20401: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-21 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551785#comment-16551785 ] Reid Chan commented on HBASE-20401: --- nit: {code} import java.util.concurrent.LinkedBlockingQueue;

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-20 Thread Tak Lon (Stephen) Wu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16551433#comment-16551433 ] Tak Lon (Stephen) Wu commented on HBASE-20401: -- [~reidchan] for branch-1 patch, can we wait

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-20 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550633#comment-16550633 ] Reid Chan commented on HBASE-20401: --- ping [~yuzhih...@gmail.com], [~mdrob], have more comments? >

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550549#comment-16550549 ] Hadoop QA commented on HBASE-20401: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Tak Lon (Stephen) Wu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550223#comment-16550223 ] Tak Lon (Stephen) Wu commented on HBASE-20401: -- [~reidchan] thanks for catching theĀ 

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550155#comment-16550155 ] Reid Chan commented on HBASE-20401: --- Can the RN be more user friendly? Those who doesn't read source

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550126#comment-16550126 ] Reid Chan commented on HBASE-20401: --- Modified and new added configurations support {{Dynamic

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550033#comment-16550033 ] Hadoop QA commented on HBASE-20401: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16550005#comment-16550005 ] Hadoop QA commented on HBASE-20401: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Tak Lon (Stephen) Wu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549840#comment-16549840 ] Tak Lon (Stephen) Wu commented on HBASE-20401: -- [~yuzhih...@gmail.com] I have attached the

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Tak Lon (Stephen) Wu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549835#comment-16549835 ] Tak Lon (Stephen) Wu commented on HBASE-20401: -- [~mdrob] I modified the RN to include the

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Mike Drob (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549802#comment-16549802 ] Mike Drob commented on HBASE-20401: --- Sorry for the late review, can we add some docs for the when

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549140#comment-16549140 ] Ted Yu commented on HBASE-20401: [~taklwu] Please fill out release note. > Make `MAX_WAIT` and

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549136#comment-16549136 ] Ted Yu commented on HBASE-20401: lgtm {code} +if (cleanerThreadTimeoutMsec !=

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549126#comment-16549126 ] Reid Chan commented on HBASE-20401: --- Yes, i can, if you have no more comment and give +1.

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-19 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549113#comment-16549113 ] Ted Yu commented on HBASE-20401: [~taklwu]: Can you attach branch-1 patch ? [~reidchan]: Can you commit

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548757#comment-16548757 ] Hadoop QA commented on HBASE-20401: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-18 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548695#comment-16548695 ] Reid Chan commented on HBASE-20401: --- LGTM. > Make `MAX_WAIT` and `waitIfNotFinished` in

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548681#comment-16548681 ] Hadoop QA commented on HBASE-20401: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-18 Thread Tak Lon (Stephen) Wu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548509#comment-16548509 ] Tak Lon (Stephen) Wu commented on HBASE-20401: -- [~yuzhih...@gmail.com] I modified the

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-18 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548428#comment-16548428 ] Ted Yu commented on HBASE-20401: {code} wait(waitIfNotFinished); waitTime +=

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-18 Thread Tak Lon (Stephen) Wu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16548429#comment-16548429 ] Tak Lon (Stephen) Wu commented on HBASE-20401: -- [~reidchan] I have done updated it with new

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-17 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547349#comment-16547349 ] Reid Chan commented on HBASE-20401: --- BTW, provide patch for master branch first, and after +1, then

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-17 Thread Reid Chan (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547347#comment-16547347 ] Reid Chan commented on HBASE-20401: --- There's also a MAX_WAIT in HFileCleaner, can you work together?

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-17 Thread Tak Lon (Stephen) Wu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547239#comment-16547239 ] Tak Lon (Stephen) Wu commented on HBASE-20401: -- [~yuzhih...@gmail.com] thanks for reviewing

[jira] [Commented] (HBASE-20401) Make `MAX_WAIT` and `waitIfNotFinished` in CleanerContext configurable

2018-07-17 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547227#comment-16547227 ] Ted Yu commented on HBASE-20401: {code} 55static final long DEFAULT_CLEANER_THREAD_MAX_WAIT_MSEC