[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16553300#comment-16553300
]
huaxiang sun commented on HBASE-20697:
--
Thanks [~zghaobac] for backporting to 1.2 and 1.3.
> Can't
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552545#comment-16552545
]
Hudson commented on HBASE-20697:
FAILURE: Integrated in Jenkins build HBase-1.2-IT #1136 (See
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552544#comment-16552544
]
Hudson commented on HBASE-20697:
FAILURE: Integrated in Jenkins build HBase-1.3-IT #438 (See
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552528#comment-16552528
]
Guanghao Zhang commented on HBASE-20697:
Let me commit it to branch-1.2 and brnach-1.3. Thanks
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16549662#comment-16549662
]
stack commented on HBASE-20697:
---
Anyone want to hazard a guess at what the benefit of this patch might be
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547166#comment-16547166
]
stack commented on HBASE-20697:
---
bq. The fix is generic, getAllRegionLocations is not caching all regions'
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547060#comment-16547060
]
huaxiang sun commented on HBASE-20697:
--
HBASE-20697 is a fix for HBASE-15674, which is committed to
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545899#comment-16545899
]
huaxiang sun commented on HBASE-20697:
--
[~stack] The fix is generic, getAllRegionLocations is not
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545896#comment-16545896
]
stack commented on HBASE-20697:
---
So, this issue fixes caching of region replicas? We weren't doing it
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16545890#comment-16545890
]
stack commented on HBASE-20697:
---
[~zghaobac] Thanks for the backport.
> Can't cache All region locations
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542160#comment-16542160
]
Hudson commented on HBASE-20697:
Results for branch branch-1.4
[build #383 on
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541463#comment-16541463
]
Hudson commented on HBASE-20697:
Results for branch branch-1
[build #378 on
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541462#comment-16541462
]
Hudson commented on HBASE-20697:
Results for branch branch-2.0
[build #539 on
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541208#comment-16541208
]
Guanghao Zhang commented on HBASE-20697:
Pushed the addenum patch to branch-1 and branch-1.4.
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541147#comment-16541147
]
Andrew Purtell commented on HBASE-20697:
+1 on addendum, thanks
> Can't cache All region
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541127#comment-16541127
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541082#comment-16541082
]
Guanghao Zhang commented on HBASE-20697:
Pushed to branch-2.0, too.
> Can't cache All region
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540608#comment-16540608
]
Hudson commented on HBASE-20697:
Results for branch branch-1.4
[build #382 on
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16540172#comment-16540172
]
Hudson commented on HBASE-20697:
Results for branch master
[build #393 on
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539971#comment-16539971
]
Hudson commented on HBASE-20697:
Results for branch branch-2.1
[build #48 on
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539939#comment-16539939
]
Hudson commented on HBASE-20697:
Results for branch branch-1
[build #377 on
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539909#comment-16539909
]
Hudson commented on HBASE-20697:
Results for branch branch-2
[build #970 on
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539705#comment-16539705
]
Guanghao Zhang commented on HBASE-20697:
Thanks [~smartZY] for contributing.
> Can't cache All
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539702#comment-16539702
]
Guanghao Zhang commented on HBASE-20697:
Ping [~stack] for branch-2.0. I thought it is ok to fix
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539700#comment-16539700
]
Guanghao Zhang commented on HBASE-20697:
Pushed to master, branch-2, and branch-2.1. Pushed the
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539295#comment-16539295
]
Andrew Purtell commented on HBASE-20697:
+1 for all of the branch-1s from me
> Can't cache All
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538581#comment-16538581
]
Duo Zhang commented on HBASE-20697:
---
+1. This is a bug fix so please include it in 2.1.
> Can't cache
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538460#comment-16538460
]
Guanghao Zhang commented on HBASE-20697:
Ping [~apurtell] for 1.4.
> Can't cache All region
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538457#comment-16538457
]
Guanghao Zhang commented on HBASE-20697:
+1 for 003 patch. Will commit it if no objections.
Ping
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538449#comment-16538449
]
zhaoyuan commented on HBASE-20697:
--
ping [~zghaobac]
Had fixed the check style problems
> Can't cache
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16538422#comment-16538422
]
Hadoop QA commented on HBASE-20697:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536833#comment-16536833
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16536710#comment-16536710
]
Guanghao Zhang commented on HBASE-20697:
+1. Reattach the patch for Hadoop QA.
[~smartZY] please
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519915#comment-16519915
]
zhaoyuan commented on HBASE-20697:
--
I think In RegionLocations constructer , the property
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519217#comment-16519217
]
Guanghao Zhang commented on HBASE-20697:
The reason of RegionLocations's change is?
> Can't
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16519062#comment-16519062
]
zhaoyuan commented on HBASE-20697:
--
ping [~zghaobac] [~busbey]
Please take a look about the patch for
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512419#comment-16512419
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512169#comment-16512169
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512035#comment-16512035
]
zhaoyuan commented on HBASE-20697:
--
After fix the RegionLocations(HRegionLocation... locations) ,the
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512033#comment-16512033
]
zhaoyuan commented on HBASE-20697:
--
I think In RegionLocations constructer , the property
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512026#comment-16512026
]
zhaoyuan commented on HBASE-20697:
--
Hi [~zghaobac] I found something interesting when digging into
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510898#comment-16510898
]
Guanghao Zhang commented on HBASE-20697:
Failed ut not related. Please add a patch for master
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510873#comment-16510873
]
zhaoyuan commented on HBASE-20697:
--
According to the result ,I will remove the unused import to resolve
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510816#comment-16510816
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510702#comment-16510702
]
Guanghao Zhang commented on HBASE-20697:
+1 for 004 patch. Let's see the Hadoop QA result.
Ping
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510595#comment-16510595
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510573#comment-16510573
]
zhaoyuan commented on HBASE-20697:
--
Using listRegionLocations directly seems good,Let me try it
>
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510543#comment-16510543
]
Guanghao Zhang commented on HBASE-20697:
How about using listRegionLocations directly?
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510542#comment-16510542
]
Guanghao Zhang commented on HBASE-20697:
How about using listRegionLocations directly?
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510536#comment-16510536
]
Guanghao Zhang commented on HBASE-20697:
Use byte[]'s equals method not right? You can take a
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16510372#comment-16510372
]
zhaoyuan commented on HBASE-20697:
--
[~yuzhih...@gmail.com] Thanks for your review and I will add some
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509964#comment-16509964
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509843#comment-16509843
]
Ted Yu commented on HBASE-20697:
{code}
745
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509803#comment-16509803
]
Ted Yu commented on HBASE-20697:
The test you modify is now in TestConnectionImplementation.
Can you
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509399#comment-16509399
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509397#comment-16509397
]
zhaoyuan commented on HBASE-20697:
--
I get you and I am familiar with 1.2.6 so I do the patch for
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509217#comment-16509217
]
Guanghao Zhang commented on HBASE-20697:
bq. for(RegionLocations
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509144#comment-16509144
]
zhaoyuan commented on HBASE-20697:
--
Hi [~zghaobac] I checked out the failed test TestAdmin1 and ran it
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16508345#comment-16508345
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507944#comment-16507944
]
zhaoyuan commented on HBASE-20697:
--
Fixing the failed unit tests
> Can't cache All region locations of
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507898#comment-16507898
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507888#comment-16507888
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507884#comment-16507884
]
Guanghao Zhang commented on HBASE-20697:
You can use dev-support/submit-patch.py to submit
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507883#comment-16507883
]
Guanghao Zhang commented on HBASE-20697:
Please add patch for master first, then add patch for
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507876#comment-16507876
]
zhaoyuan commented on HBASE-20697:
--
Restart progress and attach the new patch to trigger QA
> Can't
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507800#comment-16507800
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507739#comment-16507739
]
zhaoyuan commented on HBASE-20697:
--
I get you and I will fix this problem ,thanks [~zghaobac]
> Can't
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507700#comment-16507700
]
Guanghao Zhang commented on HBASE-20697:
bq. call RegionLocations.size() and it return 1 and
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507647#comment-16507647
]
zhaoyuan commented on HBASE-20697:
--
I am not familiar with region replica too …… and during
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507637#comment-16507637
]
Guanghao Zhang commented on HBASE-20697:
bq. connection.cacheLocation(tableName, new
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507634#comment-16507634
]
zhaoyuan commented on HBASE-20697:
--
[~zghaobac] Hi What's wrong with docker?Should I resubmit the patch
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507625#comment-16507625
]
Hadoop QA commented on HBASE-20697:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505675#comment-16505675
]
zhaoyuan commented on HBASE-20697:
--
[~zghaobac] Let me try to work on this.
> Can't cache All region
[
https://issues.apache.org/jira/browse/HBASE-20697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505662#comment-16505662
]
Guanghao Zhang commented on HBASE-20697:
{code:java}
/**
* Container for holding a list of
74 matches
Mail list logo