[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-08-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569059#comment-16569059 ] Hudson commented on HBASE-20708: Results for branch branch-2.0 [build #629 on

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-07-31 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16563616#comment-16563616 ] stack commented on HBASE-20708: --- Filed issue to evaluate backport to branch 2.0.2. > Remove the usage of

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517692#comment-16517692 ] Hudson commented on HBASE-20708: Results for branch master [build #370 on

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16517252#comment-16517252 ] Hudson commented on HBASE-20708: Results for branch branch-2 [build #880 on

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-19 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516705#comment-16516705 ] Duo Zhang commented on HBASE-20708: --- Will commit shortly after fixing the checkstyle warnings. >

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16516622#comment-16516622 ] Hadoop QA commented on HBASE-20708: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-18 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515650#comment-16515650 ] Duo Zhang commented on HBASE-20708: --- Any other concerns sir [~stack]. Thanks. > Remove the usage of

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515070#comment-16515070 ] Hadoop QA commented on HBASE-20708: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514265#comment-16514265 ] stack commented on HBASE-20708: --- Left comments up on rb. Put the design doc in description because it

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16514123#comment-16514123 ] Hadoop QA commented on HBASE-20708: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513818#comment-16513818 ] Duo Zhang commented on HBASE-20708: --- Add more comments. > Remove the usage of RecoverMetaProcedure in

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513808#comment-16513808 ] Duo Zhang commented on HBASE-20708: --- All green, good. Thanks [~allan163] for reviewing. Any comments

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513743#comment-16513743 ] Allan Yang commented on HBASE-20708: Just reviewed the patch, I like the idea of removing the

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513739#comment-16513739 ] Hadoop QA commented on HBASE-20708: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513548#comment-16513548 ] Duo Zhang commented on HBASE-20708: --- Use a little trick to make the UT pass. In MetaTableAccessor, if

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513538#comment-16513538 ] Duo Zhang commented on HBASE-20708: --- OK I found the side effect to not always set meta state to OPEN.

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513483#comment-16513483 ] Duo Zhang commented on HBASE-20708: --- OK the initialization order for AssignmentManager and

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513468#comment-16513468 ] Hadoop QA commented on HBASE-20708: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513414#comment-16513414 ] Duo Zhang commented on HBASE-20708: --- {quote} If a Master joins a cluster where there is no crashed RS,

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-15 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513396#comment-16513396 ] Duo Zhang commented on HBASE-20708: --- {quote} Can I have comment/edit rights on the design doc Duo

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513330#comment-16513330 ] stack commented on HBASE-20708: --- Can I have comment/edit rights on the design doc [~Apache9] please? bq.

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513315#comment-16513315 ] Hadoop QA commented on HBASE-20708: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513295#comment-16513295 ] Duo Zhang commented on HBASE-20708: --- Fix master failover, and add more comments. > Remove the usage

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513204#comment-16513204 ] Duo Zhang commented on HBASE-20708: --- It seems that the master session expire still can not pass, will

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513200#comment-16513200 ] Duo Zhang commented on HBASE-20708: --- OK seems just a bug, missed a negative... Let me post a new

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513181#comment-16513181 ] Duo Zhang commented on HBASE-20708: --- OK, there is a problem that how we deal with master graceful

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16513166#comment-16513166 ] Duo Zhang commented on HBASE-20708: --- OK, not too many. Let me check them. > Remove the usage of

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512825#comment-16512825 ] Hadoop QA commented on HBASE-20708: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512499#comment-16512499 ] Duo Zhang commented on HBASE-20708: --- Add more comments. > Remove the usage of RecoverMetaProcedure in

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512470#comment-16512470 ] Duo Zhang commented on HBASE-20708: --- Review board link: https://reviews.apache.org/r/67598/ > Remove

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512431#comment-16512431 ] Hadoop QA commented on HBASE-20708: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512306#comment-16512306 ] Hadoop QA commented on HBASE-20708: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512287#comment-16512287 ] Duo Zhang commented on HBASE-20708: --- Fixed TestServerCrashProcedure. > Remove the usage of

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-14 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16512209#comment-16512209 ] Duo Zhang commented on HBASE-20708: --- Let's see how many UTs will fail... It is known that

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-13 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511868#comment-16511868 ] Duo Zhang commented on HBASE-20708: --- Hey boss I've already linked the simple design doc above [~stack]

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-13 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511206#comment-16511206 ] stack commented on HBASE-20708: --- [~uagashe] FYI Ok. The OPEN Hard-coding then came in with original AMv2

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-13 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16511180#comment-16511180 ] Duo Zhang commented on HBASE-20708: --- {quote} IIRC, thinking was probably that hbase:meta would never

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-12 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509385#comment-16509385 ] Duo Zhang commented on HBASE-20708: --- {quote} IIRC, 'waitMetaLoaded' will only blocking if the master

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-12 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509377#comment-16509377 ] Allan Yang commented on HBASE-20708: [~Apache9], IIRC, 'waitMetaLoaded' will only blocking if the

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-12 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509265#comment-16509265 ] Duo Zhang commented on HBASE-20708: --- {quote} IIRC, thinking was probably that hbase:meta would never

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-11 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509162#comment-16509162 ] stack commented on HBASE-20708: --- Can we do up an outline doc [~Apache9]? I'm having a bit of trouble

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16509129#comment-16509129 ] Duo Zhang commented on HBASE-20708: --- And there is another problem for master restart is that, we need

[jira] [Commented] (HBASE-20708) Remove the usage of RecoverMetaProcedure in master startup

2018-06-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-20708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507893#comment-16507893 ] Duo Zhang commented on HBASE-20708: --- So when startup, we will first go to zookeeper to ask for the