[jira] [Commented] (HBASE-21153) Shaded client jars should always build in relevant phase to avoid confusion
[
https://issues.apache.org/jira/browse/HBASE-21153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605785#comment-16605785
]
Hudson commented on HBASE-21153:
Results for branch master
[build #476 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/476/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/476//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/476//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/476//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Shaded client jars should always build in relevant phase to avoid confusion
> ---
>
> Key: HBASE-21153
> URL: https://issues.apache.org/jira/browse/HBASE-21153
> Project: HBase
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.0.0, 2.1.0, 2.2.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.1
>
> Attachments: HBASE-21153.0.patch, ls.txt
>
>
> *edit*:
> Now that our assembly directly relies on the shaded clients, failing to build
> the actual client jars (e.g. because {{-P release}} is required to fill in
> their contents) causes confusing errors for downstream folks about classes
> not being found when they run simple commands like {{hbase version}}.
> We should always fill in the shaded artifacts to make our build easier to
> understand.
> *original report:*: When I run the {{hbase version}} command it comes back
> with:
> {code}$ ./bin/hbase version
> Error: Could not find or load main class
> org.apache.hadoop.hbase.util.GetJavaProperty
> Error: Could not find or load main class
> org.apache.hadoop.hbase.util.VersionInfo{code}
> The two classes are in hbase-commons.
> The nice shaded refactoring of our bin/hbase -- i.e. using shaded jars
> wherever possible -- may have overstretched expecting version to work with
> shaded client ([~busbey] ?). If so, fix is < one-liner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21153) Shaded client jars should always build in relevant phase to avoid confusion
[
https://issues.apache.org/jira/browse/HBASE-21153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605296#comment-16605296
]
Hudson commented on HBASE-21153:
Results for branch branch-2
[build #1207 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1207/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1207//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1207//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1207//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Shaded client jars should always build in relevant phase to avoid confusion
> ---
>
> Key: HBASE-21153
> URL: https://issues.apache.org/jira/browse/HBASE-21153
> Project: HBase
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.0.0, 2.1.0, 2.2.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.1
>
> Attachments: HBASE-21153.0.patch, ls.txt
>
>
> *edit*:
> Now that our assembly directly relies on the shaded clients, failing to build
> the actual client jars (e.g. because {{-P release}} is required to fill in
> their contents) causes confusing errors for downstream folks about classes
> not being found when they run simple commands like {{hbase version}}.
> We should always fill in the shaded artifacts to make our build easier to
> understand.
> *original report:*: When I run the {{hbase version}} command it comes back
> with:
> {code}$ ./bin/hbase version
> Error: Could not find or load main class
> org.apache.hadoop.hbase.util.GetJavaProperty
> Error: Could not find or load main class
> org.apache.hadoop.hbase.util.VersionInfo{code}
> The two classes are in hbase-commons.
> The nice shaded refactoring of our bin/hbase -- i.e. using shaded jars
> wherever possible -- may have overstretched expecting version to work with
> shaded client ([~busbey] ?). If so, fix is < one-liner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21153) Shaded client jars should always build in relevant phase to avoid confusion
[
https://issues.apache.org/jira/browse/HBASE-21153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16605253#comment-16605253
]
Hudson commented on HBASE-21153:
Results for branch branch-2.1
[build #284 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/284/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/284//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/284//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/284//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Shaded client jars should always build in relevant phase to avoid confusion
> ---
>
> Key: HBASE-21153
> URL: https://issues.apache.org/jira/browse/HBASE-21153
> Project: HBase
> Issue Type: Improvement
> Components: build
>Affects Versions: 3.0.0, 2.1.0, 2.2.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.1
>
> Attachments: HBASE-21153.0.patch, ls.txt
>
>
> *edit*:
> Now that our assembly directly relies on the shaded clients, failing to build
> the actual client jars (e.g. because {{-P release}} is required to fill in
> their contents) causes confusing errors for downstream folks about classes
> not being found when they run simple commands like {{hbase version}}.
> We should always fill in the shaded artifacts to make our build easier to
> understand.
> *original report:*: When I run the {{hbase version}} command it comes back
> with:
> {code}$ ./bin/hbase version
> Error: Could not find or load main class
> org.apache.hadoop.hbase.util.GetJavaProperty
> Error: Could not find or load main class
> org.apache.hadoop.hbase.util.VersionInfo{code}
> The two classes are in hbase-commons.
> The nice shaded refactoring of our bin/hbase -- i.e. using shaded jars
> wherever possible -- may have overstretched expecting version to work with
> shaded client ([~busbey] ?). If so, fix is < one-liner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21153) Shaded client jars should always build in relevant phase to avoid confusion
[
https://issues.apache.org/jira/browse/HBASE-21153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604970#comment-16604970
]
stack commented on HBASE-21153:
---
+1
Needs RN shouting about longer build time but I'd doubt anyone will notice
(smile).
> Shaded client jars should always build in relevant phase to avoid confusion
> ---
>
> Key: HBASE-21153
> URL: https://issues.apache.org/jira/browse/HBASE-21153
> Project: HBase
> Issue Type: Bug
> Components: build
>Affects Versions: 3.0.0, 2.1.0, 2.2.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.1
>
> Attachments: HBASE-21153.0.patch, ls.txt
>
>
> *edit*:
> Now that our assembly directly relies on the shaded clients, failing to build
> the actual client jars (e.g. because {{-P release}} is required to fill in
> their contents) causes confusing errors for downstream folks about classes
> not being found when they run simple commands like {{hbase version}}.
> We should always fill in the shaded artifacts to make our build easier to
> understand.
> *original report:*: When I run the {{hbase version}} command it comes back
> with:
> {code}$ ./bin/hbase version
> Error: Could not find or load main class
> org.apache.hadoop.hbase.util.GetJavaProperty
> Error: Could not find or load main class
> org.apache.hadoop.hbase.util.VersionInfo{code}
> The two classes are in hbase-commons.
> The nice shaded refactoring of our bin/hbase -- i.e. using shaded jars
> wherever possible -- may have overstretched expecting version to work with
> shaded client ([~busbey] ?). If so, fix is < one-liner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21153) Shaded client jars should always build in relevant phase to avoid confusion
[
https://issues.apache.org/jira/browse/HBASE-21153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604951#comment-16604951
]
Hadoop QA commented on HBASE-21153:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}
0m 0s{color} | {color:orange} The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch. Also
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
54s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m
3s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m
4s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
46s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
12m 24s{color} | {color:green} Patch does not cause any errors with Hadoop
2.7.4 or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
35s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
14s{color} | {color:green} hbase-shaded-client-byo-hadoop in the patch passed.
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
14s{color} | {color:green} hbase-shaded-client in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m
18s{color} | {color:green} hbase-shaded-mapreduce in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
29s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 28s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21153 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12938534/HBASE-21153.0.patch |
| Optional Tests | asflicense javac javadoc unit shadedjars hadoopcheck
xml compile |
| uname | Linux 6e03e66c6b08 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / cc414bdeab |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| Default Java | 1.8.0_181 |
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/14319/testReport/ |
| Max. process+thread count | 87 (vs. ulimit of 1) |
| modules | C: hbase-shaded/hbase-shaded-client-byo-hadoop
hbase-shaded/hbase-shaded-client
[jira] [Commented] (HBASE-21153) Shaded client jars should always build in relevant phase to avoid confusion
[
https://issues.apache.org/jira/browse/HBASE-21153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604873#comment-16604873
]
Sean Busbey commented on HBASE-21153:
-
Reproduced the error locally and it's even more confusing if you're on a Hadoop
version missing YARN-7190. In that case my 2.1.1-SNAPSHOT build reported the
hbase version as 1.2.6. :(
> Shaded client jars should always build in relevant phase to avoid confusion
> ---
>
> Key: HBASE-21153
> URL: https://issues.apache.org/jira/browse/HBASE-21153
> Project: HBase
> Issue Type: Bug
>Affects Versions: 3.0.0, 2.1.0, 2.2.0
>Reporter: stack
>Assignee: Sean Busbey
>Priority: Major
> Fix For: 3.0.0, 2.2.0, 2.1.1
>
> Attachments: ls.txt
>
>
> *edit*:
> Now that our assembly directly relies on the shaded clients, failing to build
> the actual client jars (e.g. because {{-P release}} is required to fill in
> their contents) causes confusing errors for downstream folks about classes
> not being found when they run simple commands like {{hbase version}}.
> We should always fill in the shaded artifacts to make our build easier to
> understand.
> *original report:*: When I run the {{hbase version}} command it comes back
> with:
> {code}$ ./bin/hbase version
> Error: Could not find or load main class
> org.apache.hadoop.hbase.util.GetJavaProperty
> Error: Could not find or load main class
> org.apache.hadoop.hbase.util.VersionInfo{code}
> The two classes are in hbase-commons.
> The nice shaded refactoring of our bin/hbase -- i.e. using shaded jars
> wherever possible -- may have overstretched expecting version to work with
> shaded client ([~busbey] ?). If so, fix is < one-liner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
