[jira] [Commented] (HBASE-21460) correct Document Configurable Bucket Sizes in bucketCache
[
https://issues.apache.org/jira/browse/HBASE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689275#comment-16689275
]
Hudson commented on HBASE-21460:
Results for branch master
[build #609 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/609/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/609//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/609//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/609//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> correct Document Configurable Bucket Sizes in bucketCache
> -
>
> Key: HBASE-21460
> URL: https://issues.apache.org/jira/browse/HBASE-21460
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-21460.v1.patch, HBASE-21460.v2.patch
>
>
> we use the bucket cache(offheap),found the doc was error,
> the property bucket sizes shoul be "hbase.bucketcache.bucket.sizes" instead
> of "hfile.block.cache.sizes"
> CacheConfig.java
> /**
> * A comma-delimited array of values for use as bucket sizes.
> */
> public static final String BUCKET_CACHE_BUCKETS_KEY =
> "hbase.bucketcache.bucket.sizes";
> the doc was:
>
>
> HBASE-10641 introduced the ability to configure multiple sizes for the
> buckets of the BucketCache, in HBase 0.98 and newer. To configurable multiple
> bucket sizes, configure the new property
> {color:#ff}{{hfile.block.cache.sizes}}{color} (instead of{color:#ff}
> {{hfile.block.cache.size}}{color}) to a comma-separated list of block sizes,
> ordered from smallest to largest, with no spaces. The goal is to optimize the
> bucket sizes based on your data access patterns. The following example
> configures buckets of size 4096 and 8192.
> {color:#ff}hfile.block.cache.sizes{color}
> 4096,8192
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21460) correct Document Configurable Bucket Sizes in bucketCache
[
https://issues.apache.org/jira/browse/HBASE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688268#comment-16688268
]
Hadoop QA commented on HBASE-21460:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
12s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
36s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 5m
10s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
17s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 5m
3s{color} | {color:blue} patch has no errors when building the reference guide.
See footer for rendered docs, which you should manually inspect. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 52s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21460 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12948338/HBASE-21460.v2.patch |
| Optional Tests | dupname asflicense refguide |
| uname | Linux 8efbd629365f 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 130057f137 |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/15048/artifact/patchprocess/branch-site/book.html
|
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/15048/artifact/patchprocess/patch-site/book.html
|
| Max. process+thread count | 87 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/15048/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> correct Document Configurable Bucket Sizes in bucketCache
> -
>
> Key: HBASE-21460
> URL: https://issues.apache.org/jira/browse/HBASE-21460
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: HBASE-21460.v1.patch, HBASE-21460.v2.patch
>
>
> we use the bucket cache(offheap),found the doc was error,
> the property bucket sizes shoul be "hbase.bucketcache.bucket.sizes" instead
> of "hfile.block.cache.sizes"
> CacheConfig.java
> /**
> * A comma-delimited array of values for use as bucket sizes.
> */
> public static final String BUCKET_CACHE_BUCKETS_KEY =
> "hbase.bucketcache.bucket.sizes";
> the doc was:
>
>
> HBASE-10641 introduced the ability to configure multiple sizes for the
> buckets of the BucketCache, in HBase 0.98 and newer. To configurable multiple
> bucket sizes, configure the new property
> {color:#ff}{{hfile.block.cache.sizes}}{color} (instead of{color:#ff}
> {{hfile.block.cache.size}}{color}) to a comma-separated list of block sizes,
> ordered from smallest to largest, with no spaces. The goal is to optimize the
> bucket sizes based on your data access patterns. The following example
> configures buckets of size 4096 and 8192.
> {color:#ff}hfile.block.cache.sizes{color}
> 4096,8192
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21460) correct Document Configurable Bucket Sizes in bucketCache
[
https://issues.apache.org/jira/browse/HBASE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688230#comment-16688230
]
Yechao Chen commented on HBASE-21460:
-
thanks you sir, may be the older author think about the user may be forget the
's',so i keep the "instead of" sinppent too,
Yes ,the actual config name is good enough, so remove the snippet ,and update
the patch v2
> correct Document Configurable Bucket Sizes in bucketCache
> -
>
> Key: HBASE-21460
> URL: https://issues.apache.org/jira/browse/HBASE-21460
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-21460.v1.patch
>
>
> we use the bucket cache(offheap),found the doc was error,
> the property bucket sizes shoul be "hbase.bucketcache.bucket.sizes" instead
> of "hfile.block.cache.sizes"
> CacheConfig.java
> /**
> * A comma-delimited array of values for use as bucket sizes.
> */
> public static final String BUCKET_CACHE_BUCKETS_KEY =
> "hbase.bucketcache.bucket.sizes";
> the doc was:
>
>
> HBASE-10641 introduced the ability to configure multiple sizes for the
> buckets of the BucketCache, in HBase 0.98 and newer. To configurable multiple
> bucket sizes, configure the new property
> {color:#ff}{{hfile.block.cache.sizes}}{color} (instead of{color:#ff}
> {{hfile.block.cache.size}}{color}) to a comma-separated list of block sizes,
> ordered from smallest to largest, with no spaces. The goal is to optimize the
> bucket sizes based on your data access patterns. The following example
> configures buckets of size 4096 and 8192.
> {color:#ff}hfile.block.cache.sizes{color}
> 4096,8192
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21460) correct Document Configurable Bucket Sizes in bucketCache
[
https://issues.apache.org/jira/browse/HBASE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686827#comment-16686827
]
Ted Yu commented on HBASE-21460:
bq. (instead of `hbase.bucketcache.bucket.size`)
I don't see the above property referenced in other part of the online reference.
I think you can remove the above snippet - referencing the actual config name
should be good enough.
> correct Document Configurable Bucket Sizes in bucketCache
> -
>
> Key: HBASE-21460
> URL: https://issues.apache.org/jira/browse/HBASE-21460
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-21460.v1.patch
>
>
> we use the bucket cache(offheap),found the doc was error,
> the property bucket sizes shoul be "hbase.bucketcache.bucket.sizes" instead
> of "hfile.block.cache.sizes"
> CacheConfig.java
> /**
> * A comma-delimited array of values for use as bucket sizes.
> */
> public static final String BUCKET_CACHE_BUCKETS_KEY =
> "hbase.bucketcache.bucket.sizes";
> the doc was:
>
>
> HBASE-10641 introduced the ability to configure multiple sizes for the
> buckets of the BucketCache, in HBase 0.98 and newer. To configurable multiple
> bucket sizes, configure the new property
> {color:#ff}{{hfile.block.cache.sizes}}{color} (instead of{color:#ff}
> {{hfile.block.cache.size}}{color}) to a comma-separated list of block sizes,
> ordered from smallest to largest, with no spaces. The goal is to optimize the
> bucket sizes based on your data access patterns. The following example
> configures buckets of size 4096 and 8192.
> {color:#ff}hfile.block.cache.sizes{color}
> 4096,8192
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21460) correct Document Configurable Bucket Sizes in bucketCache
[
https://issues.apache.org/jira/browse/HBASE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686117#comment-16686117
]
Yechao Chen commented on HBASE-21460:
-
[~te...@apache.org] mind have a look ,thanks.
> correct Document Configurable Bucket Sizes in bucketCache
> -
>
> Key: HBASE-21460
> URL: https://issues.apache.org/jira/browse/HBASE-21460
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-21460.v1.patch
>
>
> we use the bucket cache(offheap),found the doc was error,
> the property bucket sizes shoul be "hbase.bucketcache.bucket.sizes" instead
> of "hfile.block.cache.sizes"
> CacheConfig.java
> /**
> * A comma-delimited array of values for use as bucket sizes.
> */
> public static final String BUCKET_CACHE_BUCKETS_KEY =
> "hbase.bucketcache.bucket.sizes";
> the doc was:
>
>
> HBASE-10641 introduced the ability to configure multiple sizes for the
> buckets of the BucketCache, in HBase 0.98 and newer. To configurable multiple
> bucket sizes, configure the new property
> {color:#ff}{{hfile.block.cache.sizes}}{color} (instead of{color:#ff}
> {{hfile.block.cache.size}}{color}) to a comma-separated list of block sizes,
> ordered from smallest to largest, with no spaces. The goal is to optimize the
> bucket sizes based on your data access patterns. The following example
> configures buckets of size 4096 and 8192.
> {color:#ff}hfile.block.cache.sizes{color}
> 4096,8192
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21460) correct Document Configurable Bucket Sizes in bucketCache
[
https://issues.apache.org/jira/browse/HBASE-21460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681112#comment-16681112
]
Hadoop QA commented on HBASE-21460:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
15s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 5m
50s{color} | {color:blue} branch has no errors when building the reference
guide. See footer for rendered docs, which you should manually inspect. {color}
|
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
2s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:blue}0{color} | {color:blue} refguide {color} | {color:blue} 5m
2s{color} | {color:blue} patch has no errors when building the reference guide.
See footer for rendered docs, which you should manually inspect. {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
14s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 19m 58s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21460 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12947551/HBASE-21460.v1.patch |
| Optional Tests | dupname asflicense refguide |
| uname | Linux e44d515d7477 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / fe2265fa4a |
| maven | version: Apache Maven 3.5.4
(1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z) |
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/15006/artifact/patchprocess/branch-site/book.html
|
| refguide |
https://builds.apache.org/job/PreCommit-HBASE-Build/15006/artifact/patchprocess/patch-site/book.html
|
| Max. process+thread count | 97 (vs. ulimit of 1) |
| modules | C: . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/15006/console |
| Powered by | Apache Yetus 0.8.0 http://yetus.apache.org |
This message was automatically generated.
> correct Document Configurable Bucket Sizes in bucketCache
> -
>
> Key: HBASE-21460
> URL: https://issues.apache.org/jira/browse/HBASE-21460
> Project: HBase
> Issue Type: Improvement
> Components: documentation
>Reporter: Yechao Chen
>Assignee: Yechao Chen
>Priority: Major
> Attachments: HBASE-21460.v1.patch
>
>
> we use the bucket cache(offheap),found the doc was error,
> the property bucket sizes shoul be "hbase.bucketcache.bucket.sizes" instead
> of "hfile.block.cache.sizes"
> CacheConfig.java
> /**
> * A comma-delimited array of values for use as bucket sizes.
> */
> public static final String BUCKET_CACHE_BUCKETS_KEY =
> "hbase.bucketcache.bucket.sizes";
> the doc was:
>
>
> HBASE-10641 introduced the ability to configure multiple sizes for the
> buckets of the BucketCache, in HBase 0.98 and newer. To configurable multiple
> bucket sizes, configure the new property
> {color:#ff}{{hfile.block.cache.sizes}}{color} (instead of{color:#ff}
> {{hfile.block.cache.size}}{color}) to a comma-separated list of block sizes,
> ordered from smallest to largest, with no spaces. The goal is to optimize the
> bucket sizes based on your data access patterns. The following example
> configures buckets of size 4096 and 8192.
> {color:#ff}hfile.block.cache.sizes{color}
> 4096,8192
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
