[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-13 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685280#comment-16685280 ] Hudson commented on HBASE-21463: Results for branch master [build #602 on

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-12 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684670#comment-16684670 ] Guanghao Zhang commented on HBASE-21463: +1 > The checkOnlineRegionsReport can accidentally

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683315#comment-16683315 ] Duo Zhang commented on HBASE-21463: --- OK, all green. If no other objections I will commit to master and

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683303#comment-16683303 ] Hadoop QA commented on HBASE-21463: --- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682897#comment-16682897 ] Hadoop QA commented on HBASE-21463: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682883#comment-16682883 ] Duo Zhang commented on HBASE-21463: --- So I think we can apply this for master and branch-2 first. For

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682878#comment-16682878 ] Allan Yang commented on HBASE-21463: Yes, I just commented out the reportTransition in

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682857#comment-16682857 ] Duo Zhang commented on HBASE-21463: --- So on branch-2.1 and branch-2.0 the AP will schedule the open

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682854#comment-16682854 ] Allan Yang commented on HBASE-21463: I think we need the reportTransition call inside

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682845#comment-16682845 ] Duo Zhang commented on HBASE-21463: --- OK the problem is that, we skip the table state check and

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682843#comment-16682843 ] Duo Zhang commented on HBASE-21463: --- The failed UT is related. Let me dig. > The

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682826#comment-16682826 ] Hadoop QA commented on HBASE-21463: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Allan Yang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682802#comment-16682802 ] Allan Yang commented on HBASE-21463: Great test case! This one should go back to branch-2.0 and

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-11 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682784#comment-16682784 ] Duo Zhang commented on HBASE-21463: --- Review board link: https://reviews.apache.org/r/69314/ > The

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682721#comment-16682721 ] stack commented on HBASE-21463: --- My bad. > The checkOnlineRegionsReport can accidentally complete a TRSP

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682678#comment-16682678 ] Duo Zhang commented on HBASE-21463: --- Yes, only a UT(I have a 'UT' in the patch name...). Will provide

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-10 Thread stack (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682554#comment-16682554 ] stack commented on HBASE-21463: --- Is there a change in the patch? I see making a method visible for

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-10 Thread Guanghao Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682410#comment-16682410 ] Guanghao Zhang commented on HBASE-21463: Great UT. Not easy to find this bug and represent this

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-10 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682388#comment-16682388 ] Duo Zhang commented on HBASE-21463: --- A UT to represent the problem. [~zghaobac] FYI. If no other

[jira] [Commented] (HBASE-21463) The checkOnlineRegionsReport can accidentally complete a TRSP

2018-11-09 Thread Duo Zhang (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-21463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16681523#comment-16681523 ] Duo Zhang commented on HBASE-21463: --- HBASE-21421 is also a problem introduced by this method. So in