[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[
https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687772#comment-16687772
]
Hudson commented on HBASE-21473:
Results for branch branch-1
[build #552 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/552/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/552//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/552//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/552//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 source release artifact{color}
-- See build output for details.
> RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no
> tags
>
>
> Key: HBASE-21473
> URL: https://issues.apache.org/jira/browse/HBASE-21473
> Project: HBase
> Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.0.3, 1.4.9, 2.1.2
>
> Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch,
> HBASE-21473.v1.patch
>
>
> When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1
> always failed [1]. because RowIndexSeekerV1 may return cell with extra two
> \x00\x00 bytes which has no tags..
> I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes
> need more performance evaluation, as [~Apache9] & [~stack] comment. I opened
> issue HBASE-21459 to address it.
> So, let me fix this bug firstly (Also will provide a seperate UT for this).
> 1.
> https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[
https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687519#comment-16687519
]
Hudson commented on HBASE-21473:
Results for branch master
[build #606 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/606/]: (x)
*{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/606//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/606//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/606//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no
> tags
>
>
> Key: HBASE-21473
> URL: https://issues.apache.org/jira/browse/HBASE-21473
> Project: HBase
> Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.0.3, 1.4.9, 2.1.2
>
> Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch,
> HBASE-21473.v1.patch
>
>
> When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1
> always failed [1]. because RowIndexSeekerV1 may return cell with extra two
> \x00\x00 bytes which has no tags..
> I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes
> need more performance evaluation, as [~Apache9] & [~stack] comment. I opened
> issue HBASE-21459 to address it.
> So, let me fix this bug firstly (Also will provide a seperate UT for this).
> 1.
> https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[
https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687483#comment-16687483
]
Hudson commented on HBASE-21473:
Results for branch branch-2.0
[build #1085 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1085/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1085//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1085//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1085//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no
> tags
>
>
> Key: HBASE-21473
> URL: https://issues.apache.org/jira/browse/HBASE-21473
> Project: HBase
> Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.0.3, 1.4.9, 2.1.2
>
> Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch,
> HBASE-21473.v1.patch
>
>
> When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1
> always failed [1]. because RowIndexSeekerV1 may return cell with extra two
> \x00\x00 bytes which has no tags..
> I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes
> need more performance evaluation, as [~Apache9] & [~stack] comment. I opened
> issue HBASE-21459 to address it.
> So, let me fix this bug firstly (Also will provide a seperate UT for this).
> 1.
> https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[
https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687466#comment-16687466
]
Hudson commented on HBASE-21473:
Results for branch branch-2.1
[build #607 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/607/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/607//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/607//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/607//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no
> tags
>
>
> Key: HBASE-21473
> URL: https://issues.apache.org/jira/browse/HBASE-21473
> Project: HBase
> Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.0.3, 1.4.9, 2.1.2
>
> Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch,
> HBASE-21473.v1.patch
>
>
> When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1
> always failed [1]. because RowIndexSeekerV1 may return cell with extra two
> \x00\x00 bytes which has no tags..
> I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes
> need more performance evaluation, as [~Apache9] & [~stack] comment. I opened
> issue HBASE-21459 to address it.
> So, let me fix this bug firstly (Also will provide a seperate UT for this).
> 1.
> https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[
https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687310#comment-16687310
]
Hudson commented on HBASE-21473:
Results for branch branch-2
[build #1503 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1503/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1503//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1503//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/1503//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no
> tags
>
>
> Key: HBASE-21473
> URL: https://issues.apache.org/jira/browse/HBASE-21473
> Project: HBase
> Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.0.3, 1.4.9, 2.1.2
>
> Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch,
> HBASE-21473.v1.patch
>
>
> When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1
> always failed [1]. because RowIndexSeekerV1 may return cell with extra two
> \x00\x00 bytes which has no tags..
> I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes
> need more performance evaluation, as [~Apache9] & [~stack] comment. I opened
> issue HBASE-21459 to address it.
> So, let me fix this bug firstly (Also will provide a seperate UT for this).
> 1.
> https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[
https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687052#comment-16687052
]
Hudson commented on HBASE-21473:
Results for branch branch-1.4
[build #548 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/548/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/548//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk7 checks{color}
-- For more information [see jdk7
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/548//JDK7_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1.4/548//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no
> tags
>
>
> Key: HBASE-21473
> URL: https://issues.apache.org/jira/browse/HBASE-21473
> Project: HBase
> Issue Type: Sub-task
>Reporter: Zheng Hu
>Assignee: Zheng Hu
>Priority: Major
> Fix For: 3.0.0, 1.5.0, 2.2.0, 2.0.3, 1.4.9, 2.1.2
>
> Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch,
> HBASE-21473.v1.patch
>
>
> When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1
> always failed [1]. because RowIndexSeekerV1 may return cell with extra two
> \x00\x00 bytes which has no tags..
> I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes
> need more performance evaluation, as [~Apache9] & [~stack] comment. I opened
> issue HBASE-21459 to address it.
> So, let me fix this bug firstly (Also will provide a seperate UT for this).
> 1.
> https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[ https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686713#comment-16686713 ] Zheng Hu commented on HBASE-21473: -- Pushed to branch-2.x & branch-1 & branch-1.4, Thanks all for reviewing. > RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no > tags > > > Key: HBASE-21473 > URL: https://issues.apache.org/jira/browse/HBASE-21473 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Fix For: 3.0.0, 1.5.0, 2.2.0, 2.0.3, 1.4.9, 2.1.2 > > Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch, > HBASE-21473.v1.patch > > > When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1 > always failed [1]. because RowIndexSeekerV1 may return cell with extra two > \x00\x00 bytes which has no tags.. > I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes > need more performance evaluation, as [~Apache9] & [~stack] comment. I opened > issue HBASE-21459 to address it. > So, let me fix this bug firstly (Also will provide a seperate UT for this). > 1. > https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[ https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686608#comment-16686608 ] Zheng Hu commented on HBASE-21473: -- bq. Why the test failures? Because they depend on old format? Failed UT is not related to the old format, we can see the latest Hadoop QA. bq. If tag length == 0, we don't add the tag length short? That's right. Thanks [~stack] > RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no > tags > > > Key: HBASE-21473 > URL: https://issues.apache.org/jira/browse/HBASE-21473 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch, > HBASE-21473.v1.patch > > > When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1 > always failed [1]. because RowIndexSeekerV1 may return cell with extra two > \x00\x00 bytes which has no tags.. > I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes > need more performance evaluation, as [~Apache9] & [~stack] comment. I opened > issue HBASE-21459 to address it. > So, let me fix this bug firstly (Also will provide a seperate UT for this). > 1. > https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[
https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685634#comment-16685634
]
Hadoop QA commented on HBASE-21473:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
11s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
13s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
16s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
23s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
2s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
27s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
58s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
47s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
50s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
29s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}147m 13s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
50s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}191m 52s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | hadoop.hbase.client.TestBlockEvictionFromClient |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hbase:b002b0b |
| JIRA Issue | HBASE-21473 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12947993/HBASE-21473.v1.patch |
| Optional Tests | dupname asflicense javac javadoc unit findbugs
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux cb87b260362d 3.13.0-143-generic #192-Ubuntu SMP Tue Feb 27
10:45:36 UTC 2018 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 00acda3c58 |
| maven | version: Apache Maven 3.5.4
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[ https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685420#comment-16685420 ] stack commented on HBASE-21473: --- Retry > RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no > tags > > > Key: HBASE-21473 > URL: https://issues.apache.org/jira/browse/HBASE-21473 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch, > HBASE-21473.v1.patch > > > When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1 > always failed [1]. because RowIndexSeekerV1 may return cell with extra two > \x00\x00 bytes which has no tags.. > I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes > need more performance evaluation, as [~Apache9] & [~stack] comment. I opened > issue HBASE-21459 to address it. > So, let me fix this bug firstly (Also will provide a seperate UT for this). > 1. > https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[ https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685418#comment-16685418 ] stack commented on HBASE-21473: --- Why the test failures? Because they depend on old format? If tag length == 0, we don't add the tag length short? Thanks for working on this. > RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no > tags > > > Key: HBASE-21473 > URL: https://issues.apache.org/jira/browse/HBASE-21473 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch > > > When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1 > always failed [1]. because RowIndexSeekerV1 may return cell with extra two > \x00\x00 bytes which has no tags.. > I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes > need more performance evaluation, as [~Apache9] & [~stack] comment. I opened > issue HBASE-21459 to address it. > So, let me fix this bug firstly (Also will provide a seperate UT for this). > 1. > https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[
https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685331#comment-16685331
]
Hadoop QA commented on HBASE-21473:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
10s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
22s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
19s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
14s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
33s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
0s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
26s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
14s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
33s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m
58s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
8m 50s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
26s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}214m 29s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
54s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}259m 14s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash |
| | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.client.TestRestoreSnapshotFromClientClone |
| | hadoop.hbase.regionserver.wal.TestAsyncWALReplay |
| |
hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService |
| | hadoop.hbase.security.access.TestRpcAccessChecks |
| | hadoop.hbase.master.procedure.TestProcedurePriority |
| | hadoop.hbase.regionserver.TestRegionReplicasAreDistributed |
| | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation |
| | hadoop.hbase.replication.TestReplicationDroppedTables |
| |
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[ https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685075#comment-16685075 ] Anoop Sam John commented on HBASE-21473: +1 > RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no > tags > > > Key: HBASE-21473 > URL: https://issues.apache.org/jira/browse/HBASE-21473 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch > > > When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1 > always failed [1]. because RowIndexSeekerV1 may return cell with extra two > \x00\x00 bytes which has no tags.. > I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes > need more performance evaluation, as [~Apache9] & [~stack] comment. I opened > issue HBASE-21459 to address it. > So, let me fix this bug firstly (Also will provide a seperate UT for this). > 1. > https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[ https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685001#comment-16685001 ] Zheng Hu commented on HBASE-21473: -- Retry... > RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no > tags > > > Key: HBASE-21473 > URL: https://issues.apache.org/jira/browse/HBASE-21473 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: HBASE-21473.v1.patch, HBASE-21473.v1.patch > > > When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1 > always failed [1]. because RowIndexSeekerV1 may return cell with extra two > \x00\x00 bytes which has no tags.. > I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes > need more performance evaluation, as [~Apache9] & [~stack] comment. I opened > issue HBASE-21459 to address it. > So, let me fix this bug firstly (Also will provide a seperate UT for this). > 1. > https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[
https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684973#comment-16684973
]
Hadoop QA commented on HBASE-21473:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
13s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
26s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
25s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
38s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
41s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
4s{color} | {color:green} branch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
56s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
15s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
20s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m
10s{color} | {color:green} patch has no errors when building our shaded
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
9m 2s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.4
or 3.0.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m
45s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
47s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m
25s{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red}181m 24s{color}
| {color:red} hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
50s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}227m 33s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests |
hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash |
| | hadoop.hbase.client.TestRestoreSnapshotFromClientSchemaChange |
| | hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas |
| | hadoop.hbase.client.TestRestoreSnapshotFromClientClone |
| | hadoop.hbase.regionserver.wal.TestAsyncWALReplay |
| |
hadoop.hbase.security.visibility.TestVisibilityLabelsWithCustomVisLabService |
| | hadoop.hbase.master.procedure.TestProcedurePriority |
| |
hadoop.hbase.replication.TestSyncReplicationMoreLogsInLocalGiveUpSplitting |
| | hadoop.hbase.regionserver.TestRegionReplicasAreDistributed |
| | hadoop.hbase.regionserver.wal.TestWALReplayBoundedLogWriterCreation |
| | hadoop.hbase.regionserver.TestRegionReplicaFailover |
| |
[jira] [Commented] (HBASE-21473) RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no tags
[ https://issues.apache.org/jira/browse/HBASE-21473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684719#comment-16684719 ] Zheng Hu commented on HBASE-21473: -- [~Apache9], FYI > RowIndexSeekerV1 may return cell with extra two \x00\x00 bytes which has no > tags > > > Key: HBASE-21473 > URL: https://issues.apache.org/jira/browse/HBASE-21473 > Project: HBase > Issue Type: Sub-task >Reporter: Zheng Hu >Assignee: Zheng Hu >Priority: Major > Attachments: HBASE-21473.v1.patch > > > When testing HBASE-21401, we found that two UT related to RowIndexSeekerV1 > always failed [1]. because RowIndexSeekerV1 may return cell with extra two > \x00\x00 bytes which has no tags.. > I plan to fix this bug in HBASE-21401, but seems the checkKeyValueBytes > need more performance evaluation, as [~Apache9] & [~stack] comment. I opened > issue HBASE-21459 to address it. > So, let me fix this bug firstly (Also will provide a seperate UT for this). > 1. > https://issues.apache.org/jira/browse/HBASE-21401?focusedCommentId=1671=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-1671 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
