[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904315#comment-16904315 ] Hudson commented on HBASE-22777: Results for branch branch-2.0 [build #1848 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1848/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1848//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1848//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.0/1848//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22777.branch-2.0.001.patch, > HBASE-22777.branch-2.0.002.patch, HBASE-22777.branch-2.1.001.patch, > HBASE-22777.branch-2.1.002.patch, HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch, HBASE-22777.master.003.patch, > HBASE-22777.master.004.patch, HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904242#comment-16904242 ] stack commented on HBASE-22777: --- HBASE-22827 is about exposing multi-merge in Admin and Shell. Currently only available internally. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.0.6, 2.2.1, 2.1.6 > > Attachments: HBASE-22777.branch-2.0.001.patch, > HBASE-22777.branch-2.0.002.patch, HBASE-22777.branch-2.1.001.patch, > HBASE-22777.branch-2.1.002.patch, HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch, HBASE-22777.master.003.patch, > HBASE-22777.master.004.patch, HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904224#comment-16904224 ] stack commented on HBASE-22777: --- Pushed on branch-2.0 (the test failures pass locally). > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22777.branch-2.0.001.patch, > HBASE-22777.branch-2.0.002.patch, HBASE-22777.branch-2.1.001.patch, > HBASE-22777.branch-2.1.002.patch, HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch, HBASE-22777.master.003.patch, > HBASE-22777.master.004.patch, HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904217#comment-16904217 ] HBase QA commented on HBASE-22777: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 41s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 6 new or modified test files. {color} | || || || || {color:brown} branch-2.0 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 30s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 19s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 19s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 35s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 6s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 34s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 39s{color} | {color:green} branch-2.0 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 44s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} The patch passed checkstyle in hbase-common {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 33s{color} | {color:green} hbase-client: The patch generated 0 new + 75 unchanged - 46 fixed = 75 total (was 121) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 15s{color} | {color:red} hbase-server: The patch generated 3 new + 475 unchanged - 16 fixed = 478 total (was 491) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 16s{color} | {color:green} The patch passed checkstyle in hbase-rest {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 4s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 15m 2s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.7 2.8.5 or 3.0.3 3.1.2. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 40s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 48s{color} | {color:green} hbase-common in the patch passed. {color} | |
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904038#comment-16904038 ] stack commented on HBASE-22777: --- 2.0.002 fix checkstyle. Findbugs found a problem w/ the backport responsible for test failures. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22777.branch-2.0.001.patch, > HBASE-22777.branch-2.0.002.patch, HBASE-22777.branch-2.1.001.patch, > HBASE-22777.branch-2.1.002.patch, HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch, HBASE-22777.master.003.patch, > HBASE-22777.master.004.patch, HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903609#comment-16903609 ] HBase QA commented on HBASE-22777: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 37s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 6 new or modified test files. {color} | || || || || {color:brown} branch-2.0 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 44s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 50s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 13s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 57s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m 38s{color} | {color:green} branch-2.0 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 51s{color} | {color:green} branch-2.0 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 48s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 39s{color} | {color:red} hbase-client: The patch generated 2 new + 75 unchanged - 46 fixed = 77 total (was 121) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 32s{color} | {color:red} hbase-server: The patch generated 5 new + 475 unchanged - 16 fixed = 480 total (was 491) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 51s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 17m 41s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.5 2.7.7 2.8.5 or 3.0.3 3.1.2. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m 28s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 18s{color} | {color:red} hbase-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 38s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 52s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 17s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}194m 1s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m 12s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green}
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903549#comment-16903549 ] Hudson commented on HBASE-22777: Results for branch branch-2.1 [build #1465 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1465/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1465//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1465//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.1/1465//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22777.branch-2.0.001.patch, > HBASE-22777.branch-2.1.001.patch, HBASE-22777.branch-2.1.002.patch, > HBASE-22777.master.001.patch, HBASE-22777.master.002.patch, > HBASE-22777.master.003.patch, HBASE-22777.master.004.patch, > HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903493#comment-16903493 ] stack commented on HBASE-22777: --- 2.0.001 is backport to branch-2.0. Required changes. Make sure they good > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1, 2.1.6 > > Attachments: HBASE-22777.branch-2.0.001.patch, > HBASE-22777.branch-2.1.001.patch, HBASE-22777.branch-2.1.002.patch, > HBASE-22777.master.001.patch, HBASE-22777.master.002.patch, > HBASE-22777.master.003.patch, HBASE-22777.master.004.patch, > HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903345#comment-16903345 ] HBase QA commented on HBASE-22777: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 40s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 6 new or modified test files. {color} | || || || || {color:brown} branch-2.1 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 56s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 30s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 42s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 55s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 38s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s{color} | {color:green} branch-2.1 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 8s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 20s{color} | {color:green} The patch passed checkstyle in hbase-common {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 29s{color} | {color:green} hbase-client: The patch generated 0 new + 76 unchanged - 47 fixed = 76 total (was 123) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 5s{color} | {color:red} hbase-server: The patch generated 2 new + 470 unchanged - 17 fixed = 472 total (was 487) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} The patch passed checkstyle in hbase-rest {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 1s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 41s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 18m 31s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 38s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 14s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} |
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903146#comment-16903146 ] stack commented on HBASE-22777: --- 2.1.0002 fixes checkstyle. Test passes locally. Retry. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22777.branch-2.1.001.patch, > HBASE-22777.branch-2.1.002.patch, HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch, HBASE-22777.master.003.patch, > HBASE-22777.master.004.patch, HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903118#comment-16903118 ] Hudson commented on HBASE-22777: Results for branch master [build #1318 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1318/]: (x) *{color:red}-1 overall{color}* details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1318//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1298//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1298//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22777.branch-2.1.001.patch, > HBASE-22777.master.001.patch, HBASE-22777.master.002.patch, > HBASE-22777.master.003.patch, HBASE-22777.master.004.patch, > HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16903014#comment-16903014 ] Hudson commented on HBASE-22777: Results for branch branch-2.2 [build #500 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/500/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/500//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/500//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/500//JDK8_Nightly_Build_Report_(Hadoop3)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. (x) {color:red}-1 client integration test{color} -- Something went wrong with this stage, [check relevant console output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/500//console]. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22777.branch-2.1.001.patch, > HBASE-22777.master.001.patch, HBASE-22777.master.002.patch, > HBASE-22777.master.003.patch, HBASE-22777.master.004.patch, > HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902983#comment-16902983 ] Hudson commented on HBASE-22777: Results for branch branch-2 [build #2152 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2152/]: (x) *{color:red}-1 overall{color}* details (if available): (x) {color:red}-1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2152//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2152//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2152//JDK8_Nightly_Build_Report_(Hadoop3)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. (x) {color:red}-1 client integration test{color} -- Something went wrong with this stage, [check relevant console output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2152//console]. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22777.branch-2.1.001.patch, > HBASE-22777.master.001.patch, HBASE-22777.master.002.patch, > HBASE-22777.master.003.patch, HBASE-22777.master.004.patch, > HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902904#comment-16902904 ] HBase QA commented on HBASE-22777: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 2s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 6 new or modified test files. {color} | || || || || {color:brown} branch-2.1 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 29s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m 12s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 0s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 30s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 3m 51s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 6m 46s{color} | {color:green} branch-2.1 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 31s{color} | {color:green} branch-2.1 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 19s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 32s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 32s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 32s{color} | {color:red} hbase-client: The patch generated 3 new + 76 unchanged - 47 fixed = 79 total (was 123) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 15s{color} | {color:red} hbase-server: The patch generated 4 new + 470 unchanged - 17 fixed = 474 total (was 487) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 7s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 20m 21s{color} | {color:green} Patch does not cause any errors with Hadoop 2.7.7 2.8.5 or 3.0.3 3.1.2. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m 13s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 29s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 32s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 38s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 12s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}214m 3s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 7m 36s{color} | {color:green} hbase-rest in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 48s{color} |
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902699#comment-16902699 ] stack commented on HBASE-22777: --- Committed to branch-2.2+. Put up 2.1.001 for backport to branch-2.1. It needs work. Lets see what it breaks. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Fix For: 3.0.0, 2.3.0, 2.2.1 > > Attachments: HBASE-22777.branch-2.1.001.patch, > HBASE-22777.master.001.patch, HBASE-22777.master.002.patch, > HBASE-22777.master.003.patch, HBASE-22777.master.004.patch, > HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902487#comment-16902487 ] HBase QA commented on HBASE-22777: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 2m 31s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 6 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 38s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 34s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 36s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 42s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 10m 17s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 6s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 2s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 10s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 28s{color} | {color:green} The patch passed checkstyle in hbase-common {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 32s{color} | {color:green} hbase-client: The patch generated 0 new + 71 unchanged - 52 fixed = 71 total (was 123) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 27s{color} | {color:red} hbase-server: The patch generated 1 new + 415 unchanged - 16 fixed = 416 total (was 431) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} The patch passed checkstyle in hbase-rest {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 52s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 16m 44s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 36s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 40s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 53s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} |
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902319#comment-16902319 ] stack commented on HBASE-22777: --- Thank you for review [~an...@apache.org] Let me see how the .005 run does. Will push if comes back reasonable. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch, HBASE-22777.master.003.patch, > HBASE-22777.master.004.patch, HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902257#comment-16902257 ] Ankit Singhal commented on HBASE-22777: --- Bot reported below failures for .004 passes for me when run locally. so no issues here. {code} [ERROR] Failures: [ERROR] TestReplicationEndpointWithMultipleWAL>TestReplicationEndpoint.testInterClusterReplication:235 Waiting timed out after [30,000] msec Failed to replicate all edits, expected = 2500 replicated = 2499 [ERROR] Errors: [ERROR] TestReplicationSyncUpTool.testSyncUpTool » RetriesExhausted Failed after attem... [WARNING] Flakes: [WARNING] org.apache.hadoop.hbase.util.TestRegionMover.testLoadMetaRegion(org.apache.hadoop.hbase.util.TestRegionMover) [ERROR] Run 1: TestRegionMover.testLoadMetaRegion:210 expected:<4> but was:<3> {code} Code looks good to me (+1) and tests are great. Thanks for working on this. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch, HBASE-22777.master.003.patch, > HBASE-22777.master.004.patch, HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16902158#comment-16902158 ] stack commented on HBASE-22777: --- .005 has a one line change trying to fix crazy checkstyle report. Other checkstyle complaint is an import order error but the order is correct. Otherwise, no change. The failed tests are failures to complete the xml... > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch, HBASE-22777.master.003.patch, > HBASE-22777.master.004.patch, HBASE-22777.master.005.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901967#comment-16901967 ] HBase QA commented on HBASE-22777: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 21s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 6 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 38s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 48s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 10s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 9m 30s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 43s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 57s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 9s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 27s{color} | {color:green} The patch passed checkstyle in hbase-common {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 34s{color} | {color:green} hbase-client: The patch generated 0 new + 71 unchanged - 52 fixed = 71 total (was 123) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 29s{color} | {color:red} hbase-server: The patch generated 3 new + 424 unchanged - 7 fixed = 427 total (was 431) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 17s{color} | {color:green} The patch passed checkstyle in hbase-rest {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 5m 0s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 18m 17s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 3m 7s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 12m 16s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 12s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 48s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 17s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} |
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901692#comment-16901692 ] stack commented on HBASE-22777: --- .004 fixes checkstyle. Can't make the tests fail locally though. Looking for +1 so can commit. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch, HBASE-22777.master.003.patch, > HBASE-22777.master.004.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901615#comment-16901615 ] HBase QA commented on HBASE-22777: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 3m 26s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 6 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 35s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 25s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 37s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 44s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 36s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 11s{color} | {color:green} The patch passed checkstyle in hbase-protocol-shaded {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} The patch passed checkstyle in hbase-common {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 30s{color} | {color:green} hbase-client: The patch generated 0 new + 71 unchanged - 52 fixed = 71 total (was 123) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 15s{color} | {color:red} hbase-server: The patch generated 5 new + 424 unchanged - 7 fixed = 429 total (was 431) {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 15s{color} | {color:green} The patch passed checkstyle in hbase-rest {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 29s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 15m 30s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 34s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 33s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 54s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} |
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16901396#comment-16901396 ] stack commented on HBASE-22777: --- .003 fix tests, checkstyle, etc. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch, HBASE-22777.master.003.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900607#comment-16900607 ] HBase QA commented on HBASE-22777: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 59s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 6 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 39s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 22s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 42s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 45s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 8m 43s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 43s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 17s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 12s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 2m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 39s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 30s{color} | {color:red} hbase-client: The patch generated 12 new + 71 unchanged - 52 fixed = 83 total (was 123) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 13s{color} | {color:red} hbase-server: The patch generated 24 new + 426 unchanged - 5 fixed = 450 total (was 431) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 14s{color} | {color:red} hbase-rest: The patch generated 1 new + 3 unchanged - 0 fixed = 4 total (was 3) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 47s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 17m 28s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m 11s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 21s{color} | {color:red} hbase-client generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 34s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 32s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m 11s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 43s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}255m 29s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} |
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900436#comment-16900436 ] stack commented on HBASE-22777: --- .002 address reviews and fix tests. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch, > HBASE-22777.master.002.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900288#comment-16900288 ] stack commented on HBASE-22777: --- Thanks for the fix [~an...@apache.org] > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16899809#comment-16899809 ] Ankit Singhal commented on HBASE-22777: --- bq. my test is failing. Need to figure why (I ask to merge 5 but it is doing 2 still...). Let me see what else I've broke. Just skimmed the patch and I think , it may be because of this typo, shouldn't it be highestEndKey instead of lowestStartKey. {code} + if (highestEndKey == null) { +highestEndKey = ri.getEndKey(); + } else if (ri.isLast() || Bytes.compareTo(ri.getEndKey(), lowestStartKey) > 0) { +highestEndKey = ri.getEndKey(); + } {code} Will also give it a try to test this patch tomorrow and share my feedback. > Add a multi-region merge (for fixing overlaps, etc.) > > > Key: HBASE-22777 > URL: https://issues.apache.org/jira/browse/HBASE-22777 > Project: HBase > Issue Type: Sub-task > Components: hbck2, proc-v2 >Reporter: stack >Assignee: stack >Priority: Major > Attachments: HBASE-22777.master.001.patch > > > MergeTableRegionProcedure does two regions at a time only. We have hardcoded > notion that merge has an 'A' and 'B' parent. > This issue is about making it so we merge N regions all in the one go. We > need this facility generally; will simplify operator's life being able to > merge up in one go rather than in steps of two. In particular, would make > fixing overlaps easier if could just merge all regions in the overlapping > area. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (HBASE-22777) Add a multi-region merge (for fixing overlaps, etc.)
[ https://issues.apache.org/jira/browse/HBASE-22777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16898873#comment-16898873 ] HBase QA commented on HBASE-22777: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 4s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 3 new or modified test files. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 44s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 3s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 2m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 33s{color} | {color:green} branch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 7m 10s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 14s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 50s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} cc {color} | {color:green} 1m 59s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 59s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 27s{color} | {color:red} hbase-client: The patch generated 3 new + 121 unchanged - 2 fixed = 124 total (was 123) {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m 11s{color} | {color:red} hbase-server: The patch generated 20 new + 151 unchanged - 3 fixed = 171 total (was 154) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} shadedjars {color} | {color:green} 4m 22s{color} | {color:green} patch has no errors when building our shaded downstream artifacts. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 14m 45s{color} | {color:green} Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. {color} | | {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 1m 47s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 35s{color} | {color:red} hbase-server generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 31s{color} | {color:green} hbase-protocol-shaded in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 41s{color} | {color:green} hbase-common in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 32s{color} | {color:green} hbase-client in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red}301m 7s{color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} |