[jira] [Commented] (HBASE-23159) HStore#getStorefilesSize may throw NPE

2019-10-13 Thread Lijin Bin (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950700#comment-16950700
 ] 

Lijin Bin commented on HBASE-23159:
---

@[~vjasani] Thanks very much.
And [~stack]  thanks very much for the review.

> HStore#getStorefilesSize may throw NPE
> --
>
> Key: HBASE-23159
> URL: https://issues.apache.org/jira/browse/HBASE-23159
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 2.2.1
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-23159-master-v1.patch
>
>
> HStore#getStorefilesSize test the f.getReader() and use f.getReader() in two 
> different loop and there may be changed between them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23159) HStore#getStorefilesSize may throw NPE

2019-10-13 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950625#comment-16950625
 ] 

Hudson commented on HBASE-23159:


Results for branch branch-2
[build #2322 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2322/]: 
(x) *{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2322//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2322//JDK8_Nightly_Build_Report_(Hadoop2)/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2322//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> HStore#getStorefilesSize may throw NPE
> --
>
> Key: HBASE-23159
> URL: https://issues.apache.org/jira/browse/HBASE-23159
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 2.2.1
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-23159-master-v1.patch
>
>
> HStore#getStorefilesSize test the f.getReader() and use f.getReader() in two 
> different loop and there may be changed between them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23159) HStore#getStorefilesSize may throw NPE

2019-10-13 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950319#comment-16950319
 ] 

Hudson commented on HBASE-23159:


Results for branch master
[build #1504 on 
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1504/]: (x) 
*{color:red}-1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1504//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1504//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1504//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> HStore#getStorefilesSize may throw NPE
> --
>
> Key: HBASE-23159
> URL: https://issues.apache.org/jira/browse/HBASE-23159
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 2.2.1
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-23159-master-v1.patch
>
>
> HStore#getStorefilesSize test the f.getReader() and use f.getReader() in two 
> different loop and there may be changed between them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23159) HStore#getStorefilesSize may throw NPE

2019-10-13 Thread Duo Zhang (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950243#comment-16950243
 ] 

Duo Zhang commented on HBASE-23159:
---

Maybe we could just use for loop to do this, which will be simpler...

> HStore#getStorefilesSize may throw NPE
> --
>
> Key: HBASE-23159
> URL: https://issues.apache.org/jira/browse/HBASE-23159
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 2.2.1
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Fix For: 3.0.0, 2.3.0
>
> Attachments: HBASE-23159-master-v1.patch
>
>
> HStore#getStorefilesSize test the f.getReader() and use f.getReader() in two 
> different loop and there may be changed between them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23159) HStore#getStorefilesSize may throw NPE

2019-10-12 Thread HBase QA (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950151#comment-16950151
 ] 

HBase QA commented on HBASE-23159:
--

| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
35s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green}  0m  
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green}  0m  
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:orange}-0{color} | {color:orange} test4tests {color} | {color:orange}  
0m  0s{color} | {color:orange} The patch doesn't appear to include any new or 
modified tests. Please justify why no new tests are needed for this patch. Also 
please list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  5m 
 2s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
51s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
18s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
33s{color} | {color:green} branch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
35s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue}  3m 
59s{color} | {color:blue} Used deprecated FindBugs config; considering 
switching to SpotBugs. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  3m 
57s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  4m 
54s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
53s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
16s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedjars {color} | {color:green}  4m 
32s{color} | {color:green} patch has no errors when building our shaded 
downstream artifacts. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 
15m 27s{color} | {color:green} Patch does not cause any errors with Hadoop 
2.8.5 2.9.2 or 3.1.2. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
34s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  4m 
14s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}163m 
42s{color} | {color:green} hbase-server in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
28s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}218m 25s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=19.03.3 Server=19.03.3 base: 
https://builds.apache.org/job/PreCommit-HBASE-Build/950/artifact/patchprocess/Dockerfile
 |
| JIRA Issue | HBASE-23159 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12982846/HBASE-23159-master-v1.patch
 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs 
shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux ac28a1e8d91e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 065993294f |
| Default Java | 1.8.0_181 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-HBASE-Build/95

[jira] [Commented] (HBASE-23159) HStore#getStorefilesSize may throw NPE

2019-10-12 Thread Viraj Jasani (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950118#comment-16950118
 ] 

Viraj Jasani commented on HBASE-23159:
--

[~binlijin] We should click on "Submit Patch" to trigger full build with 
submitted patch. I just did it for the attached patch.

Thanks for the patch.

> HStore#getStorefilesSize may throw NPE
> --
>
> Key: HBASE-23159
> URL: https://issues.apache.org/jira/browse/HBASE-23159
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 2.2.1
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Attachments: HBASE-23159-master-v1.patch
>
>
> HStore#getStorefilesSize test the f.getReader() and use f.getReader() in two 
> different loop and there may be changed between them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-23159) HStore#getStorefilesSize may throw NPE

2019-10-12 Thread Michael Stack (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-23159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16950084#comment-16950084
 ] 

Michael Stack commented on HBASE-23159:
---

+1

> HStore#getStorefilesSize may throw NPE
> --
>
> Key: HBASE-23159
> URL: https://issues.apache.org/jira/browse/HBASE-23159
> Project: HBase
>  Issue Type: Bug
>  Components: regionserver
>Affects Versions: 2.2.1
>Reporter: Lijin Bin
>Assignee: Lijin Bin
>Priority: Major
> Attachments: HBASE-23159-master-v1.patch
>
>
> HStore#getStorefilesSize test the f.getReader() and use f.getReader() in two 
> different loop and there may be changed between them.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)