[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2013-08-02 Thread asha koshti (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727590#comment-13727590
 ] 

asha koshti commented on HBASE-5821:


Even i am facing the issue in using coprocessor for doing sum.

AggregationClient aClient = new AggregationClient(conf);
final ColumnInterpreterLong, Long ci = new LongColumnInterpreter();
Scan scan = new Scan();
scan.addColumn(Bytes.toBytes(info),Bytes.toBytes(hits));
long sum = aClient.sum(Bytes.toBytes(demo), ci, scan);

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: Coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-23 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13259519#comment-13259519
 ] 

Hudson commented on HBASE-5821:
---

Integrated in HBase-0.92-security #105 (See 
[https://builds.apache.org/job/HBase-0.92-security/105/])
HBASE-5821  Incorrect handling of null value in Coprocessor aggregation 
function min() (Maryann Xue) (Revision 1328025)

 Result = FAILURE
tedyu : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java


 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-19 Thread Himanshu Vashishtha (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257280#comment-13257280
 ] 

Himanshu Vashishtha commented on HBASE-5821:


Yes, I meant LongColumnInterpreter. There is a minor nit.

As per the existing code, max is correct (it will not override the value with 
an incoming null result); but min is buggy. Maryann said that too.

I think we should have a uniform check at both the places (Client and Protocol) 
ie. in client we are checking :
{code}
max = ci.compare(max, result)  0 ? result : max;
{code}
and in Protocol we are checking:
{code}
  max = (max == null || ci.compare(temp, max)  0) ? temp : max;
{code}

The ordering of arguments in the compare method is not same.

That was also why I said that its good to have these sort of check at single 
place (and Column interpreter implementations are good candidate for that as 
they can define their own way to handle them. They just have to follow the 
Interface contract.).

Anyway, if we go with the existing one, I think we should use the same order 
just to avoid any confusion. 
I know its a minor nit, but it would be good to have a more consistent code?

Thanks for looking into this.

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-19 Thread Maryann Xue (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257307#comment-13257307
 ] 

Maryann Xue commented on HBASE-5821:


Himanshu, it seems impossible to solve this problem through ColumnInterpreter. 
the semantics of min() and max() here is to discard null value whenever a 
non-null value appears; while the compare() is put the null value at a definite 
end -- either the lowest or the highest. Currently, null is treated as the 
smallest value, so this works for max(), but for min(), null would be the 
minimum value instead of being discarded.

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-19 Thread Himanshu Vashishtha (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257542#comment-13257542
 ] 

Himanshu Vashishtha commented on HBASE-5821:


I see your point about different use cases. 
With the current patch we are invoking the comparator method only when both 
arguments are non-null. 
Anyway, its working correctly now, I am good :)
Thanks for correcting it Maryann.

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-19 Thread Zhihong Yu (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257578#comment-13257578
 ] 

Zhihong Yu commented on HBASE-5821:
---

Integrated to 0.92, 0.94 and trunk.

Thanks for the patch, Maryann.

Thanks for the review Himanshu.

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-19 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257631#comment-13257631
 ] 

Hudson commented on HBASE-5821:
---

Integrated in HBase-TRUNK #2786 (See 
[https://builds.apache.org/job/HBase-TRUNK/2786/])
HBASE-5821  Incorrect handling of null value in Coprocessor aggregation 
function min() (Maryann Xue) (Revision 1328030)

 Result = FAILURE
tedyu : 
Files : 
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java


 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-19 Thread Hadoop QA (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257635#comment-13257635
 ] 

Hadoop QA commented on HBASE-5821:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523202/HBASE-5821.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1577//console

This message is automatically generated.

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-19 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257660#comment-13257660
 ] 

Hudson commented on HBASE-5821:
---

Integrated in HBase-0.94 #133 (See 
[https://builds.apache.org/job/HBase-0.94/133/])
HBASE-5821  Incorrect handling of null value in Coprocessor aggregation 
function min() (Maryann Xue) (Revision 1328027)

 Result = FAILURE
tedyu : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java


 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-19 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257706#comment-13257706
 ] 

Hudson commented on HBASE-5821:
---

Integrated in HBase-0.92 #378 (See 
[https://builds.apache.org/job/HBase-0.92/378/])
HBASE-5821  Incorrect handling of null value in Coprocessor aggregation 
function min() (Maryann Xue) (Revision 1328025)

 Result = FAILURE
tedyu : 
Files : 
* /hbase/branches/0.92/CHANGES.txt
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
* 
/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java


 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-19 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257715#comment-13257715
 ] 

Hudson commented on HBASE-5821:
---

Integrated in HBase-0.94-security #17 (See 
[https://builds.apache.org/job/HBase-0.94-security/17/])
HBASE-5821  Incorrect handling of null value in Coprocessor aggregation 
function min() (Maryann Xue) (Revision 1328027)

 Result = FAILURE
tedyu : 
Files : 
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
* 
/hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java


 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-19 Thread Hudson (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13258026#comment-13258026
 ] 

Hudson commented on HBASE-5821:
---

Integrated in HBase-TRUNK-security #176 (See 
[https://builds.apache.org/job/HBase-TRUNK-security/176/])
HBASE-5821  Incorrect handling of null value in Coprocessor aggregation 
function min() (Maryann Xue) (Revision 1328030)

 Result = FAILURE
tedyu : 
Files : 
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/coprocessor/AggregationClient.java
* 
/hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/AggregateImplementation.java


 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Fix For: 0.92.2, 0.96.0, 0.94.1

 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-18 Thread Hadoop QA (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256651#comment-13256651
 ] 

Hadoop QA commented on HBASE-5821:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12523202/HBASE-5821.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 javadoc.  The javadoc tool did not generate any warning messages.

+1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

-1 findbugs.  The patch appears to introduce 6 new Findbugs (version 1.3.9) 
warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
 

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1566//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1566//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/1566//console

This message is automatically generated.

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-18 Thread Zhihong Yu (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256658#comment-13256658
 ] 

Zhihong Yu commented on HBASE-5821:
---

Patch makes sense.

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-18 Thread Himanshu Vashishtha (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13256794#comment-13256794
 ] 

Himanshu Vashishtha commented on HBASE-5821:


Yes, its a bug. Thanks for pointing this out.
I think the change should be done at the LongColumnInterpreter level?

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-18 Thread Maryann Xue (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257187#comment-13257187
 ] 

Maryann Xue commented on HBASE-5821:


LongColumnInterpreter is simply an implementation of ColumnInterpreter, and 
there could be any other user-defined ColumnInterpreter, so we should not have 
any assumption here. It is better to guarantee the caller itself handles the 
logic properly.

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-18 Thread Himanshu Vashishtha (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257202#comment-13257202
 ] 

Himanshu Vashishtha commented on HBASE-5821:


Yeah, LCM is just an implementation and I thought to better keep the semantics 
of CI right and tight such that we just call compare and it gives what we want 
(as per CI.compareTo() javadoc). 
Otherwise, I am good.

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-5821) Incorrect handling of null value in Coprocessor aggregation function min()

2012-04-18 Thread Zhihong Yu (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-5821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13257235#comment-13257235
 ] 

Zhihong Yu commented on HBASE-5821:
---

@Himanshu:
The LCM above refers to LongColumnInterpreter, right ?
Are you fine with Maryann's patch ?

 Incorrect handling of null value in Coprocessor aggregation function min()
 --

 Key: HBASE-5821
 URL: https://issues.apache.org/jira/browse/HBASE-5821
 Project: HBase
  Issue Type: Bug
  Components: coprocessors
Affects Versions: 0.92.1
Reporter: Maryann Xue
Assignee: Maryann Xue
 Attachments: HBASE-5821.patch


 Both in AggregateImplementation and AggregationClient, the evaluation of the 
 current minimum value is like:
 min = (min == null || ci.compare(result, min)  0) ? result : min;
 The LongColumnInterpreter takes null value is treated as the least value, 
 while the above expression takes min as the greater value when it is null. 
 Thus, the real minimum value gets discarded if a null value comes later.
 max() could also be wrong if a different ColumnInterpreter other than 
 LongColumnInterpreter treats null value differently (as the greatest).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira