[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files
[ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13288798#comment-13288798 ] Gregory Chanan commented on HBASE-6000: --- It looks like we have things under src/protobuf and src/main/protobuf, in addition to the definitions under resources. Cleanup where we keep .proto files -- Key: HBASE-6000 URL: https://issues.apache.org/jira/browse/HBASE-6000 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: stack Assignee: stack Attachments: 6000.txt, 6000.txt I see Andrew for his pb work over in rest has .protos files under src/main/resources. We should unify where these files live. The recently added .protos place them under src/main/protobuf Its confusing. The thift idl files are here under resources too. Seems like we should move src/main/protobuf under src/resources to be consistent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files
[ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277554#comment-13277554 ] stack commented on HBASE-6000: -- There is no requirement that you install protoc to build hbase; the generated classes are checked in as they are for thrift and avro. Generated stuff is at src/main/java/org/apache/hadoop/hbase/protobuf/generated. Cleanup where we keep .proto files -- Key: HBASE-6000 URL: https://issues.apache.org/jira/browse/HBASE-6000 Project: HBase Issue Type: Bug Reporter: stack I see Andrew for his pb work over in rest has .protos files under src/main/resources. We should unify where these files live. The recently added .protos place them under src/main/protobuf Its confusing. The thift idl files are here under resources too. Seems like we should move src/main/protobuf under src/resources to be consistent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files
[ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277591#comment-13277591 ] Hadoop QA commented on HBASE-6000: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527779/6000.txt against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 32 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestMasterReplication Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1905//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1905//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1905//console This message is automatically generated. Cleanup where we keep .proto files -- Key: HBASE-6000 URL: https://issues.apache.org/jira/browse/HBASE-6000 Project: HBase Issue Type: Bug Affects Versions: 0.96.0 Reporter: stack Assignee: stack Attachments: 6000.txt I see Andrew for his pb work over in rest has .protos files under src/main/resources. We should unify where these files live. The recently added .protos place them under src/main/protobuf Its confusing. The thift idl files are here under resources too. Seems like we should move src/main/protobuf under src/resources to be consistent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files
[ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276053#comment-13276053 ] Andrew Purtell commented on HBASE-6000: --- +1 I propose this convention: - IDL files should be under src/resources/, by package plus protobuf/, e.g. src/resources/org/apache/hadoop/hbase/rest/protobuf/ - Generated package names should go into the source tree with the suffix '.generated', e.g. src/main/java/org/apache/hadoop/hbase/rest/protobuf/generated Cleanup where we keep .proto files -- Key: HBASE-6000 URL: https://issues.apache.org/jira/browse/HBASE-6000 Project: HBase Issue Type: Bug Reporter: stack I see Andrew for his pb work over in rest has .protos files under src/main/resources. We should unify where these files live. The recently added .protos place them under src/main/protobuf Its confusing. The thift idl files are here under resources too. Seems like we should move src/main/protobuf under src/resources to be consistent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files
[ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276366#comment-13276366 ] Todd Lipcon commented on HBASE-6000: I don't think IDL belongs in resources because there's no reason for it to end up in the compiled jars. resources are for things that need to be available to the classloader at runtime. Cleanup where we keep .proto files -- Key: HBASE-6000 URL: https://issues.apache.org/jira/browse/HBASE-6000 Project: HBase Issue Type: Bug Reporter: stack I see Andrew for his pb work over in rest has .protos files under src/main/resources. We should unify where these files live. The recently added .protos place them under src/main/protobuf Its confusing. The thift idl files are here under resources too. Seems like we should move src/main/protobuf under src/resources to be consistent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files
[ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276367#comment-13276367 ] Andrew Purtell commented on HBASE-6000: --- bq. I don't think IDL belongs in resources because there's no reason for it to end up in the compiled jars. Then I never got this maven convention. Cleanup where we keep .proto files -- Key: HBASE-6000 URL: https://issues.apache.org/jira/browse/HBASE-6000 Project: HBase Issue Type: Bug Reporter: stack I see Andrew for his pb work over in rest has .protos files under src/main/resources. We should unify where these files live. The recently added .protos place them under src/main/protobuf Its confusing. The thift idl files are here under resources too. Seems like we should move src/main/protobuf under src/resources to be consistent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files
[ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276370#comment-13276370 ] Andrew Purtell commented on HBASE-6000: --- In which case, move the IDL to src/ to be consistent, I'm sorry I said anything. Cleanup where we keep .proto files -- Key: HBASE-6000 URL: https://issues.apache.org/jira/browse/HBASE-6000 Project: HBase Issue Type: Bug Reporter: stack I see Andrew for his pb work over in rest has .protos files under src/main/resources. We should unify where these files live. The recently added .protos place them under src/main/protobuf Its confusing. The thift idl files are here under resources too. Seems like we should move src/main/protobuf under src/resources to be consistent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6000) Cleanup where we keep .proto files
[ https://issues.apache.org/jira/browse/HBASE-6000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276371#comment-13276371 ] Enis Soztutar commented on HBASE-6000: -- .proto files are source files, so +1 for putting them under src/main. bq. In my opinion it should not be necessary to have protoc installed to build HBase, just like it's not necessary to have the Thrift compiler available +1 to that. I think we should make out-of-the-box compilation as easy as possible. If we commit the generated sources under src/, it should be ok. Also +1 on having generated in the package name. We have some maven targets depending on that convention. Cleanup where we keep .proto files -- Key: HBASE-6000 URL: https://issues.apache.org/jira/browse/HBASE-6000 Project: HBase Issue Type: Bug Reporter: stack I see Andrew for his pb work over in rest has .protos files under src/main/resources. We should unify where these files live. The recently added .protos place them under src/main/protobuf Its confusing. The thift idl files are here under resources too. Seems like we should move src/main/protobuf under src/resources to be consistent. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
