[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287237#comment-13287237 ] Hudson commented on HBASE-6002: --- Integrated in HBase-0.92-security #109 (See [https://builds.apache.org/job/HBase-0.92-security/109/]) HBASE-6050 HLogSplitter renaming recovered.edits and CJ removing the parent directory races, making the HBCK to think cluster is inconsistent. and a small addendum for HBASE-6002 (Ram) (Revision 1342935) HBASE-6002 Possible chance of resource leak in HlogSplitter (Chinna Rao) (Revision 1342932) Result = SUCCESS ramkrishna : Files : * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java ramkrishna : Files : * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Fix For: 0.92.2, 0.96.0, 0.94.1 Attachments: HBASE-6002.patch, HBASE-6002_0.92_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch, HBASE-6002_trunk_2.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13287165#comment-13287165 ] Hudson commented on HBASE-6002: --- Integrated in HBase-0.94-security #33 (See [https://builds.apache.org/job/HBase-0.94-security/33/]) HBASE-6002 Possible chance of resource leak in HlogSplitter (Chinna rao) (Revision 1342931) Result = FAILURE ramkrishna : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Fix For: 0.92.2, 0.96.0, 0.94.1 Attachments: HBASE-6002.patch, HBASE-6002_0.92_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch, HBASE-6002_trunk_2.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284023#comment-13284023 ] ramkrishna.s.vasudevan commented on HBASE-6002: --- Committed to trunk, 0.94 and 0.92. Thanks for the patch Chinna. Thanks for the review Stack and Ted. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.92_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch, HBASE-6002_trunk_2.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284034#comment-13284034 ] Hudson commented on HBASE-6002: --- Integrated in HBase-TRUNK #2925 (See [https://builds.apache.org/job/HBase-TRUNK/2925/]) HBASE-6002 Possible chance of resource leak in HlogSplitter (Chinna Rao) (Revision 1342929) Result = FAILURE ramkrishna : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.92_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch, HBASE-6002_trunk_2.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284036#comment-13284036 ] Hudson commented on HBASE-6002: --- Integrated in HBase-0.94 #220 (See [https://builds.apache.org/job/HBase-0.94/220/]) HBASE-6002 Possible chance of resource leak in HlogSplitter (Chinna rao) (Revision 1342931) Result = FAILURE ramkrishna : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.92_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch, HBASE-6002_trunk_2.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284055#comment-13284055 ] Hudson commented on HBASE-6002: --- Integrated in HBase-0.92 #424 (See [https://builds.apache.org/job/HBase-0.92/424/]) HBASE-6050 HLogSplitter renaming recovered.edits and CJ removing the parent directory races, making the HBCK to think cluster is inconsistent. and a small addendum for HBASE-6002 (Ram) (Revision 1342935) HBASE-6002 Possible chance of resource leak in HlogSplitter (Chinna Rao) (Revision 1342932) Result = FAILURE ramkrishna : Files : * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java ramkrishna : Files : * /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.92_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch, HBASE-6002_trunk_2.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13284089#comment-13284089 ] Hudson commented on HBASE-6002: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #18 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/18/]) HBASE-6002 Possible chance of resource leak in HlogSplitter (Chinna Rao) (Revision 1342929) Result = FAILURE ramkrishna : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.92_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch, HBASE-6002_trunk_2.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283688#comment-13283688 ] Hadoop QA commented on HBASE-6002: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12529760/HBASE-6002_trunk_1.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 33 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher org.apache.hadoop.hbase.master.TestSplitLogManager Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1999//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1999//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1999//console This message is automatically generated. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283702#comment-13283702 ] Zhihong Yu commented on HBASE-6002: --- Latest patch looks Okay. Check out the failed tests. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283902#comment-13283902 ] ramkrishna.s.vasudevan commented on HBASE-6002: --- The test failures are not related to this fix. However org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster failure i doubted is because of HBASE-6070. But every time it passes locally . Infact the commit was done because all test cases passed locally. I will investigate more on that if still failure persists. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13283905#comment-13283905 ] ramkrishna.s.vasudevan commented on HBASE-6002: --- I think the two testcases in org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testShutdownSimpleFixup and testShutdownFixupWhenDaughterHasSplit needs some clean up. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch, HBASE-6002_trunk_1.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279012#comment-13279012 ] Chinna Rao Lalam commented on HBASE-6002: - @Stack: yes writersClosed flag is used for not to attempt in finally block if the all writers are closed successfully. @Ted: bq.close previously closed stream has no effect I think previous close successful then it wont take any effect (I am fully not sure) i need to check this. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279015#comment-13279015 ] stack commented on HBASE-6002: -- I'm fine w/ commit. Was setting wap.w = null after close discussed? (could copy it before actual call to close and then close the copy after setting wap.w = null) Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13279016#comment-13279016 ] stack commented on HBASE-6002: -- Sorry. My above suggestion would do away w/ the need of the flag and it would make the flag and it would make the check more particular being done per wap.w. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[
https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278010#comment-13278010
]
Chinna Rao Lalam commented on HBASE-6002:
-
@Ted:
If add closed flag in WriterAndPath after successfull close of the writer make
this flag to true. so first time if it fails flag wont be true and second time
it will try to close.
I feel same thing is achieved with the writer!=null in
SequenceFileLogWriter.close(). Here after successful close of the writer it
will be initialized with null. So second time if tries to close the already
closed writer it will check whether it is null or not if not equal to null then
only it will try to close.
{code}
if (this.writer != null) {
try {
this.writer.close();
} catch (NullPointerException npe) {
// Can get a NPE coming up from down in DFSClient$DFSOutputStream#close
LOG.warn(npe);
}
this.writer = null;
}
{code}
your comment @ 16/May/12 18:44
bq.If the first close encountered some IOE, calling it the second time would
most likely encounter similar error.
if the first close encountered IOE if we have closed flag in WriterAndPath it
wont be make it true because writer is not succesfully closed. So second time
it will try to close.
We can use this flag as attempted or not?
If my understanding is wrong pls correct me.
Possible chance of resource leak in HlogSplitter
Key: HBASE-6002
URL: https://issues.apache.org/jira/browse/HBASE-6002
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.94.0, 0.96.0
Reporter: Chinna Rao Lalam
Assignee: Chinna Rao Lalam
Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch,
HBASE-6002_trunk.patch
In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally
block in loop while closing the writers(wap.w) if any exception comes other
writers won't close.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278023#comment-13278023 ] Zhihong Yu commented on HBASE-6002: --- As you said above, introducing a closed flag wouldn't improve much. I was thinking about a boolean flag which marks whether close() has been attempted on the writer. This is to avoid extraneous logging of IOE's. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278063#comment-13278063 ] Chinna Rao Lalam commented on HBASE-6002: - But here my concern is close is not success let me try second time to close. If u feel it will generate more logging of IOE's i will update the patch. What u say.. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278086#comment-13278086 ] stack commented on HBASE-6002: -- Is that writersClosed flag being used? Agree we should not try and close again if first close fails. I'd be fine w/ IOE spew on fail. It should be rare. If lots of spew, probably something wrong. Can fix it later if too bad. I think avoiding the resource leak the important thing. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13278291#comment-13278291 ] Zhihong Yu commented on HBASE-6002: --- The official API doc for Writer/Closeable#close only specifies that close previously closed stream has no effect. FYI Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[
https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276512#comment-13276512
]
Zhihong Yu commented on HBASE-6002:
---
Should the following code in patch:
{code}
+ try {
+wap.w.close();
+ } catch (IOException e) {
{code}
be placed around wap.w.close() call at line 475 ?
Possible chance of resource leak in HlogSplitter
Key: HBASE-6002
URL: https://issues.apache.org/jira/browse/HBASE-6002
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.94.0
Reporter: Chinna Rao Lalam
Assignee: Chinna Rao Lalam
Attachments: HBASE-6002.patch
In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally
block in loop while closing the writers(wap.w) if any exception comes other
writers won't close.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276995#comment-13276995 ] Chinna Rao Lalam commented on HBASE-6002: - @Ted : Updated the patch with above comment Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[
https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277010#comment-13277010
]
Zhihong Yu commented on HBASE-6002:
---
The same construct is used for both places when closing writer:
{code}
+ try {
+wap.w.close();
+ } catch (IOException e) {
{code}
If the first close encountered some IOE, calling it the second time would most
likely encounter similar error.
My comment @ 15/May/12 21:25 applies in the above scenario.
Possible chance of resource leak in HlogSplitter
Key: HBASE-6002
URL: https://issues.apache.org/jira/browse/HBASE-6002
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.94.0, 0.96.0
Reporter: Chinna Rao Lalam
Assignee: Chinna Rao Lalam
Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch,
HBASE-6002_trunk.patch
In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally
block in loop while closing the writers(wap.w) if any exception comes other
writers won't close.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13277029#comment-13277029 ] Hadoop QA commented on HBASE-6002: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12527670/HBASE-6002_trunk.patch against trunk revision . +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 hadoop23. The patch compiles against the hadoop 0.23.x profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 31 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster org.apache.hadoop.hbase.regionserver.TestServerCustomProtocol Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1894//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1894//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1894//console This message is automatically generated. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0, 0.96.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch, HBASE-6002_0.94_1.patch, HBASE-6002_trunk.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276057#comment-13276057 ] Chinna Rao Lalam commented on HBASE-6002: - Its good to close these writers in seperate finally block if any writer is not closed because of exception it will be closed here. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[
https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276229#comment-13276229
]
Zhihong Yu commented on HBASE-6002:
---
{code}
+ try {
+wap.w.close();
+ } catch (IOException e) {
+LOG.debug(Exception while closing the writer :, e);
{code}
The above may produce considerable logs. Can boolean flag, closed, be added to
WriterAndPath so that we don't try to close an already closed writer ?
Possible chance of resource leak in HlogSplitter
Key: HBASE-6002
URL: https://issues.apache.org/jira/browse/HBASE-6002
Project: HBase
Issue Type: Bug
Components: wal
Affects Versions: 0.94.0
Reporter: Chinna Rao Lalam
Assignee: Chinna Rao Lalam
Attachments: HBASE-6002.patch
In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally
block in loop while closing the writers(wap.w) if any exception comes other
writers won't close.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276456#comment-13276456 ] Anoop Sam John commented on HBASE-6002: --- +1 on the boolean flag maintained at each Writer level so that avoiding the close attempt again on the already closed item. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6002) Possible chance of resource leak in HlogSplitter
[ https://issues.apache.org/jira/browse/HBASE-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13276494#comment-13276494 ] Chinna Rao Lalam commented on HBASE-6002: - wap.w.close() internally will check writer is not equal to nul or not if it is not equal to null then it will try to close. So here it wont attempt to close the already closed writer. Possible chance of resource leak in HlogSplitter Key: HBASE-6002 URL: https://issues.apache.org/jira/browse/HBASE-6002 Project: HBase Issue Type: Bug Components: wal Affects Versions: 0.94.0 Reporter: Chinna Rao Lalam Assignee: Chinna Rao Lalam Attachments: HBASE-6002.patch In HLogSplitter.splitLogFileToTemp-Reader(in) is not closed and in finally block in loop while closing the writers(wap.w) if any exception comes other writers won't close. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
