[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-27 Thread Gregory Chanan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442308#comment-13442308
 ] 

Gregory Chanan commented on HBASE-6477:
---

I changed HbaseObjectWritable to serialize the Scan as a protobuf rather than a 
Writable and it passed the median test, but fails later on in 
TestAggregateProtocol.  Most likely this indicates something is wrong with the 
protobuf serialization/deserialization of the scan.

I'll take a closer look tomorrow.

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, 
 HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-27 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442330#comment-13442330
 ] 

Hadoop QA commented on HBASE-6477:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12542584/HBASE-6477-addendum.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

-1 javadoc.  The javadoc tool appears to have generated 94 warning messages.

-1 javac.  The applied patch generated 5 javac compiler warnings (more than 
the trunk's current 4 warnings).

-1 findbugs.  The patch appears to introduce 13 new Findbugs (version 
1.3.9) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.regionserver.TestStore

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2699//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2699//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2699//console

This message is automatically generated.

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: HBASE-6477-addendum.patch, HBASE-6477-nonrb.patch, 
 HBASE-6477-nonrb-v3.patch, HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442515#comment-13442515
 ] 

Ted Yu commented on HBASE-6477:
---

I ran addendum through test suite and TestStore passed:
{code}
Running org.apache.hadoop.hbase.regionserver.TestStore
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.304 sec
...
Running org.apache.hadoop.hbase.coprocessor.TestAggregateProtocol
Tests run: 45, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.151 sec
{code}
Recommend integrating the addendum and leave the remaining issues (w.r.t. 
removing HbaseObjectWritable.writeObject call in ProtobufUtil.toParameter) to 
other JIRA.

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: 6477-addendum.patch, HBASE-6477-addendum.patch, 
 HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-27 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442528#comment-13442528
 ] 

Hadoop QA commented on HBASE-6477:
--

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12542615/6477-addendum.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

-1 tests included.  The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

+1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

-1 javadoc.  The javadoc tool appears to have generated 94 warning messages.

-1 javac.  The applied patch generated 5 javac compiler warnings (more than 
the trunk's current 4 warnings).

-1 findbugs.  The patch appears to introduce 13 new Findbugs (version 
1.3.9) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

+1 core tests.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2701//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2701//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2701//console

This message is automatically generated.

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: 6477-addendum.patch, HBASE-6477-addendum.patch, 
 HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442556#comment-13442556
 ] 

Ted Yu commented on HBASE-6477:
---

@Stack:
What's your opinion ?

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: 6477-addendum.patch, HBASE-6477-addendum.patch, 
 HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-27 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442602#comment-13442602
 ] 

stack commented on HBASE-6477:
--

+1 on addendum.  Thanks Gregory for figuring it out (and Ted for finding 
issue).   Good stuff lads.  Will I commit?

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: 6477-addendum.patch, HBASE-6477-addendum.patch, 
 HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-27 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442608#comment-13442608
 ] 

Ted Yu commented on HBASE-6477:
---

Go ahead, Stack.

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: 6477-addendum.patch, HBASE-6477-addendum.patch, 
 HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442675#comment-13442675
 ] 

Hudson commented on HBASE-6477:
---

Integrated in HBase-TRUNK #3283 (See 
[https://builds.apache.org/job/HBase-TRUNK/3283/])
HBASE-6477 Use PB filter definitions in RPC (Revision 1377788)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java


 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: 6477-addendum.patch, HBASE-6477-addendum.patch, 
 HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-27 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442828#comment-13442828
 ] 

Hudson commented on HBASE-6477:
---

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #151 (See 
[https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/151/])
HBASE-6477 Use PB filter definitions in RPC (Revision 1377788)

 Result = FAILURE
stack : 
Files : 
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
* 
/hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java


 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: 6477-addendum.patch, HBASE-6477-addendum.patch, 
 HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-26 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442199#comment-13442199
 ] 

Ted Yu commented on HBASE-6477:
---

Here is the call stack:
{code}
HbaseObjectWritable.writeObject(DataOutput, Object, Class, Configuration) line: 
547 
ProtobufUtil.toParameter(Class?, Object) line: 1147   
ProtobufUtil.toExec(Exec) line: 732 
RequestConverter.buildExecCoprocessorRequest(byte[], Exec) line: 487
ProtobufUtil.execCoprocessor(ClientProtocol, Exec, byte[]) line: 1286   
ExecRPCInvoker$1.call() line: 80
ExecRPCInvoker$1.call() line: 77
ExecRPCInvoker$1(ServerCallableT).withRetries() line: 169 
ExecRPCInvoker.invoke(Object, Method, Object[]) line: 83
$Proxy25.getMedian(ColumnInterpreter, Scan) line: not available 
AggregationClient$7.call(AggregateProtocol) line: 465   
AggregationClient$7.call(Object) line: 462  
HConnectionManager$HConnectionImplementation$4.call() line: 2194
FutureTask$Sync.innerRun() line: 303
FutureTaskV.run() line: 138   
ThreadPoolExecutor$Worker.runTask(Runnable) line: 886   
ThreadPoolExecutor$Worker.run() line: 908   
Thread.run() line: 680  
{code}
So as long as HbaseObjectWritable.writeObject() call is in our code base, 
migration away from Writable wouldn't be complete.

w.r.t. Gregory's patch, we can either:
1. let Scan implement Writable
2. roll back so that we can have a green build

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, 
 HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-26 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442207#comment-13442207
 ] 

Ted Yu commented on HBASE-6477:
---

This is Gregory's 1st goal:
Filter would no longer extend Writable

So option #1 above wouldn't work because Scan had this code:
{code}
if(in.readBoolean()) {
  this.filter = 
(Filter)createForName(Bytes.toString(Bytes.readByteArray(in)));
  this.filter.readFields(in);
}
{code}

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, 
 HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-26 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442209#comment-13442209
 ] 

stack commented on HBASE-6477:
--

I can work on a patch to fix above (Thanks for finding it Ted).  I have to step 
out for moment so it'd be later.   I'd rather keep this patch in at least for a 
day or so.  Its a mammoth patch so some teething getting it all in is expected 
I'd say.

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, 
 HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-26 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1344#comment-1344
 ] 

Ted Yu commented on HBASE-6477:
---

This is the important call in AggregationClient.getMedianArgs():
{code}
  return instance.getMedian(ci, scan);
{code}
which involves the following method defined in AggregateProtocol:
{code}
  T, S ListS getMedian(ColumnInterpreterT, S ci, Scan scan)
{code}
To my understanding, we need to explicitly PB-fy AggregateProtocol.
I believe there is a dependency on Gary's work for coprocessors.

Correct me if I am wrong.

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, 
 HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-26 Thread Gregory Chanan (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442257#comment-13442257
 ] 

Gregory Chanan commented on HBASE-6477:
---

Thanks for finding this, Ted.

I wonder if we can make the Exec call pass the Scan as the protobuf'ed version 
rather than the Writable.  I'll look at doing it that way.

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch, 
 HBASE-6477-nonrb-v4.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440135#comment-13440135
 ] 

Hadoop QA commented on HBASE-6477:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12542062/HBASE-6477-nonrb.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 46 new or modified tests.

-1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2665//console

This message is automatically generated.

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: HBASE-6477-nonrb.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (HBASE-6477) Use PB filter definitions in RPC

2012-08-23 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-6477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13440805#comment-13440805
 ] 

Hadoop QA commented on HBASE-6477:
--

-1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12542199/HBASE-6477-nonrb-v3.patch
  against trunk revision .

+1 @author.  The patch does not contain any @author tags.

+1 tests included.  The patch appears to include 46 new or modified tests.

+1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

-1 javadoc.  The javadoc tool appears to have generated 86 warning messages.

-1 javac.  The applied patch generated 5 javac compiler warnings (more than 
the trunk's current 4 warnings).

-1 findbugs.  The patch appears to introduce 10 new Findbugs (version 
1.3.9) warnings.

+1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

 -1 core tests.  The patch failed these unit tests:
   org.apache.hadoop.hbase.client.TestFromClientSide
  
org.apache.hadoop.hbase.client.TestFromClientSideWithCoprocessor
  org.apache.hadoop.hbase.TestMultiVersions

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2675//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2675//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/2675//console

This message is automatically generated.

 Use PB filter definitions in RPC
 

 Key: HBASE-6477
 URL: https://issues.apache.org/jira/browse/HBASE-6477
 Project: HBase
  Issue Type: Task
  Components: ipc, migration
Reporter: Gregory Chanan
Assignee: Gregory Chanan
 Fix For: 0.96.0

 Attachments: HBASE-6477-nonrb.patch, HBASE-6477-nonrb-v3.patch


 Use the filters introduced in HBASE-6454 in the rpc so they are extensible

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira