[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544464#comment-13544464 ] Hudson commented on HBASE-7412: --- Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See [https://builds.apache.org/job/HBase-0.94-security-on-Hadoop-23/10/]) HBASE-7412 Fix how HTableDescriptor handles default max file size and flush size - ADDENDUM (Revision 1426682) HBASE-7412 Fix how HTableDescriptor handles default max file size and flush size (Revision 1426658) Result = FAILURE jxiang : Files : * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java jxiang : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540816#comment-13540816 ] Hudson commented on HBASE-7412: --- Integrated in HBase-0.94-security #90 (See [https://builds.apache.org/job/HBase-0.94-security/90/]) HBASE-7412 Fix how HTableDescriptor handles default max file size and flush size - ADDENDUM (Revision 1426682) HBASE-7412 Fix how HTableDescriptor handles default max file size and flush size (Revision 1426658) Result = FAILURE jxiang : Files : * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java jxiang : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540879#comment-13540879 ] Hudson commented on HBASE-7412: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #318 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/318/]) HBASE-7412 Fix how HTableDescriptor handles default max file size and flush size - ADDENDUM (Revision 1426683) Result = FAILURE jxiang : Files : * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540530#comment-13540530 ] Jimmy Xiang commented on HBASE-7412: Yes, v2 is less intrusive. I will commit v2 tomorrow if no objection. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[
https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540535#comment-13540535
]
Hadoop QA commented on HBASE-7412:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562591/0.94-7412_v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3736//console
This message is automatically generated.
Fix how HTableDescriptor handles default max file size and flush size
-
Key: HBASE-7412
URL: https://issues.apache.org/jira/browse/HBASE-7412
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
Priority: Minor
Fix For: 0.96.0, 0.94.4
Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch,
trunk-7412_v2.patch
If the region flush size is not set in the table,
IncreasingToUpperBoundRegionSplitPolicy will most likely always use the
default value: 128MB, even if the flush size is set to a different value in
hbase-site.xml.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540573#comment-13540573 ] Lars Hofhansl commented on HBASE-7412: -- +1 on v2 Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540632#comment-13540632 ] Lars Hofhansl commented on HBASE-7412: -- Wanna just commit Jimmy. I would like to cut an 0.94.4RC soon. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540633#comment-13540633 ] Jimmy Xiang commented on HBASE-7412: Sure. Thanks. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540636#comment-13540636 ] Jimmy Xiang commented on HBASE-7412: Done. Integrated into trunk and 0.94. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540648#comment-13540648 ] Hudson commented on HBASE-7412: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #317 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/317/]) HBASE-7412 Fix how HTableDescriptor handles default max file size and flush size (Revision 1426657) Result = FAILURE jxiang : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540655#comment-13540655 ] Hudson commented on HBASE-7412: --- Integrated in HBase-0.94 #675 (See [https://builds.apache.org/job/HBase-0.94/675/]) HBASE-7412 Fix how HTableDescriptor handles default max file size and flush size (Revision 1426658) Result = FAILURE jxiang : Files : * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540658#comment-13540658 ] Lars Hofhansl commented on HBASE-7412: -- The 0.94 failures look potentially (if remotely) related. I'll trigger another build. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540665#comment-13540665 ] Lars Hofhansl commented on HBASE-7412: -- I get the same failures locally, too. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540668#comment-13540668 ] Jimmy Xiang commented on HBASE-7412: Me too. I am looking into it now. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540673#comment-13540673 ] Lars Hofhansl commented on HBASE-7412: -- Passes again with this patch reverted. Looking at the patch I have no explanation. I'll see if I can fix the tests, otherwise let's revert (sorry I suggested you commit, Jimmy) Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540675#comment-13540675 ] Lars Hofhansl commented on HBASE-7412: -- That test lowers the flush size to 25000 bytes (to get flushes), somehow that must interact with this change. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540680#comment-13540680 ] Jimmy Xiang commented on HBASE-7412: No problem. If we can't get this fixed quickly, we have to revert it. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540687#comment-13540687 ] Jimmy Xiang commented on HBASE-7412: An easy fix is to use a different split policy for this test. Not sure, if it is good to increase the flush size. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540688#comment-13540688 ] Lars Hofhansl commented on HBASE-7412: -- Oh I see. NotServingRegionException is normally resolved by the client retrying. In this case, though, we're performing the puts directly through HRegion, and hence it fails at the first split. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540693#comment-13540693 ] Jimmy Xiang commented on HBASE-7412: Before the patch, IncreasingToUpperBoundRegionSplitPolicy uses the default flush size. But the region is actually using the small flush size. I think the test intends to use the small flush size, and doesn't want split. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540694#comment-13540694 ] Jimmy Xiang commented on HBASE-7412: After I change the split policy for this test conf.set(HConstants.HBASE_REGION_SPLIT_POLICY_KEY, ConstantSizeRegionSplitPolicy.class.getName()); Then the test is green locally for me. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540696#comment-13540696 ] Jimmy Xiang commented on HBASE-7412: The addendum is attached. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540699#comment-13540699 ] Ted Yu commented on HBASE-7412: --- Would this fix be an incompatible change ? Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540698#comment-13540698 ] Jimmy Xiang commented on HBASE-7412: @Lars, could you please review the addendum? Thanks. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540702#comment-13540702 ] Hudson commented on HBASE-7412: --- Integrated in HBase-TRUNK #3669 (See [https://builds.apache.org/job/HBase-TRUNK/3669/]) HBASE-7412 Fix how HTableDescriptor handles default max file size and flush size (Revision 1426657) Result = FAILURE jxiang : Files : * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/HTableDescriptor.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ConstantSizeRegionSplitPolicy.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/IncreasingToUpperBoundRegionSplitPolicy.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/TestHTableDescriptor.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin.java Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540704#comment-13540704 ] Jimmy Xiang commented on HBASE-7412: I think we should have the fix. Otherwise, IncreasingToUpperBoundRegionSplitPolicy doesn't work as expected. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540705#comment-13540705 ] Ted Yu commented on HBASE-7412: --- Actually Hadoop QA found out the failing test on the 21st: https://builds.apache.org/job/PreCommit-HBASE-Build/3639//testReport/ Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540707#comment-13540707 ] Lars Hofhansl commented on HBASE-7412: -- +1 on addendum. (And yeah, jenkins failed legitimately :) ). @Ted: It is a slight change behavior, but the previous behavior was wrong. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540709#comment-13540709 ] Ted Yu commented on HBASE-7412: --- Since IncreasingToUpperBoundRegionSplitPolicy is no longer used in TestHFileArchiving, how do we know that this policy works as expected for file archiving ? Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540711#comment-13540711 ] Jimmy Xiang commented on HBASE-7412: Addendum is integrated into trunk and 0.94. Sorry for that. @Ted, yes, I should pay more attention to the precommit report. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540710#comment-13540710 ] Lars Hofhansl commented on HBASE-7412: -- TestHFileArchiving is not testing splitting but archiving, thus it sets it up with some store file to see if they are archived correctly. That is perfectly valid. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540714#comment-13540714 ] Lars Hofhansl commented on HBASE-7412: -- That's the problem when there are many failing tests. Another one is easily lost in the noise. (I think we need an initiative to make the 0.96 and precommit tests pass with high probability... But that's a different story) Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540728#comment-13540728 ] Hudson commented on HBASE-7412: --- Integrated in HBase-0.94 #676 (See [https://builds.apache.org/job/HBase-0.94/676/]) HBASE-7412 Fix how HTableDescriptor handles default max file size and flush size - ADDENDUM (Revision 1426682) Result = SUCCESS jxiang : Files : * /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540731#comment-13540731 ] Hudson commented on HBASE-7412: --- Integrated in HBase-TRUNK #3670 (See [https://builds.apache.org/job/HBase-TRUNK/3670/]) HBASE-7412 Fix how HTableDescriptor handles default max file size and flush size - ADDENDUM (Revision 1426683) Result = FAILURE jxiang : Files : * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/TestHFileArchiving.java Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540764#comment-13540764 ] stack commented on HBASE-7412: -- bq. (I think we need an initiative to make the 0.96 and precommit tests pass with high probability... But that's a different story) Agreed. Trying to fix some blockers first. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412-addendum.patch, 0.94-7412.patch, 0.94-7412_v2.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540369#comment-13540369 ] Lars Hofhansl commented on HBASE-7412: -- [~saint@gmail.com], mind having a quick look? I think you added the dynamic region sizing code. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13540374#comment-13540374 ] stack commented on HBASE-7412: -- Patch looks good. Harmless. I kinda liked it when you were passing in the conf and all of the mess figuring whether to read from HTD or from conf was contained within HTD but this looks less intrusive of a change. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13539679#comment-13539679 ] Jimmy Xiang commented on HBASE-7412: Making HTableDescriptor take in a Conf in constructor will make the interface cleaner. However, it involves other changes. We still need to change the code calling #getMaxFileSize and #getMemStoreFlushSize since the existing code is wrong assuming the default setting must not be from the table specific setting. Let me think about it how we fix this. I will fix the javadoc errors. Yes, the un-boxing code is not good. It is some existing code. I will fix it. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, trunk-7412.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13539700#comment-13539700 ] Jimmy Xiang commented on HBASE-7412: HTableDescriptor is used in both client side and server side. Client side and server side could have different configuration. That means it should not depends on configuration object? Otherwise, we could get inconsistent values. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, trunk-7412.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13539741#comment-13539741 ] Enis Soztutar commented on HBASE-7412: -- bq. That's right. This patch is a valid bug fix. Also, HBASE-7236 is not for 0.94. I see. Makes sense to fix separately. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, trunk-7412.patch, trunk-7412_v2.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13539648#comment-13539648 ] Elliott Clark commented on HBASE-7412: -- * Should we just make HTableDescriptor take in a Conf in the constructor ? Then everything that relies on region.getTableDescriptor won't have any code changes. * It looks like this will cause a few javadoc errors (Hadoop qa missed them but it would catch them now I think). * I don't think that the forced un-boxing on Long is needed for the two return Long.valueOf. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, trunk-7412.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13538256#comment-13538256 ] Jimmy Xiang commented on HBASE-7412: That's right. This patch is a valid bug fix. Also, HBASE-7236 is not for 0.94. I have some questions for HBASE-7236, will post on the RB. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, trunk-7412.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537476#comment-13537476 ] Jimmy Xiang commented on HBASE-7412: Changed the title. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0 If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537554#comment-13537554 ] Jimmy Xiang commented on HBASE-7412: The HTableDescriptor interface is changed a little. Is this ok? Should we keep the old functions and deprecate them? Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: trunk-7412.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[
https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537598#comment-13537598
]
Hadoop QA commented on HBASE-7412:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562012/trunk-7412.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 28 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.backup.TestHFileArchiving
{color:red}-1 core zombie tests{color}. There are zombie tests. See build
logs for details.
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3639//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3639//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3639//console
This message is automatically generated.
Fix how HTableDescriptor handles default max file size and flush size
-
Key: HBASE-7412
URL: https://issues.apache.org/jira/browse/HBASE-7412
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
Priority: Minor
Fix For: 0.96.0, 0.94.4
Attachments: 0.94-7412.patch, trunk-7412.patch
If the region flush size is not set in the table,
IncreasingToUpperBoundRegionSplitPolicy will most likely always use the
default value: 128MB, even if the flush size is set to a different value in
hbase-site.xml.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[
https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537604#comment-13537604
]
Hadoop QA commented on HBASE-7412:
--
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562019/0.94-7412.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3640//console
This message is automatically generated.
Fix how HTableDescriptor handles default max file size and flush size
-
Key: HBASE-7412
URL: https://issues.apache.org/jira/browse/HBASE-7412
Project: HBase
Issue Type: Bug
Components: regionserver
Reporter: Jimmy Xiang
Assignee: Jimmy Xiang
Priority: Minor
Fix For: 0.96.0, 0.94.4
Attachments: 0.94-7412.patch, trunk-7412.patch
If the region flush size is not set in the table,
IncreasingToUpperBoundRegionSplitPolicy will most likely always use the
default value: 128MB, even if the flush size is set to a different value in
hbase-site.xml.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537616#comment-13537616 ] Enis Soztutar commented on HBASE-7412: -- Not 100% sure, but I think HBASE-7236 also fixes this issue and is more general. Can you please take a look into that? Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, trunk-7412.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-7412) Fix how HTableDescriptor handles default max file size and flush size
[ https://issues.apache.org/jira/browse/HBASE-7412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537632#comment-13537632 ] Sergey Shelukhin commented on HBASE-7412: - Yeah, 7236 fixes this issue too. But I think it's valid to fix it separately just as a bug fix. Fix how HTableDescriptor handles default max file size and flush size - Key: HBASE-7412 URL: https://issues.apache.org/jira/browse/HBASE-7412 Project: HBase Issue Type: Bug Components: regionserver Reporter: Jimmy Xiang Assignee: Jimmy Xiang Priority: Minor Fix For: 0.96.0, 0.94.4 Attachments: 0.94-7412.patch, trunk-7412.patch If the region flush size is not set in the table, IncreasingToUpperBoundRegionSplitPolicy will most likely always use the default value: 128MB, even if the flush size is set to a different value in hbase-site.xml. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
