[jira] [Updated] (HBASE-16489) Configuration parsing
[ https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-16489: -- Attachment: HBASE-16489_v8.patch Attaching what is committed. > Configuration parsing > - > > Key: HBASE-16489 > URL: https://issues.apache.org/jira/browse/HBASE-16489 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Fix For: HBASE-14850 > > Attachments: HBASE-16489.HBASE-14850.v1.patch, > HBASE-16489.HBASE-14850.v2.patch, HBASE-16489.HBASE-14850.v3.patch, > HBASE-16489.HBASE-14850.v4.patch, HBASE-16489.HBASE-14850.v5.patch, > HBASE-16489.HBASE-14850.v6.patch, HBASE-16489.HBASE-14850.v7.patch, > HBASE-16489_v8.patch > > > Reading hbase-site.xml is required to read various properties viz. > zookeeper-quorum, client retires etc. We can either use Apache Xerces or > Boost libraries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16489) Configuration parsing
[ https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Enis Soztutar updated HBASE-16489: -- Fix Version/s: HBASE-14850 > Configuration parsing > - > > Key: HBASE-16489 > URL: https://issues.apache.org/jira/browse/HBASE-16489 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Fix For: HBASE-14850 > > Attachments: HBASE-16489.HBASE-14850.v1.patch, > HBASE-16489.HBASE-14850.v2.patch, HBASE-16489.HBASE-14850.v3.patch, > HBASE-16489.HBASE-14850.v4.patch, HBASE-16489.HBASE-14850.v5.patch, > HBASE-16489.HBASE-14850.v6.patch, HBASE-16489.HBASE-14850.v7.patch > > > Reading hbase-site.xml is required to read various properties viz. > zookeeper-quorum, client retires etc. We can either use Apache Xerces or > Boost libraries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16489) Configuration parsing
[ https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-16489: -- Attachment: HBASE-16489.HBASE-14850.v7.patch This patch consists of the below changes. # Chaged filename of configuration_loader.* to hbase_configuration_loader.* # Changed the paths to search for hbase configuration files in unit tests to relative ones. # Changed line wrapping to 100. # Changed conditions in unit tests to ASSERT_TRUE() checks. Thanks > Configuration parsing > - > > Key: HBASE-16489 > URL: https://issues.apache.org/jira/browse/HBASE-16489 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-16489.HBASE-14850.v1.patch, > HBASE-16489.HBASE-14850.v2.patch, HBASE-16489.HBASE-14850.v3.patch, > HBASE-16489.HBASE-14850.v4.patch, HBASE-16489.HBASE-14850.v5.patch, > HBASE-16489.HBASE-14850.v6.patch, HBASE-16489.HBASE-14850.v7.patch > > > Reading hbase-site.xml is required to read various properties viz. > zookeeper-quorum, client retires etc. We can either use Apache Xerces or > Boost libraries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16489) Configuration parsing
[ https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-16489: -- Attachment: HBASE-16489.HBASE-14850.v6.patch The last patch had an issue with one of the unit tests i.e Configuration.LoadConfFromMultipleLocatons intermittently, which has been fixed in this patch. > Configuration parsing > - > > Key: HBASE-16489 > URL: https://issues.apache.org/jira/browse/HBASE-16489 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-16489.HBASE-14850.v1.patch, > HBASE-16489.HBASE-14850.v2.patch, HBASE-16489.HBASE-14850.v3.patch, > HBASE-16489.HBASE-14850.v4.patch, HBASE-16489.HBASE-14850.v5.patch, > HBASE-16489.HBASE-14850.v6.patch > > > Reading hbase-site.xml is required to read various properties viz. > zookeeper-quorum, client retires etc. We can either use Apache Xerces or > Boost libraries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16489) Configuration parsing
[ https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-16489: -- Attachment: HBASE-16489.HBASE-14850.v5.patch This patch addresses the issues raised in the last feedback. > Configuration parsing > - > > Key: HBASE-16489 > URL: https://issues.apache.org/jira/browse/HBASE-16489 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-16489.HBASE-14850.v1.patch, > HBASE-16489.HBASE-14850.v2.patch, HBASE-16489.HBASE-14850.v3.patch, > HBASE-16489.HBASE-14850.v4.patch, HBASE-16489.HBASE-14850.v5.patch > > > Reading hbase-site.xml is required to read various properties viz. > zookeeper-quorum, client retires etc. We can either use Apache Xerces or > Boost libraries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16489) Configuration parsing
[ https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-16489: -- Attachment: HBASE-16489.HBASE-14850.v4.patch This patch consists of the foll changes:- 1) Changed hbase_configuration.cc/.h to configuration.cc/.h 2) Made ConfigData struct, member of Configuration class, which will be populated by ConfigurationLoader 3) boost::optional changed to std::experimental::optional Separated ConfigurationLoader and Configuration. We can now load xml property files with either default or custom paths as follows:- ConfigurationLoader loader; // Use loader to set/add default/custom search paths and resources resp. loader.SetDefaultSearchPath(); loader.AddDefaultResources(); loader.SetSearchPath(); loader.AddResources(); // Use loader to load the conf with xml file as follows:- Configuration conf; loader.Load(conf); > Configuration parsing > - > > Key: HBASE-16489 > URL: https://issues.apache.org/jira/browse/HBASE-16489 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-16489.HBASE-14850.v1.patch, > HBASE-16489.HBASE-14850.v2.patch, HBASE-16489.HBASE-14850.v3.patch, > HBASE-16489.HBASE-14850.v4.patch > > > Reading hbase-site.xml is required to read various properties viz. > zookeeper-quorum, client retires etc. We can either use Apache Xerces or > Boost libraries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16489) Configuration parsing
[ https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-16489: -- Attachment: HBASE-16489.HBASE-14850.v3.patch This patch consists of the foll changes:- 1) Addressed separation of Configuration and ConfigurationLoader. 2) Removed file separator constant for Windows. 3) Added optionals while fetching values from configuration files and environment. 4) Added the foll methods GetInt, GetLong, GetDouble, GetBool. 5) Unit tests hooked up to the client. > Configuration parsing > - > > Key: HBASE-16489 > URL: https://issues.apache.org/jira/browse/HBASE-16489 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-16489.HBASE-14850.v1.patch, > HBASE-16489.HBASE-14850.v2.patch, HBASE-16489.HBASE-14850.v3.patch > > > Reading hbase-site.xml is required to read various properties viz. > zookeeper-quorum, client retires etc. We can either use Apache Xerces or > Boost libraries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16489) Configuration parsing
[ https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-16489: -- Attachment: HBASE-16489.HBASE-14850.v2.patch Hi, this patch does the foll:- 1) Creates a map of HBase configuration prporty based on the xml file present int path defined as an environment variable HBASE_CONF or /etc/hbase/conf 2) A custom search path can be provided. 3) hbase-default.xml and hbase-site.xml are loaded by default. 4) Custom xml files can be loaded as well. 5) Values will be overwritten if not marked as final 6) Unit tests added by to verify loading of default valuse, custom values, final values, self referencing variables, environment variables, expansion variables. Temporary hbase-default.xml and hbase-site.xml are created in build/ path for validating unit tests. 7) Variable substitution is addressed at the time of Get. We check for presence of variables in the ENV. If variables are not present in the ENV, property map (1) lookup is performed. 8) Removed deprecated key handling in Get from the last patch Some of the API's have been taken from HDFS-8707 which addresses configuration loading 9) Tests hooked up in BUCK > Configuration parsing > - > > Key: HBASE-16489 > URL: https://issues.apache.org/jira/browse/HBASE-16489 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-16489.HBASE-14850.v1.patch, > HBASE-16489.HBASE-14850.v2.patch > > > Reading hbase-site.xml is required to read various properties viz. > zookeeper-quorum, client retires etc. We can either use Apache Xerces or > Boost libraries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16489) Configuration parsing
[ https://issues.apache.org/jira/browse/HBASE-16489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sudeep Sunthankar updated HBASE-16489: -- Attachment: HBASE-16489.HBASE-14850.v1.patch Hi, This patch loads configuration from hbase-default.xml and hbase-site.xml and stores in a map. It requires a file-path where the above mentioned configuration files are checked for existence. If none of the files are present an exception is thrown. We have used Boost libraries for parsing the xml files. Tests have been hooked up in BUCK as well. > Configuration parsing > - > > Key: HBASE-16489 > URL: https://issues.apache.org/jira/browse/HBASE-16489 > Project: HBase > Issue Type: Sub-task >Reporter: Sudeep Sunthankar >Assignee: Sudeep Sunthankar > Attachments: HBASE-16489.HBASE-14850.v1.patch > > > Reading hbase-site.xml is required to read various properties viz. > zookeeper-quorum, client retires etc. We can either use Apache Xerces or > Boost libraries. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
