[jira] [Updated] (HBASE-16651) LRUBlockCache#returnBlock should try return block to Victim Handler L2 cache.
[ https://issues.apache.org/jira/browse/HBASE-16651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-16651: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Thanks for the review Ram. > LRUBlockCache#returnBlock should try return block to Victim Handler L2 cache. > - > > Key: HBASE-16651 > URL: https://issues.apache.org/jira/browse/HBASE-16651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners >Affects Versions: 2.0.0 >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-16651.patch > > > In case of L1 and L2 cache usage with combinedMode = false, L2 is used as a > victim handler cache for L1 cache. When a getBlock() request comes, L1 will > see if block is in it and if not it will try to provide the block from L2 > cache. In such a case, the return block must return the block to L2 cache and > count down the ref count for the block. But right now we just ignore the > returnBlock call in LRUCache -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16651) LRUBlockCache#returnBlock should try return block to Victim Handler L2 cache.
[ https://issues.apache.org/jira/browse/HBASE-16651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-16651: --- Status: Patch Available (was: Open) > LRUBlockCache#returnBlock should try return block to Victim Handler L2 cache. > - > > Key: HBASE-16651 > URL: https://issues.apache.org/jira/browse/HBASE-16651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners >Affects Versions: 2.0.0 >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-16651.patch > > > In case of L1 and L2 cache usage with combinedMode = false, L2 is used as a > victim handler cache for L1 cache. When a getBlock() request comes, L1 will > see if block is in it and if not it will try to provide the block from L2 > cache. In such a case, the return block must return the block to L2 cache and > count down the ref count for the block. But right now we just ignore the > returnBlock call in LRUCache -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16651) LRUBlockCache#returnBlock should try return block to Victim Handler L2 cache.
[ https://issues.apache.org/jira/browse/HBASE-16651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-16651: --- Attachment: HBASE-16651.patch > LRUBlockCache#returnBlock should try return block to Victim Handler L2 cache. > - > > Key: HBASE-16651 > URL: https://issues.apache.org/jira/browse/HBASE-16651 > Project: HBase > Issue Type: Sub-task > Components: regionserver, Scanners >Affects Versions: 2.0.0 >Reporter: Anoop Sam John >Assignee: Anoop Sam John > Fix For: 2.0.0 > > Attachments: HBASE-16651.patch > > > In case of L1 and L2 cache usage with combinedMode = false, L2 is used as a > victim handler cache for L1 cache. When a getBlock() request comes, L1 will > see if block is in it and if not it will try to provide the block from L2 > cache. In such a case, the return block must return the block to L2 cache and > count down the ref count for the block. But right now we just ignore the > returnBlock call in LRUCache -- This message was sent by Atlassian JIRA (v6.3.4#6332)
