[jira] [Updated] (HBASE-16670) Make RpcServer#processRequest logic more robust
[ https://issues.apache.org/jira/browse/HBASE-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-16670: -- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 1.4.0 2.0.0 Status: Resolved (was: Patch Available) Checked the failed UT cases and made sure they are all irrelative to patch here and could pass locally. Pushed commit into master and branch-1. Thanks [~anoop.hbase] and [~chenheng] for review. > Make RpcServer#processRequest logic more robust > --- > > Key: HBASE-16670 > URL: https://issues.apache.org/jira/browse/HBASE-16670 > Project: HBase > Issue Type: Bug >Reporter: Yu Li >Assignee: Yu Li >Priority: Minor > Fix For: 2.0.0, 1.4.0 > > Attachments: HBASE-16670.patch > > > Currently in {{RpcServer#processRequest}}, we will check whether the request > header has parameters but missed handling the abnormal case, so if there's no > param in the header, it will throw NPE like below: > {noformat} > org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(java.io.IOException): > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2269) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:189) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:169) > Caused by: java.lang.NullPointerException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2211) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16670) Make RpcServer#processRequest logic more robust
[ https://issues.apache.org/jira/browse/HBASE-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-16670: -- Status: Patch Available (was: Open) Submit for HadoopQA > Make RpcServer#processRequest logic more robust > --- > > Key: HBASE-16670 > URL: https://issues.apache.org/jira/browse/HBASE-16670 > Project: HBase > Issue Type: Bug >Reporter: Yu Li >Assignee: Yu Li >Priority: Minor > Attachments: HBASE-16670.patch > > > Currently in {{RpcServer#processRequest}}, we will check whether the request > header has parameters but missed handling the abnormal case, so if there's no > param in the header, it will throw NPE like below: > {noformat} > org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(java.io.IOException): > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2269) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:189) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:169) > Caused by: java.lang.NullPointerException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2211) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16670) Make RpcServer#processRequest logic more robust
[ https://issues.apache.org/jira/browse/HBASE-16670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yu Li updated HBASE-16670: -- Attachment: HBASE-16670.patch A straight forward patch > Make RpcServer#processRequest logic more robust > --- > > Key: HBASE-16670 > URL: https://issues.apache.org/jira/browse/HBASE-16670 > Project: HBase > Issue Type: Bug >Reporter: Yu Li >Assignee: Yu Li >Priority: Minor > Attachments: HBASE-16670.patch > > > Currently in {{RpcServer#processRequest}}, we will check whether the request > header has parameters but missed handling the abnormal case, so if there's no > param in the header, it will throw NPE like below: > {noformat} > org.apache.hadoop.hbase.ipc.RemoteWithExtrasException(java.io.IOException): > java.io.IOException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2269) > at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:123) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:189) > at > org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:169) > Caused by: java.lang.NullPointerException > at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2211) > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)