[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Pushed to master. Thanks for the reviews. > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696.patch, > HBASE-16696_1.patch, HBASE-16696_2.patch, HBASE-16696_3.patch > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Attachment: HBASE-16696_3.patch Thanks for the review. This is what will commit then. Changed exception to boolean. > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696.patch, > HBASE-16696_1.patch, HBASE-16696_2.patch, HBASE-16696_3.patch > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Status: Patch Available (was: Open) > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696.patch, > HBASE-16696_1.patch, HBASE-16696_2.patch > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Attachment: HBASE-16696.patch Reattaching the patch. > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696.patch, > HBASE-16696_1.patch, HBASE-16696_2.patch > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Status: Open (was: Patch Available) > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696.patch, > HBASE-16696_1.patch, HBASE-16696_2.patch > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Attachment: HBASE-16696_2.patch Patch that moves the shippedCallback to the try block and also handles the findbug warning by adding a null check before throwing the ScannerResetException. Will commit _2 after QA says fine. > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696_1.patch, > HBASE-16696_2.patch > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Status: Patch Available (was: Open) > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696_1.patch, > HBASE-16696_2.patch > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Status: Open (was: Patch Available) > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696_1.patch > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16696: --- Attachment: (was: build-1639.out) > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696_1.patch > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-16696: --- Attachment: (was: build-1638.out) > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696_1.patch, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Attachment: HBASE-16696_1.patch Patch if the finally is moved inside the try. Am fine with either of the patches. > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, HBASE-16696_1.patch, build-1638.out, > build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Attachment: HBASE-16696.patch Since after HBASE-16604 we are sure that on receiving an exception the entire Scanner is closed and a new scanner is created, we can be sure that if we set the Closedcallback to the RPC context the entire blocks that were used by that failed scan can be released. Previously we were depending on the scan lease expiry to release the blocks that the failed blocks were holding up. Now we need not wait for the lease expiry to trigger in. > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Status: Patch Available (was: Open) > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-16696.patch, build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Description: TestBlockEvictionFromClient consistently fails in master branch. >From existing Jenkins builds, looks like this started with build 1639. See attached Jenkins console logs. Pls refer to this comment https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 for the reason for the test failure. was: TestBlockEvictionFromClient consistently fails in master branch. >From existing Jenkins builds, looks like this started with build 1639. See attached Jenkins console logs. > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. > Pls refer to this comment > https://issues.apache.org/jira/secure/EditComment!default.jspa?id=13004009=15522451 > for the reason for the test failure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Summary: After HBASE-16604 - does not release blocks in case of scanner exception (was: TestBlockEvictionFromClient fails in master branch) > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan > Fix For: 2.0.0 > > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (HBASE-16696) After HBASE-16604 - does not release blocks in case of scanner exception
[ https://issues.apache.org/jira/browse/HBASE-16696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ramkrishna.s.vasudevan updated HBASE-16696: --- Priority: Critical (was: Major) Fix Version/s: 2.0.0 > After HBASE-16604 - does not release blocks in case of scanner exception > > > Key: HBASE-16696 > URL: https://issues.apache.org/jira/browse/HBASE-16696 > Project: HBase > Issue Type: Bug >Reporter: Ted Yu >Assignee: ramkrishna.s.vasudevan >Priority: Critical > Fix For: 2.0.0 > > Attachments: build-1638.out, build-1639.out > > > TestBlockEvictionFromClient consistently fails in master branch. > From existing Jenkins builds, looks like this started with build 1639. > See attached Jenkins console logs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
