[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19437: --- Resolution: Fixed Hadoop Flags: Incompatible change,Reviewed (was: Incompatible change) Status: Resolved (was: Patch Available) > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug > Components: Usability >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-19437.v0.patch, HBASE-19437.v0.patch, > HBASE-19437.v1.patch > > > But the Table#append and #increment can handle the null result...that is an > inconsistent behavior for user. > I have noticed two scenarios that server will return null result to user. > # postAppend/postIncrement return null > # mutation.isReturnResults() is false and > preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null > We should wrap the null to empty result on server side. CP user should throw > Exception rather than return null if they intend to say something is broken. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19437: --- Attachment: HBASE-19437.v1.patch > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug > Components: Usability >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-19437.v0.patch, HBASE-19437.v0.patch, > HBASE-19437.v1.patch > > > But the Table#append and #increment can handle the null result...that is an > inconsistent behavior for user. > I have noticed two scenarios that server will return null result to user. > # postAppend/postIncrement return null > # mutation.isReturnResults() is false and > preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null > We should wrap the null to empty result on server side. CP user should throw > Exception rather than return null if they intend to say something is broken. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19437: --- Release Note: The result from server is changed from null to Result.EMPTY_RESULT when Append/Increment operation can't retrieve any data from server, (was: If Mutation#isReturnResults is false and RegionObserver#preAppendAfterRowLock doesn't return null, the result from server is changed from null to Result.EMPTY_RESULT) > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug > Components: Usability >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-19437.v0.patch, HBASE-19437.v0.patch > > > But the Table#append and #increment can handle the null result...that is an > inconsistent behavior for user. > I have noticed two scenarios that server will return null result to user. > # postAppend/postIncrement return null > # mutation.isReturnResults() is false and > preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null > We should wrap the null to empty result on server side. CP user should throw > Exception rather than return null if they intend to say something is broken. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19437: --- Hadoop Flags: Incompatible change Release Note: If Mutation#isReturnResults is false and RegionObserver#preAppendAfterRowLock doesn't return null, the result from server is changed from null to Result.EMPTY_RESULT > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug > Components: Usability >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-19437.v0.patch, HBASE-19437.v0.patch > > > But the Table#append and #increment can handle the null result...that is an > inconsistent behavior for user. > I have noticed two scenarios that server will return null result to user. > # postAppend/postIncrement return null > # mutation.isReturnResults() is false and > preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null > We should wrap the null to empty result on server side. CP user should throw > Exception rather than return null if they intend to say something is broken. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19437: -- Priority: Critical (was: Major) > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug > Components: Usability >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-19437.v0.patch, HBASE-19437.v0.patch > > > But the Table#append and #increment can handle the null result...that is an > inconsistent behavior for user. > I have noticed two scenarios that server will return null result to user. > # postAppend/postIncrement return null > # mutation.isReturnResults() is false and > preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null > We should wrap the null to empty result on server side. CP user should throw > Exception rather than return null if they intend to say something is broken. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19437: -- Component/s: Usability > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug > Components: Usability >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-19437.v0.patch, HBASE-19437.v0.patch > > > But the Table#append and #increment can handle the null result...that is an > inconsistent behavior for user. > I have noticed two scenarios that server will return null result to user. > # postAppend/postIncrement return null > # mutation.isReturnResults() is false and > preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null > We should wrap the null to empty result on server side. CP user should throw > Exception rather than return null if they intend to say something is broken. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19437: --- Attachment: HBASE-19437.v0.patch retry > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-19437.v0.patch, HBASE-19437.v0.patch > > > But the Table#append and #increment can handle the null result...that is an > inconsistent behavior for user. > I have noticed two scenarios that server will return null result to user. > # postAppend/postIncrement return null > # mutation.isReturnResults() is false and > preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null > We should wrap the null to empty result on server side. CP user should throw > Exception rather than return null if they intend to say something is broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19437: --- Attachment: HBASE-19437.v0.patch > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-19437.v0.patch > > > But the Table#append and #increment can handle the null result...that is an > inconsistent behavior for user. > I have noticed two scenarios that server will return null result to user. > # postAppend/postIncrement return null > # mutation.isReturnResults() is false and > preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null > We should wrap the null to empty result on server side. CP user should throw > Exception rather than return null if they intend to say something is broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19437: --- Status: Patch Available (was: Open) > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > Attachments: HBASE-19437.v0.patch > > > But the Table#append and #increment can handle the null result...that is an > inconsistent behavior for user. > I have noticed two scenarios that server will return null result to user. > # postAppend/postIncrement return null > # mutation.isReturnResults() is false and > preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null > We should wrap the null to empty result on server side. CP user should throw > Exception rather than return null if they intend to say something is broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19437: --- Description: But the Table#append and #increment can handle the null result...that is an inconsistent behavior for user. I have noticed two scenarios that server will return null result to user. # postAppend/postIncrement return null # mutation.isReturnResults() is false and preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null We should wrap the null to empty result on server side. CP user should throw Exception rather than return null if they intend to say something is broken. was: The null from postAppend/postIncrement sparks inconsistent behavior. The Table#append and #increment can handle the null result but the batch operation throws IllegalStateException. We should wrap the null from postAppend/postIncrement to empty result since cp user should throw IOException rather than return null if they intend to say something is broken. > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > > But the Table#append and #increment can handle the null result...that is an > inconsistent behavior for user. > I have noticed two scenarios that server will return null result to user. > # postAppend/postIncrement return null > # mutation.isReturnResults() is false and > preIncrementAfterRowLock/preAppendAfterRowLock doesn't return null > We should wrap the null to empty result on server side. CP user should throw > Exception rather than return null if they intend to say something is broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19437) Batch operation can't handle the null result for Append/Increment
[ https://issues.apache.org/jira/browse/HBASE-19437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated HBASE-19437: --- Summary: Batch operation can't handle the null result for Append/Increment (was: Wrap the null result from postAppend/postIncrement ) > Batch operation can't handle the null result for Append/Increment > - > > Key: HBASE-19437 > URL: https://issues.apache.org/jira/browse/HBASE-19437 > Project: HBase > Issue Type: Bug >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai > Fix For: 2.0.0 > > > The null from postAppend/postIncrement sparks inconsistent behavior. The > Table#append and #increment can handle the null result but the batch > operation throws IllegalStateException. > We should wrap the null from postAppend/postIncrement to empty result since > cp user should throw IOException rather than return null if they intend to > say something is broken. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
