[jira] [Updated] (HBASE-19678) HBase Admin security capabilities should be represented as a Set
[ https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19678: -- Fix Version/s: (was: 2.0.0) > HBase Admin security capabilities should be represented as a Set > > > Key: HBASE-19678 > URL: https://issues.apache.org/jira/browse/HBASE-19678 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > > {code:title=org.apache.hadoop.hbase.client.Admin} > /** >* Return the set of supported security capabilities. >* @throws IOException >* @throws UnsupportedOperationException >*/ > List getSecurityCapabilities() throws IOException; > {code} > The comment says a "set" but it returns a List. A Set would be the most > appropriate data structure here, an immutable one perhaps, because the code > that interacts with it looks up information using the _contains_ method which > would be served well by a Set. Please change this interface to return a Set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19678) HBase Admin security capabilities should be represented as a Set
[ https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19678: -- Fix Version/s: (was: 2.0.0-beta-2) 2.0.0 > HBase Admin security capabilities should be represented as a Set > > > Key: HBASE-19678 > URL: https://issues.apache.org/jira/browse/HBASE-19678 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Fix For: 2.0.0 > > > {code:title=org.apache.hadoop.hbase.client.Admin} > /** >* Return the set of supported security capabilities. >* @throws IOException >* @throws UnsupportedOperationException >*/ > List getSecurityCapabilities() throws IOException; > {code} > The comment says a "set" but it returns a List. A Set would be the most > appropriate data structure here, an immutable one perhaps, because the code > that interacts with it looks up information using the _contains_ method which > would be served well by a Set. Please change this interface to return a Set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19678) HBase Admin security capabilities should be represented as a Set
[ https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Appy updated HBASE-19678: - Attachment: (was: HBASE-19678.1.patch) > HBase Admin security capabilities should be represented as a Set > > > Key: HBASE-19678 > URL: https://issues.apache.org/jira/browse/HBASE-19678 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Fix For: 2.0.0-beta-2 > > > {code:title=org.apache.hadoop.hbase.client.Admin} > /** >* Return the set of supported security capabilities. >* @throws IOException >* @throws UnsupportedOperationException >*/ > List getSecurityCapabilities() throws IOException; > {code} > The comment says a "set" but it returns a List. A Set would be the most > appropriate data structure here, an immutable one perhaps, because the code > that interacts with it looks up information using the _contains_ method which > would be served well by a Set. Please change this interface to return a Set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19678) HBase Admin security capabilities should be represented as a Set
[ https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19678: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 2.0.0-beta-2 Status: Resolved (was: Patch Available) Thanks for the patch, BELUGA > HBase Admin security capabilities should be represented as a Set > > > Key: HBASE-19678 > URL: https://issues.apache.org/jira/browse/HBASE-19678 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19678.1.patch > > > {code:title=org.apache.hadoop.hbase.client.Admin} > /** >* Return the set of supported security capabilities. >* @throws IOException >* @throws UnsupportedOperationException >*/ > List getSecurityCapabilities() throws IOException; > {code} > The comment says a "set" but it returns a List. A Set would be the most > appropriate data structure here, an immutable one perhaps, because the code > that interacts with it looks up information using the _contains_ method which > would be served well by a Set. Please change this interface to return a Set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19678) HBase Admin security capabilities should be represented as a Set
[ https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-19678: --- Summary: HBase Admin security capabilities should be represented as a Set (was: HBase Admin Security Capabilities Should Be Represented as a Set) > HBase Admin security capabilities should be represented as a Set > > > Key: HBASE-19678 > URL: https://issues.apache.org/jira/browse/HBASE-19678 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HBASE-19678.1.patch > > > {code:title=org.apache.hadoop.hbase.client.Admin} > /** >* Return the set of supported security capabilities. >* @throws IOException >* @throws UnsupportedOperationException >*/ > List getSecurityCapabilities() throws IOException; > {code} > The comment says a "set" but it returns a List. A Set would be the most > appropriate data structure here, an immutable one perhaps, because the code > that interacts with it looks up information using the _contains_ method which > would be served well by a Set. Please change this interface to return a Set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19678) HBase Admin Security Capabilities Should Be Represented as a Set
[ https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19678: Status: Patch Available (was: Open) > HBase Admin Security Capabilities Should Be Represented as a Set > > > Key: HBASE-19678 > URL: https://issues.apache.org/jira/browse/HBASE-19678 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HBASE-19678.1.patch > > > {code:title=org.apache.hadoop.hbase.client.Admin} > /** >* Return the set of supported security capabilities. >* @throws IOException >* @throws UnsupportedOperationException >*/ > List getSecurityCapabilities() throws IOException; > {code} > The comment says a "set" but it returns a List. A Set would be the most > appropriate data structure here, an immutable one perhaps, because the code > that interacts with it looks up information using the _contains_ method which > would be served well by a Set. Please change this interface to return a Set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-19678) HBase Admin Security Capabilities Should Be Represented as a Set
[ https://issues.apache.org/jira/browse/HBASE-19678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BELUGA BEHR updated HBASE-19678: Attachment: HBASE-19678.1.patch > HBase Admin Security Capabilities Should Be Represented as a Set > > > Key: HBASE-19678 > URL: https://issues.apache.org/jira/browse/HBASE-19678 > Project: HBase > Issue Type: Improvement > Components: hbase >Affects Versions: 3.0.0 >Reporter: BELUGA BEHR >Assignee: BELUGA BEHR >Priority: Minor > Attachments: HBASE-19678.1.patch > > > {code:title=org.apache.hadoop.hbase.client.Admin} > /** >* Return the set of supported security capabilities. >* @throws IOException >* @throws UnsupportedOperationException >*/ > List getSecurityCapabilities() throws IOException; > {code} > The comment says a "set" but it returns a List. A Set would be the most > appropriate data structure here, an immutable one perhaps, because the code > that interacts with it looks up information using the _contains_ method which > would be served well by a Set. Please change this interface to return a Set. -- This message was sent by Atlassian JIRA (v6.4.14#64029)