[jira] [Updated] (HBASE-19922) ProtobufUtils::PRIMITIVES is unused
[ https://issues.apache.org/jira/browse/HBASE-19922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19922: -- Resolution: Fixed Fix Version/s: (was: 2.0) 2.0.0-beta-2 Status: Resolved (was: Patch Available) Thanks for review, [~chia7712]. Error looks like a bad snapshot for hbase-thrift, I don't think it's related. If it turns out to be an issue here let's plan to revert aggressively. > ProtobufUtils::PRIMITIVES is unused > --- > > Key: HBASE-19922 > URL: https://issues.apache.org/jira/browse/HBASE-19922 > Project: HBase > Issue Type: Task > Components: Protobufs >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Fix For: 2.0.0-beta-2 > > Attachments: HBASE-19922.patch, HBASE-19922.v2.patch > > > It looks like ProtobufUtils::PRIMITIVES is never read in both the shaded and > non-shaded versions of the class. Is it safe to remove? > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java#L128 > We populate the map in a static initializer but never read any values from > it... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19922) ProtobufUtils::PRIMITIVES is unused
[ https://issues.apache.org/jira/browse/HBASE-19922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19922: -- Attachment: HBASE-19922.v2.patch > ProtobufUtils::PRIMITIVES is unused > --- > > Key: HBASE-19922 > URL: https://issues.apache.org/jira/browse/HBASE-19922 > Project: HBase > Issue Type: Task > Components: Protobufs >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Fix For: 2.0 > > Attachments: HBASE-19922.patch, HBASE-19922.v2.patch > > > It looks like ProtobufUtils::PRIMITIVES is never read in both the shaded and > non-shaded versions of the class. Is it safe to remove? > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java#L128 > We populate the map in a static initializer but never read any values from > it... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19922) ProtobufUtils::PRIMITIVES is unused
[ https://issues.apache.org/jira/browse/HBASE-19922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19922: -- Assignee: Mike Drob Fix Version/s: 2.0 Status: Patch Available (was: Open) > ProtobufUtils::PRIMITIVES is unused > --- > > Key: HBASE-19922 > URL: https://issues.apache.org/jira/browse/HBASE-19922 > Project: HBase > Issue Type: Task > Components: Protobufs >Reporter: Mike Drob >Assignee: Mike Drob >Priority: Major > Fix For: 2.0 > > Attachments: HBASE-19922.patch > > > It looks like ProtobufUtils::PRIMITIVES is never read in both the shaded and > non-shaded versions of the class. Is it safe to remove? > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java#L128 > We populate the map in a static initializer but never read any values from > it... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19922) ProtobufUtils::PRIMITIVES is unused
[ https://issues.apache.org/jira/browse/HBASE-19922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-19922: -- Attachment: HBASE-19922.patch > ProtobufUtils::PRIMITIVES is unused > --- > > Key: HBASE-19922 > URL: https://issues.apache.org/jira/browse/HBASE-19922 > Project: HBase > Issue Type: Task > Components: Protobufs >Reporter: Mike Drob >Priority: Major > Fix For: 2.0 > > Attachments: HBASE-19922.patch > > > It looks like ProtobufUtils::PRIMITIVES is never read in both the shaded and > non-shaded versions of the class. Is it safe to remove? > https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java#L128 > We populate the map in a static initializer but never read any values from > it... -- This message was sent by Atlassian JIRA (v7.6.3#76005)