[jira] [Updated] (HBASE-19979) ReplicationSyncUp tool may leak Zookeeper connection
[ https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-19979: --- Fix Version/s: (was: 1.5.0) > ReplicationSyncUp tool may leak Zookeeper connection > > > Key: HBASE-19979 > URL: https://issues.apache.org/jira/browse/HBASE-19979 > Project: HBase > Issue Type: Bug > Components: Replication >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Major > Fix For: 1.3.2, 2.0.0-beta-2, 1.4.2, 2.0.0 > > Attachments: HBASE-19979-branch-1.001.patch, HBASE-19979.patch > > > ReplicationSyncUp tool may leak Zookeeper connection in the following code > snippet, > {code} > try { > int numberOfOldSource = 1; // default wait once > while (numberOfOldSource > 0) { > Thread.sleep(SLEEP_TIME); > numberOfOldSource = manager.getOldSources().size(); > } > } catch (InterruptedException e) { > System.err.println("didn't wait long enough:" + e); > return (-1); > } > manager.join(); > zkw.close(); > {code} > ZooKeeperWatcher will not be closed in case of InterruptedException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19979) ReplicationSyncUp tool may leak Zookeeper connection
[ https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19979: -- Fix Version/s: 1.3.2 > ReplicationSyncUp tool may leak Zookeeper connection > > > Key: HBASE-19979 > URL: https://issues.apache.org/jira/browse/HBASE-19979 > Project: HBase > Issue Type: Bug > Components: Replication >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Major > Fix For: 1.3.2, 1.5.0, 2.0.0-beta-2, 1.4.2 > > Attachments: HBASE-19979-branch-1.001.patch, HBASE-19979.patch > > > ReplicationSyncUp tool may leak Zookeeper connection in the following code > snippet, > {code} > try { > int numberOfOldSource = 1; // default wait once > while (numberOfOldSource > 0) { > Thread.sleep(SLEEP_TIME); > numberOfOldSource = manager.getOldSources().size(); > } > } catch (InterruptedException e) { > System.err.println("didn't wait long enough:" + e); > return (-1); > } > manager.join(); > zkw.close(); > {code} > ZooKeeperWatcher will not be closed in case of InterruptedException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19979) ReplicationSyncUp tool may leak Zookeeper connection
[ https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19979: -- Resolution: Fixed Hadoop Flags: Reviewed Status: Resolved (was: Patch Available) Nice one [~pankaj2461] Good find. Pushed to branch-2 and master. Looks like [~yuzhih...@gmail.com] pushed to branch-1.4 and branch-1 (Again, please use --author param so you can accredit the patch properly Ted Yu). > ReplicationSyncUp tool may leak Zookeeper connection > > > Key: HBASE-19979 > URL: https://issues.apache.org/jira/browse/HBASE-19979 > Project: HBase > Issue Type: Bug > Components: Replication >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Major > Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2 > > Attachments: HBASE-19979-branch-1.001.patch, HBASE-19979.patch > > > ReplicationSyncUp tool may leak Zookeeper connection in the following code > snippet, > {code} > try { > int numberOfOldSource = 1; // default wait once > while (numberOfOldSource > 0) { > Thread.sleep(SLEEP_TIME); > numberOfOldSource = manager.getOldSources().size(); > } > } catch (InterruptedException e) { > System.err.println("didn't wait long enough:" + e); > return (-1); > } > manager.join(); > zkw.close(); > {code} > ZooKeeperWatcher will not be closed in case of InterruptedException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19979) ReplicationSyncUp tool may leak Zookeeper connection
[ https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-19979: -- Fix Version/s: 1.4.2 > ReplicationSyncUp tool may leak Zookeeper connection > > > Key: HBASE-19979 > URL: https://issues.apache.org/jira/browse/HBASE-19979 > Project: HBase > Issue Type: Bug > Components: Replication >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Major > Fix For: 1.5.0, 2.0.0-beta-2, 1.4.2 > > Attachments: HBASE-19979-branch-1.001.patch, HBASE-19979.patch > > > ReplicationSyncUp tool may leak Zookeeper connection in the following code > snippet, > {code} > try { > int numberOfOldSource = 1; // default wait once > while (numberOfOldSource > 0) { > Thread.sleep(SLEEP_TIME); > numberOfOldSource = manager.getOldSources().size(); > } > } catch (InterruptedException e) { > System.err.println("didn't wait long enough:" + e); > return (-1); > } > manager.join(); > zkw.close(); > {code} > ZooKeeperWatcher will not be closed in case of InterruptedException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19979) ReplicationSyncUp tool may leak Zookeeper connection
[ https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-19979: - Fix Version/s: 2.0.0-beta-2 1.5.0 > ReplicationSyncUp tool may leak Zookeeper connection > > > Key: HBASE-19979 > URL: https://issues.apache.org/jira/browse/HBASE-19979 > Project: HBase > Issue Type: Bug > Components: Replication >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Major > Fix For: 1.5.0, 2.0.0-beta-2 > > Attachments: HBASE-19979-branch-1.001.patch, HBASE-19979.patch > > > ReplicationSyncUp tool may leak Zookeeper connection in the following code > snippet, > {code} > try { > int numberOfOldSource = 1; // default wait once > while (numberOfOldSource > 0) { > Thread.sleep(SLEEP_TIME); > numberOfOldSource = manager.getOldSources().size(); > } > } catch (InterruptedException e) { > System.err.println("didn't wait long enough:" + e); > return (-1); > } > manager.join(); > zkw.close(); > {code} > ZooKeeperWatcher will not be closed in case of InterruptedException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19979) ReplicationSyncUp tool may leak Zookeeper connection
[ https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-19979: - Affects Version/s: (was: 1.5.0) > ReplicationSyncUp tool may leak Zookeeper connection > > > Key: HBASE-19979 > URL: https://issues.apache.org/jira/browse/HBASE-19979 > Project: HBase > Issue Type: Bug > Components: Replication >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Major > Attachments: HBASE-19979-branch-1.001.patch, HBASE-19979.patch > > > ReplicationSyncUp tool may leak Zookeeper connection in the following code > snippet, > {code} > try { > int numberOfOldSource = 1; // default wait once > while (numberOfOldSource > 0) { > Thread.sleep(SLEEP_TIME); > numberOfOldSource = manager.getOldSources().size(); > } > } catch (InterruptedException e) { > System.err.println("didn't wait long enough:" + e); > return (-1); > } > manager.join(); > zkw.close(); > {code} > ZooKeeperWatcher will not be closed in case of InterruptedException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19979) ReplicationSyncUp tool may leak Zookeeper connection
[ https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-19979: - Attachment: HBASE-19979.patch > ReplicationSyncUp tool may leak Zookeeper connection > > > Key: HBASE-19979 > URL: https://issues.apache.org/jira/browse/HBASE-19979 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.5.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Major > Attachments: HBASE-19979-branch-1.001.patch, HBASE-19979.patch > > > ReplicationSyncUp tool may leak Zookeeper connection in the following code > snippet, > {code} > try { > int numberOfOldSource = 1; // default wait once > while (numberOfOldSource > 0) { > Thread.sleep(SLEEP_TIME); > numberOfOldSource = manager.getOldSources().size(); > } > } catch (InterruptedException e) { > System.err.println("didn't wait long enough:" + e); > return (-1); > } > manager.join(); > zkw.close(); > {code} > ZooKeeperWatcher will not be closed in case of InterruptedException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19979) ReplicationSyncUp tool may leak Zookeeper connection
[ https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-19979: - Affects Version/s: 1.5.0 Status: Patch Available (was: Open) Simple patch, please review. > ReplicationSyncUp tool may leak Zookeeper connection > > > Key: HBASE-19979 > URL: https://issues.apache.org/jira/browse/HBASE-19979 > Project: HBase > Issue Type: Bug > Components: Replication >Affects Versions: 1.5.0 >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Major > Attachments: HBASE-19979-branch-1.001.patch > > > ReplicationSyncUp tool may leak Zookeeper connection in the following code > snippet, > {code} > try { > int numberOfOldSource = 1; // default wait once > while (numberOfOldSource > 0) { > Thread.sleep(SLEEP_TIME); > numberOfOldSource = manager.getOldSources().size(); > } > } catch (InterruptedException e) { > System.err.println("didn't wait long enough:" + e); > return (-1); > } > manager.join(); > zkw.close(); > {code} > ZooKeeperWatcher will not be closed in case of InterruptedException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-19979) ReplicationSyncUp tool may leak Zookeeper connection
[ https://issues.apache.org/jira/browse/HBASE-19979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-19979: - Attachment: HBASE-19979-branch-1.001.patch > ReplicationSyncUp tool may leak Zookeeper connection > > > Key: HBASE-19979 > URL: https://issues.apache.org/jira/browse/HBASE-19979 > Project: HBase > Issue Type: Bug > Components: Replication >Reporter: Pankaj Kumar >Assignee: Pankaj Kumar >Priority: Major > Attachments: HBASE-19979-branch-1.001.patch > > > ReplicationSyncUp tool may leak Zookeeper connection in the following code > snippet, > {code} > try { > int numberOfOldSource = 1; // default wait once > while (numberOfOldSource > 0) { > Thread.sleep(SLEEP_TIME); > numberOfOldSource = manager.getOldSources().size(); > } > } catch (InterruptedException e) { > System.err.println("didn't wait long enough:" + e); > return (-1); > } > manager.join(); > zkw.close(); > {code} > ZooKeeperWatcher will not be closed in case of InterruptedException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)