[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Duo Zhang updated HBASE-20625:
--
Fix Version/s: 2.2.0
2.1.0
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0, 2.1.0, 2.2.0
>
> Attachments: HBASE-20625.branch-2.001.patch,
> HBASE-20625.master.001.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.003.patch,
> HBASE-20625.master.004.patch, HBASE-20625.master.005.patch,
> HBASE-20625.master.006.patch, HBASE-20625.master.007.patch,
> HBASE-20625.master.008.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-20625:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Pushed to master and branch-2. Thanks [~tianjingyun] for contributing.
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.branch-2.001.patch,
> HBASE-20625.master.001.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.003.patch,
> HBASE-20625.master.004.patch, HBASE-20625.master.005.patch,
> HBASE-20625.master.006.patch, HBASE-20625.master.007.patch,
> HBASE-20625.master.008.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: HBASE-20625.master.008.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.branch-2.001.patch,
> HBASE-20625.master.001.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.003.patch,
> HBASE-20625.master.004.patch, HBASE-20625.master.005.patch,
> HBASE-20625.master.006.patch, HBASE-20625.master.007.patch,
> HBASE-20625.master.008.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: HBASE-20625.master.007.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.branch-2.001.patch,
> HBASE-20625.master.001.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.003.patch,
> HBASE-20625.master.004.patch, HBASE-20625.master.005.patch,
> HBASE-20625.master.006.patch, HBASE-20625.master.007.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: HBASE-20625.branch-2.001.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.branch-2.001.patch,
> HBASE-20625.master.001.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.003.patch,
> HBASE-20625.master.004.patch, HBASE-20625.master.005.patch,
> HBASE-20625.master.006.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: (was: HBASE-20625.branch-2.001.patch)
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.master.001.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.003.patch, HBASE-20625.master.004.patch,
> HBASE-20625.master.005.patch, HBASE-20625.master.006.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: HBASE-20625.branch-2.001.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.branch-2.001.patch,
> HBASE-20625.master.001.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.003.patch,
> HBASE-20625.master.004.patch, HBASE-20625.master.005.patch,
> HBASE-20625.master.006.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: HBASE-20625.master.006.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.master.001.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.003.patch, HBASE-20625.master.004.patch,
> HBASE-20625.master.005.patch, HBASE-20625.master.006.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: HBASE-20625.master.005.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.master.001.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.003.patch, HBASE-20625.master.004.patch,
> HBASE-20625.master.005.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: HBASE-20625.master.004.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.master.001.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.003.patch, HBASE-20625.master.004.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: HBASE-20625.master.003.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.master.001.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.002.patch,
> HBASE-20625.master.003.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guanghao Zhang updated HBASE-20625:
---
Attachment: HBASE-20625.master.002.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.master.001.patch,
> HBASE-20625.master.002.patch, HBASE-20625.master.002.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: HBASE-20625.master.002.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.master.001.patch,
> HBASE-20625.master.002.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Status: Patch Available (was: Open)
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.master.001.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (HBASE-20625) refactor some WALCellCodec related code
[
https://issues.apache.org/jira/browse/HBASE-20625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jingyun Tian updated HBASE-20625:
-
Attachment: HBASE-20625.master.001.patch
> refactor some WALCellCodec related code
> ---
>
> Key: HBASE-20625
> URL: https://issues.apache.org/jira/browse/HBASE-20625
> Project: HBase
> Issue Type: Improvement
> Components: wal
>Affects Versions: 2.0.0
>Reporter: Jingyun Tian
>Assignee: Jingyun Tian
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: HBASE-20625.master.001.patch
>
>
> Currently I'm working on export HLog to another FileSystem, then I found the
> code of WALCellCodec and its related classes is not that clean. And there
> are several TODOs. Thus I tried to refactor the code based one these TODOs.
> e.g.
> {code}
> // TODO: it sucks that compression context is in WAL.Entry. It'd be nice if
> it was here.
> // Dictionary could be gotten by enum; initially, based on enum,
> context would create
> // an array of dictionaries.
> static class BaosAndCompressor extends ByteArrayOutputStream implements
> ByteStringCompressor {
> public ByteString toByteString() {
> // We need this copy to create the ByteString as the byte[] 'buf' is
> not immutable. We reuse
> // them.
> return ByteString.copyFrom(this.buf, 0, this.count);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
