[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21175: --- Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available) Thanks for the patch, Artem. > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Fix For: 3.0.0 > > Attachments: HBASE-21175.v01.patch, HBASE-21175.v04.patch, > HBASE-21175.v05.patch, HBASE-21175.v07.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Attachment: HBASE-21175.v07.patch > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v04.patch, > HBASE-21175.v05.patch, HBASE-21175.v07.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Status: Patch Available (was: Open) [~yuzhih...@gmail.com] v.07 addresses all previous concerns, compiles and test passes locally. > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v04.patch, > HBASE-21175.v05.patch, HBASE-21175.v07.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Attachment: (was: HBASE-21175.v06.patch) > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v04.patch, > HBASE-21175.v05.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Status: Open (was: Patch Available) > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v04.patch, > HBASE-21175.v05.patch, HBASE-21175.v06.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Attachment: HBASE-21175.v06.patch > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v04.patch, > HBASE-21175.v05.patch, HBASE-21175.v06.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Attachment: HBASE-21175.v05.patch > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v04.patch, > HBASE-21175.v05.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Attachment: HBASE-21175.v04.patch > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v04.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Attachment: (was: HBASE-21175.v03.patch) > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v04.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Status: Patch Available (was: Open) [~yuzhih...@gmail.com] please review > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v04.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Status: Open (was: Patch Available) > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v03.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Status: Patch Available (was: Open) [~yuzhih...@gmail.com] please review > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v03.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Attachment: HBASE-21175.v03.patch > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch, HBASE-21175.v03.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Status: Open (was: Patch Available) > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Status: Patch Available (was: Open) > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Ervits updated HBASE-21175: - Attachment: HBASE-21175.v01.patch > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Assignee: Artem Ervits >Priority: Minor > Labels: snapshot > Attachments: HBASE-21175.v01.patch > > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (HBASE-21175) Partially initialized SnapshotHFileCleaner leads to NPE during TestHFileArchiving
[ https://issues.apache.org/jira/browse/HBASE-21175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated HBASE-21175: --- Labels: snapshot (was: ) > Partially initialized SnapshotHFileCleaner leads to NPE during > TestHFileArchiving > - > > Key: HBASE-21175 > URL: https://issues.apache.org/jira/browse/HBASE-21175 > Project: HBase > Issue Type: Test >Reporter: Ted Yu >Priority: Minor > Labels: snapshot > > TestHFileArchiving#testCleaningRace creates HFileCleaner instance within the > test. > When SnapshotHFileCleaner.init() is called, there is no master parameter > passed in {{params}}. > When the chore runs the cleaner during the test, NPE comes out of this line > in getDeletableFiles(): > {code} > return cache.getUnreferencedFiles(files, master.getSnapshotManager()); > {code} > since master is null. > We should either check for the null master or, pass master instance properly > when constructing the cleaner instance. -- This message was sent by Atlassian JIRA (v7.6.3#76005)