[jira] [Updated] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.

2012-04-17 Thread Elliott Clark (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-5788:
-

Attachment: HBASE-5788-3.patch

Lines should all be  100.

Added comments on RegionMetricsStorage.

Made data in RegionMetricsStorage private with public getters (tests require it 
to be public).


 Move Dynamic Metrics storage off of HRegion.
 

 Key: HBASE-5788
 URL: https://issues.apache.org/jira/browse/HBASE-5788
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Minor
 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, 
 HBASE-5788-2.patch, HBASE-5788-3.patch


 HRegion right now has the responsibility of storing static counts and latency 
 numbers for use by the metrics package.  Since these maps are incremented and 
 set from lots of places it makes adding functionality hard.
  
 So move the metrics functionality into SchemaMetrics making it more than just 
 a class for naming.  The next step will be to simplify the api exposed so 
 that using it will be easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.

2012-04-17 Thread Elliott Clark (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-5788:
-

Attachment: HBASE-5788-4.patch

Add @InterfaceAudience.Private to the new class.

 Move Dynamic Metrics storage off of HRegion.
 

 Key: HBASE-5788
 URL: https://issues.apache.org/jira/browse/HBASE-5788
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Minor
 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, 
 HBASE-5788-2.patch, HBASE-5788-3.patch, HBASE-5788-4.patch


 HRegion right now has the responsibility of storing static counts and latency 
 numbers for use by the metrics package.  Since these maps are incremented and 
 set from lots of places it makes adding functionality hard.
  
 So move the metrics functionality into SchemaMetrics making it more than just 
 a class for naming.  The next step will be to simplify the api exposed so 
 that using it will be easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.

2012-04-17 Thread stack (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5788:
-

Hadoop Flags: Reviewed
  Status: Patch Available  (was: Open)

lgtm

Trying against hadoopqa

 Move Dynamic Metrics storage off of HRegion.
 

 Key: HBASE-5788
 URL: https://issues.apache.org/jira/browse/HBASE-5788
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Minor
 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, 
 HBASE-5788-2.patch, HBASE-5788-3.patch, HBASE-5788-4.patch


 HRegion right now has the responsibility of storing static counts and latency 
 numbers for use by the metrics package.  Since these maps are incremented and 
 set from lots of places it makes adding functionality hard.
  
 So move the metrics functionality into SchemaMetrics making it more than just 
 a class for naming.  The next step will be to simplify the api exposed so 
 that using it will be easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.

2012-04-17 Thread stack (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stack updated HBASE-5788:
-

   Resolution: Fixed
Fix Version/s: 0.96.0
   Status: Resolved  (was: Patch Available)

Applied to Trunk (Just TestReplication failed... which seems unrelated).  
Thanks for the patch Elliott.

 Move Dynamic Metrics storage off of HRegion.
 

 Key: HBASE-5788
 URL: https://issues.apache.org/jira/browse/HBASE-5788
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Minor
 Fix For: 0.96.0

 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, 
 HBASE-5788-2.patch, HBASE-5788-3.patch, HBASE-5788-4.patch


 HRegion right now has the responsibility of storing static counts and latency 
 numbers for use by the metrics package.  Since these maps are incremented and 
 set from lots of places it makes adding functionality hard.
  
 So move the metrics functionality into SchemaMetrics making it more than just 
 a class for naming.  The next step will be to simplify the api exposed so 
 that using it will be easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.

2012-04-16 Thread Elliott Clark (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-5788:
-

Attachment: HBASE-5788-1.patch

Better version.  SchemaMetrics wasn't the right place to put it.  While it does 
a lot of the interaction there are lots of other places so a static 
MetricsStorage seems better.

 Move Dynamic Metrics storage off of HRegion.
 

 Key: HBASE-5788
 URL: https://issues.apache.org/jira/browse/HBASE-5788
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Minor
 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch


 HRegion right now has the responsibility of storing static counts and latency 
 numbers for use by the metrics package.  Since these maps are incremented and 
 set from lots of places it makes adding functionality hard.
  
 So move the metrics functionality into SchemaMetrics making it more than just 
 a class for naming.  The next step will be to simplify the api exposed so 
 that using it will be easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.

2012-04-16 Thread Elliott Clark (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-5788:
-

Attachment: HBASE-5788-2.patch

Added header to new file.

 Move Dynamic Metrics storage off of HRegion.
 

 Key: HBASE-5788
 URL: https://issues.apache.org/jira/browse/HBASE-5788
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Minor
 Attachments: HBASE-5788-0.patch, HBASE-5788-1.patch, 
 HBASE-5788-2.patch


 HRegion right now has the responsibility of storing static counts and latency 
 numbers for use by the metrics package.  Since these maps are incremented and 
 set from lots of places it makes adding functionality hard.
  
 So move the metrics functionality into SchemaMetrics making it more than just 
 a class for naming.  The next step will be to simplify the api exposed so 
 that using it will be easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (HBASE-5788) Move Dynamic Metrics storage off of HRegion.

2012-04-13 Thread Elliott Clark (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/HBASE-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Elliott Clark updated HBASE-5788:
-

Attachment: HBASE-5788-0.patch

 Move Dynamic Metrics storage off of HRegion.
 

 Key: HBASE-5788
 URL: https://issues.apache.org/jira/browse/HBASE-5788
 Project: HBase
  Issue Type: Improvement
  Components: regionserver
Reporter: Elliott Clark
Assignee: Elliott Clark
Priority: Minor
 Attachments: HBASE-5788-0.patch


 HRegion right now has the responsibility of storing static counts and latency 
 numbers for use by the metrics package.  Since these maps are incremented and 
 set from lots of places it makes adding functionality hard.
  
 So move the metrics functionality into SchemaMetrics making it more than just 
 a class for naming.  The next step will be to simplify the api exposed so 
 that using it will be easier.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira