[jira] [Updated] (HBASE-6407) Investigate moving to DI (guice) framework for plugin arch.
[ https://issues.apache.org/jira/browse/HBASE-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-6407: - Resolution: Won't Fix Status: Resolved (was: Patch Available) Adding this with metrics is too much code. After 0.96 is branched we can come back to Guice and start the process slowly, as splitting this patch got too hard. Investigate moving to DI (guice) framework for plugin arch. --- Key: HBASE-6407 URL: https://issues.apache.org/jira/browse/HBASE-6407 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6407-1.patch, HBASE-6407-2.patch, HBASE-6407-3.patch, HBASE-6407-4.patch, HBASE-6407-5.patch, HBASE-6407-6.patch Investigate using Guice to inject the correct compat object provided by compat plugins -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6407) Investigate moving to DI (guice) framework for plugin arch.
[ https://issues.apache.org/jira/browse/HBASE-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-6407: - Attachment: HBASE-6407-6.patch Rebase on master. (I'll also post this to rb) Looks like there are two issues left. One with mapred and one with Co-processor class loading. I think the mapred one should be fixed soon, the co-processor one might cause me to remove coprocessor host from guice until I figure it out. Investigate moving to DI (guice) framework for plugin arch. --- Key: HBASE-6407 URL: https://issues.apache.org/jira/browse/HBASE-6407 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6407-1.patch, HBASE-6407-2.patch, HBASE-6407-3.patch, HBASE-6407-4.patch, HBASE-6407-5.patch, HBASE-6407-6.patch Investigate using Guice to inject the correct compat object provided by compat plugins -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6407) Investigate moving to DI (guice) framework for plugin arch.
[ https://issues.apache.org/jira/browse/HBASE-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-6407: - Attachment: HBASE-6407-5.patch Fixed some tests, and showed how to mock up some more of the internal of HRegionServer. Investigate moving to DI (guice) framework for plugin arch. --- Key: HBASE-6407 URL: https://issues.apache.org/jira/browse/HBASE-6407 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6407-1.patch, HBASE-6407-2.patch, HBASE-6407-3.patch, HBASE-6407-4.patch, HBASE-6407-5.patch Investigate using Guice to inject the correct compat object provided by compat plugins -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6407) Investigate moving to DI (guice) framework for plugin arch.
[ https://issues.apache.org/jira/browse/HBASE-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-6407: - Status: Patch Available (was: Open) Investigate moving to DI (guice) framework for plugin arch. --- Key: HBASE-6407 URL: https://issues.apache.org/jira/browse/HBASE-6407 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6407-1.patch, HBASE-6407-2.patch, HBASE-6407-3.patch, HBASE-6407-4.patch, HBASE-6407-5.patch Investigate using Guice to inject the correct compat object provided by compat plugins -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6407) Investigate moving to DI (guice) framework for plugin arch.
[ https://issues.apache.org/jira/browse/HBASE-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-6407: - Attachment: HBASE-6407-4.patch There are still a lot of things that aren't Guice'd but the patch works. Added more explicit dependencies on Guice Moved HRegion and HMaster to a factory that takes in a configuration. Local clusters were too big of an issue where sometimes the conf needed to be copied and other times it needed to stay the same. Added JavaDocs for the factory classes. Removed the CompatibilitySingletoneFactory as this is it's replacement. Continued work on Guicify things. I have one test that I need to finish cleaning up. I'll get to that before the next version. Investigate moving to DI (guice) framework for plugin arch. --- Key: HBASE-6407 URL: https://issues.apache.org/jira/browse/HBASE-6407 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6407-1.patch, HBASE-6407-2.patch, HBASE-6407-3.patch, HBASE-6407-4.patch Investigate using Guice to inject the correct compat object provided by compat plugins -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6407) Investigate moving to DI (guice) framework for plugin arch.
[ https://issues.apache.org/jira/browse/HBASE-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-6407: - Attachment: HBASE-6407-3.patch Lots more work. HMaster should be done. HRegionServer still needs some work. Also I am still trying to figure out the best way to get LocalCluster to play nicely with conf's Investigate moving to DI (guice) framework for plugin arch. --- Key: HBASE-6407 URL: https://issues.apache.org/jira/browse/HBASE-6407 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6407-1.patch, HBASE-6407-2.patch, HBASE-6407-3.patch Investigate using Guice to inject the correct compat object provided by compat plugins -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6407) Investigate moving to DI (guice) framework for plugin arch.
[ https://issues.apache.org/jira/browse/HBASE-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-6407: - Attachment: HBASE-6407-2.patch Investigate moving to DI (guice) framework for plugin arch. --- Key: HBASE-6407 URL: https://issues.apache.org/jira/browse/HBASE-6407 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6407-1.patch, HBASE-6407-2.patch Investigate using Guice to inject the correct compat object provided by compat plugins -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6407) Investigate moving to DI (guice) framework for plugin arch.
[ https://issues.apache.org/jira/browse/HBASE-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliott Clark updated HBASE-6407: - Attachment: HBASE-6407-1.patch new version up on review board. Yes it's a big patch. And yes it will get bigger before it's done. However I think that the benfits to testing alone will be worth it. Investigate moving to DI (guice) framework for plugin arch. --- Key: HBASE-6407 URL: https://issues.apache.org/jira/browse/HBASE-6407 Project: HBase Issue Type: Sub-task Reporter: Elliott Clark Assignee: Elliott Clark Attachments: HBASE-6407-1.patch Investigate using Guice to inject the correct compat object provided by compat plugins -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
