Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-04 Thread via GitHub
virajjasani merged PR #5774: URL: https://github.com/apache/hbase/pull/5774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
bbeaudreault commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035831593 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
virajjasani commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035807493 @apurtell @bbeaudreault are you good with the latest revision of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035740710 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035730841 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 34s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035703665 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-03 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2035363772 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 48s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2033351237 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2033273874 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2032962099 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-02 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2032962089 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 15s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-04-02 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1548126408 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-27 Thread via GitHub
bbeaudreault commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1540832293 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn,

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-26 Thread via GitHub
apurtell commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1540422199 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-26 Thread via GitHub
bbeaudreault commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1539000878 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn,

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538525120 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache9 commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538516753 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics sl)

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538494129 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
bbeaudreault commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1538470996 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,23 @@ public void regionServerReport(ServerName sn,

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017678393 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017644363 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017617328 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-25 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017319464 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 49s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1537084622 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache9 commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1537006507 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics sl)

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1536981102 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1536980319 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1536979403 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
virajjasani commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1536979403 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache9 commented on code in PR #5774: URL: https://github.com/apache/hbase/pull/5774#discussion_r1536961183 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java: ## @@ -324,8 +324,19 @@ public void regionServerReport(ServerName sn, ServerMetrics sl)

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017023902 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 57s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017011424 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 33s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2017004220 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 20s |

Re: [PR] HBASE-28366 Mis-order of SCP and regionServerReport results into region inconsistencies [hbase]

2024-03-24 Thread via GitHub
Apache-HBase commented on PR #5774: URL: https://github.com/apache/hbase/pull/5774#issuecomment-2016939886 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 41s |