Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-23 Thread via GitHub
bbeaudreault commented on PR #5820: URL: https://github.com/apache/hbase/pull/5820#issuecomment-2073101170 @apurtell is this ready to be merged? It currently has fixVersion 2.6.0, and I'm looking to create the next RC tomorrow -- This is an automated message from the Apache Git Service.

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-12 Thread via GitHub
gourabtaparia commented on code in PR #5820: URL: https://github.com/apache/hbase/pull/5820#discussion_r1562328719 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreUtils.java: ## @@ -204,4 +204,28 @@ public static long getStorefileFieldSize(HStoreFile

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-10 Thread via GitHub
Apache9 commented on PR #5820: URL: https://github.com/apache/hbase/pull/5820#issuecomment-2048835083 > Introduce a new configuration setting - "hfile.block.size" that, if set, will define the default blocksize to use when writing HFiles if a column family schema does not define its own

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-10 Thread via GitHub
Apache-HBase commented on PR #5820: URL: https://github.com/apache/hbase/pull/5820#issuecomment-2048584901 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-10 Thread via GitHub
Apache-HBase commented on PR #5820: URL: https://github.com/apache/hbase/pull/5820#issuecomment-2048566812 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 28s |

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-10 Thread via GitHub
Apache-HBase commented on PR #5820: URL: https://github.com/apache/hbase/pull/5820#issuecomment-2048559303 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s |

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-10 Thread via GitHub
bbeaudreault commented on PR #5820: URL: https://github.com/apache/hbase/pull/5820#issuecomment-2048522245 Ya that happens sometimes, not sure why -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-10 Thread via GitHub
apurtell commented on PR #5820: URL: https://github.com/apache/hbase/pull/5820#issuecomment-2048458513 Ah, there was something wrong with CI during the spotless check [ERROR] An internal error occurred during: "Periodic workspace save.". java.lang.IllegalStateException: Job

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-10 Thread via GitHub
apurtell commented on PR #5820: URL: https://github.com/apache/hbase/pull/5820#issuecomment-2048456488 The spotless check fails but when I run 'mvn spotless:apply' on my local branch there are no changes. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-10 Thread via GitHub
apurtell commented on code in PR #5820: URL: https://github.com/apache/hbase/pull/5820#discussion_r1560068791 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreUtils.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-10 Thread via GitHub
Apache-HBase commented on PR #5820: URL: https://github.com/apache/hbase/pull/5820#issuecomment-2048291651 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s |

Re: [PR] HBASE-28447 New site configuration option "hfile.block.size" [hbase]

2024-04-10 Thread via GitHub
virajjasani commented on code in PR #5820: URL: https://github.com/apache/hbase/pull/5820#discussion_r1559929700 ## hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreUtils.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF)