Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
hgromer commented on PR #6961: URL: https://github.com/apache/hbase/pull/6961#issuecomment-2916640983 > Looks like the new scope of the work is > > 1. Pass the meta clearing exception to `updateCachedLocations` so we can properly capture the exception in the client metric instead of unknown exception > 2. Pushing `RejectedExecutionException` down into `isMetaClearingException` > > I am wondering if it make sense to split these into two different issues given the change in scope? My initial thought is in agreement that `RejectedExecutionException` should not be meta cache clearing, but maybe it would be beneficial to handle that change independently of the client metric fix , there may be implications beyond batch operations for that change. It'd make sense for me to have that be it's own thing (one I probably wouldn't own to be completely honest), cc @ndimiduk since I was following his suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
hgromer commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2109325414
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -764,13 +763,18 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
-Throwable t, boolean clearServerCache) {
+Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+boolean clearServerCache = ClientExceptionsUtil.isMetaClearingException(t);
// Do not update cache if exception is from failing to submit action to
thread pool
if (clearServerCache) {
cleanServerCache(server, t);
+
+ if (LOG.isTraceEnabled()) {
Review Comment:
Yeah this is already covered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
droudnitsky commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2100523369
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -783,8 +787,7 @@ private void receiveGlobalFailure(MultiAction rsActions,
ServerName server, int
// any of the regions in the MultiAction and do not update cache if
exception is
// from failing to submit action to thread pool
if (clearServerCache) {
-updateCachedLocations(server, regionName, row,
Review Comment:
Yeah `AsyncRequestFutureImpl` is tricky .. I have spent more time than I
care to admit to understand it better. Passing the exception to
`updateCachedLocations` so it gets accounted for in the cache clearing
exception metric sounds good, that is a nice improvement, makes sense to me 👍
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -764,13 +763,18 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
-Throwable t, boolean clearServerCache) {
+Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+boolean clearServerCache = ClientExceptionsUtil.isMetaClearingException(t);
// Do not update cache if exception is from failing to submit action to
thread pool
if (clearServerCache) {
cleanServerCache(server, t);
+
+ if (LOG.isTraceEnabled()) {
Review Comment:
Hernan looks to have that covered through `updateCachedLocations` -
https://github.com/apache/hbase/pull/6961/files#r2096239861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
ndimiduk commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2097967218
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -764,13 +763,18 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
-Throwable t, boolean clearServerCache) {
+Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+boolean clearServerCache = ClientExceptionsUtil.isMetaClearingException(t);
// Do not update cache if exception is from failing to submit action to
thread pool
if (clearServerCache) {
cleanServerCache(server, t);
+
+ if (LOG.isTraceEnabled()) {
Review Comment:
Should we tick a client-side metric here too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2893816922
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 48s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 14s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 10s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 44s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 25s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 14s | | the patch passed |
| +1 :green_heart: | compile | 1m 11s | | the patch passed |
| +1 :green_heart: | javac | 1m 11s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 42s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 23s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 22s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 218m 32s | | hbase-server in the patch
passed. |
| | | 256m 22s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux d4cca9a572fa 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 9c0220b547216545ad28c2e9ef84c4ab67fd1311 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/3/testReport/
|
| Max. process+thread count | 4464 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2893177175
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 43s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 32s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 0s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 41s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 18s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 28s | | the patch passed |
| +1 :green_heart: | compile | 1m 2s | | the patch passed |
| +1 :green_heart: | javac | 1m 2s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 42s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 18s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 10s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 19m 54s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 50m 37s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 97346deb8191 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 9c0220b547216545ad28c2e9ef84c4ab67fd1311 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/3/testReport/
|
| Max. process+thread count | 1769 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2893150789
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 50s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 17s | | branch-2 passed |
| +1 :green_heart: | compile | 3m 46s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 0m 57s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 2m 22s | | branch-2 passed |
| +1 :green_heart: | spotless | 0m 48s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 3s | | the patch passed |
| +1 :green_heart: | compile | 3m 48s | | the patch passed |
| +1 :green_heart: | javac | 3m 48s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 55s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 38s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 17m 54s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 46s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 18s | | The patch does not
generate ASF License warnings. |
| | | 44m 9s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 41409215adff 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 9c0220b547216545ad28c2e9ef84c4ab67fd1311 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 79 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/3/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
hgromer commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2096242427
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -783,8 +787,7 @@ private void receiveGlobalFailure(MultiAction rsActions,
ServerName server, int
// any of the regions in the MultiAction and do not update cache if
exception is
// from failing to submit action to thread pool
if (clearServerCache) {
-updateCachedLocations(server, regionName, row,
Review Comment:
Ah you're right. This code path is really tricky to reason about. Between
the UnknownExceptions in the meta cache clear metrics, and the lack of logging,
it's really difficult to identify what is causing these meta cache clears. I
think I'm going to re-purpose this PR to simply add some logging + avoid
passing in `null` as the meta exception in this code path. That should
hopefully help us shed some light on the high number of meta cache clears we're
seeing at my company, and will illuminate a path forward.
@droudnitsky does that make sense to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
hgromer commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2096239861
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -783,8 +787,7 @@ private void receiveGlobalFailure(MultiAction rsActions,
ServerName server, int
// any of the regions in the MultiAction and do not update cache if
exception is
// from failing to submit action to thread pool
if (clearServerCache) {
-updateCachedLocations(server, regionName, row,
- ClientExceptionsUtil.isMetaClearingException(t) ? null : t);
+updateCachedLocations(server, regionName, row, t);
Review Comment:
What we'll do is basically "mask" the cache clearing exception by report an
`UnknownException`. The code for that lives in the [metrics
class](https://github.com/apache/hbase/blob/b21ba71f73881336345fd5dd7d647910b3058e05/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java#L802).
It's annoying b/c that coupled with the lack of any logging in this code path
makes it really difficult to determine what caused these meta cache clears.
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -764,9 +763,14 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
-Throwable t, boolean clearServerCache) {
+Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+boolean clearServerCache = false;
+
+if (!(t instanceof RejectedExecutionException)) {
Review Comment:
Noted, adding that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
droudnitsky commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2094177695
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -783,8 +787,7 @@ private void receiveGlobalFailure(MultiAction rsActions,
ServerName server, int
// any of the regions in the MultiAction and do not update cache if
exception is
// from failing to submit action to thread pool
if (clearServerCache) {
-updateCachedLocations(server, regionName, row,
- ClientExceptionsUtil.isMetaClearingException(t) ? null : t);
+updateCachedLocations(server, regionName, row, t);
Review Comment:
+1 would be good to preserve the exception for `updateCachedLocations`
Since we currently pass null to `updateCachedLocations` if we have a meta
cache clearing exception, does that means that we never [update the cache
clearing exception metric properly
](https://github.com/apache/hbase/blob/rel/2.5.11/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L2125)
for cache clears coming from `receiveGlobalFailure`?
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -783,8 +787,7 @@ private void receiveGlobalFailure(MultiAction rsActions,
ServerName server, int
// any of the regions in the MultiAction and do not update cache if
exception is
// from failing to submit action to thread pool
if (clearServerCache) {
-updateCachedLocations(server, regionName, row,
Review Comment:
hey @hgromer . From what I understand , the
`ClientExceptionsUtil.isMetaClearingException(t) ? null : t` is what prevents
the meta cache clear from happening deeper in `updateCachedLocations` for
exceptions for which we should not clear the meta cache. If its a meta clearing
exception we pass null and bypass [this
check](https://github.com/apache/hbase/blob/rel/2.5.11/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L2105)
and clear the meta cache , if its not a meta cache clearing exception we pass
the exception and the check to bypass the meta cache clear if its not a meta
cache clearing exception happens in `updateCachedLocations`
[here](https://github.com/apache/hbase/blob/rel/2.5.11/hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java#L2106-L2109)
I may have misunderstand or have missed something, could you possibly add a
test to show that on batch operation a non meta cache clearing exception is
causing a meta cache clear through `receiveGlobalFailure`? There are some
existing meta cache clear behavior tests you could reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
ndimiduk commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2077349420
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -764,9 +763,14 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
-Throwable t, boolean clearServerCache) {
+Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+boolean clearServerCache = false;
+
+if (!(t instanceof RejectedExecutionException)) {
Review Comment:
I think it would be better if you instead push `RejectedExecutionException`
down into `ClientExceptionsUtil.isMetaClearingException`.
How about adding another collection of execution-exceptions for the family
of various ExecutorService interaction errors, like is done with
networking/connection exceptions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2854836114
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 11s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 40s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 35s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 28s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 38s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 0s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 8s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 19s | | hbase-client in the patch
passed. |
| | | 36m 12s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 6352ea7ae52d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / a5940ec472cc405958e338196510e5083df51c8f |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/testReport/
|
| Max. process+thread count | 379 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2854821455
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 14s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 59s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 26s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 21s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 3s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 9s | | the patch passed |
| +1 :green_heart: | compile | 0m 28s | | the patch passed |
| +1 :green_heart: | javac | 0m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 25s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 18s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 12s | | hbase-client in the patch
passed. |
| | | 32m 3s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux db1cb7e6e535 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / a5940ec472cc405958e338196510e5083df51c8f |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/testReport/
|
| Max. process+thread count | 360 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2854821619
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 47s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 15s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 50s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 0m 17s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 0m 52s | | branch-2 passed |
| +1 :green_heart: | spotless | 0m 47s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 5s | | the patch passed |
| +1 :green_heart: | compile | 0m 49s | | the patch passed |
| +1 :green_heart: | javac | 0m 49s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 3s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 17m 24s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 46s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 10s | | The patch does not
generate ASF License warnings. |
| | | 32m 12s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 1ad0ba4bc71c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / a5940ec472cc405958e338196510e5083df51c8f |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 78 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2854814841
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 50s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 3s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 22s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 18s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 5s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 2s | | the patch passed |
| +1 :green_heart: | compile | 0m 26s | | the patch passed |
| +1 :green_heart: | javac | 0m 26s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 18s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 11s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 15s | | hbase-client in the patch
passed. |
| | | 30m 5s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 0c6b793c1f69 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / a5940ec472cc405958e338196510e5083df51c8f |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/testReport/
|
| Max. process+thread count | 384 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
hgromer commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2075580085
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -764,9 +763,14 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
-Throwable t, boolean clearServerCache) {
+Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+boolean clearServerCache = false;
+
+if (!(t instanceof RejectedExecutionException)) {
Review Comment:
Enforces the constraints added in
https://issues.apache.org/jira/browse/HBASE-27491
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
hgromer commented on PR #6961: URL: https://github.com/apache/hbase/pull/6961#issuecomment-2854740306 cc @ndimiduk @rmdmattingly @krconv -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
hgromer commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2075575143
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -783,8 +787,7 @@ private void receiveGlobalFailure(MultiAction rsActions,
ServerName server, int
// any of the regions in the MultiAction and do not update cache if
exception is
// from failing to submit action to thread pool
if (clearServerCache) {
-updateCachedLocations(server, regionName, row,
- ClientExceptionsUtil.isMetaClearingException(t) ? null : t);
+updateCachedLocations(server, regionName, row, t);
Review Comment:
This also solves the frustration of seeing "UnknownException" when
inspecting meta cache clear exception metrics. This has made it quite difficult
to track down what triggered the meta cache clear.
I think it's always better to provide more context than less. Even if an
exception is meta cache clearing (though it will be now), I'd still prefer to
know the exact exception type that cleared the meta cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
hgromer commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2075575143
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -783,8 +787,7 @@ private void receiveGlobalFailure(MultiAction rsActions,
ServerName server, int
// any of the regions in the MultiAction and do not update cache if
exception is
// from failing to submit action to thread pool
if (clearServerCache) {
-updateCachedLocations(server, regionName, row,
- ClientExceptionsUtil.isMetaClearingException(t) ? null : t);
+updateCachedLocations(server, regionName, row, t);
Review Comment:
This also solves the frustration of seeing "UnknownException" when
inspecting meta cache clear exceptions. This has made it quite difficult to
track down what triggered the meta cache clear.
I think it's always better to provide more context than less. Even if an
exception is meta cache clearing (though it will be now), I'd still prefer to
know the exact exception type that cleared the meta cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2852819674
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 3m 9s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 49s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 47s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 25s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 22s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 41s | | the patch passed |
| +1 :green_heart: | compile | 0m 28s | | the patch passed |
| +1 :green_heart: | javac | 0m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 53s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 37s | | hbase-client in the patch
passed. |
| | | 37m 55s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 4dfe0c0db74e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 5a0d7c072e83fd5aa7708687de2a5fc87f73ac94 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/testReport/
|
| Max. process+thread count | 380 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2852819622
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 11s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 46s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 14s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 0m 23s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 1m 6s | | branch-2 passed |
| +1 :green_heart: | spotless | 0m 57s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 0s | | the patch passed |
| +1 :green_heart: | compile | 1m 10s | | the patch passed |
| +1 :green_heart: | javac | 1m 10s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 21s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 18s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 18m 42s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 47s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 10s | | The patch does not
generate ASF License warnings. |
| | | 38m 6s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 3807b0e5536c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 5a0d7c072e83fd5aa7708687de2a5fc87f73ac94 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 77 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2852816446
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 3m 46s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 15s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 34s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 22s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 41s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 17s | | the patch passed |
| +1 :green_heart: | compile | 0m 24s | | the patch passed |
| +1 :green_heart: | javac | 0m 24s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 18s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 30s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 7m 48s | | hbase-client in the patch
passed. |
| | | 35m 13s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux a56477d2cbdb 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 5a0d7c072e83fd5aa7708687de2a5fc87f73ac94 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/testReport/
|
| Max. process+thread count | 372 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Batch calls to overloaded cluster can cause meta hotspotting [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2852811690
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 3s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 58s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 29s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 19s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 57s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 1s | | the patch passed |
| +1 :green_heart: | compile | 0m 28s | | the patch passed |
| +1 :green_heart: | javac | 0m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 24s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 3s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 49s | | hbase-client in the patch
passed. |
| | | 32m 55s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 6c3eb7dff292 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / 5a0d7c072e83fd5aa7708687de2a5fc87f73ac94 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/testReport/
|
| Max. process+thread count | 366 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
