Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
ndimiduk commented on PR #6961: URL: https://github.com/apache/hbase/pull/6961#issuecomment-2935098409 Okay fair enough, let's take this as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
ndimiduk commented on PR #6961: URL: https://github.com/apache/hbase/pull/6961#issuecomment-2934358411 The refactor on https://github.com/apache/hbase/pull/578 looked like a good effort. Too bad it had to be reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
ndimiduk commented on PR #6961: URL: https://github.com/apache/hbase/pull/6961#issuecomment-2934354613 > > Looks like the new scope of the work is > > > > 1. Pass the meta clearing exception to `updateCachedLocations` so we can properly capture the exception in the client metric instead of unknown exception > > 2. Pushing `RejectedExecutionException` down into `isMetaClearingException` > > > > I am wondering if it make sense to split these into two different issues given the change in scope? My initial thought is in agreement that `RejectedExecutionException` should not be meta cache clearing, but maybe it would be beneficial to handle that change independently of the client metric fix , there may be implications beyond batch operations for that change. > > It'd make sense for me to have that be it's own thing (one I probably wouldn't own to be completely honest), cc @ndimiduk since I was following his suggestion Oh. I see now that you and droudnitsky are attempting to cut scope. I don't feel great about leaving the `RejectedExecutionException` as it is, but if you'd prefer to isolate that change, then let's proceed with what you have. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
ndimiduk commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2123256392
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -764,9 +763,14 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
-Throwable t, boolean clearServerCache) {
+Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+boolean clearServerCache = false;
+
+if (!(t instanceof RejectedExecutionException)) {
Review Comment:
@hgromer I think you dropped my earlier comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
ndimiduk commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2123183998
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -764,13 +763,24 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
-Throwable t, boolean clearServerCache) {
+Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+boolean clearServerCache;
+
+if (t instanceof RejectedExecutionException) {
Review Comment:
I think that we should add `RejectedExecutionException` to the predicate in
`ClientExceptionsUtil#isMetaClearingException()`. Seems dicy to have a special
case test here. Or am I missing some wider context?
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##
@@ -764,13 +763,18 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
-Throwable t, boolean clearServerCache) {
+Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+boolean clearServerCache = ClientExceptionsUtil.isMetaClearingException(t);
// Do not update cache if exception is from failing to submit action to
thread pool
if (clearServerCache) {
cleanServerCache(server, t);
+
+ if (LOG.isTraceEnabled()) {
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2932957216
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 20s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 19s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 17s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 31s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 20s | | the patch passed |
| +1 :green_heart: | javac | 0m 20s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 16s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 28s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 7m 58s | | hbase-client in the patch
passed. |
| | | 27m 51s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux c3ae91027442 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d138309786b0c8786c60725a79e2d57065a90d52 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/testReport/
|
| Max. process+thread count | 366 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2933003715
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 41s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 21s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 23s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 18s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 21s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 7s | | the patch passed |
| +1 :green_heart: | compile | 0m 23s | | the patch passed |
| +1 :green_heart: | javac | 0m 23s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 17s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 20s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 15s | | hbase-client in the patch
passed. |
| | | 30m 32s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 8ef610a3672c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d138309786b0c8786c60725a79e2d57065a90d52 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/testReport/
|
| Max. process+thread count | 371 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2932970384
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 55s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 53s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 27s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 22s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 12s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 33s | | the patch passed |
| +1 :green_heart: | compile | 0m 23s | | the patch passed |
| +1 :green_heart: | javac | 0m 23s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 59s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 7m 56s | | hbase-client in the patch
passed. |
| | | 33m 13s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux b5185e8fb582 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d138309786b0c8786c60725a79e2d57065a90d52 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/testReport/
|
| Max. process+thread count | 367 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2932966811
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 32s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 56s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 0m 31s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 1m 15s | | branch-2 passed |
| +1 :green_heart: | spotless | 1m 3s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 48s | | the patch passed |
| +1 :green_heart: | compile | 1m 4s | | the patch passed |
| +1 :green_heart: | javac | 1m 4s | | the patch passed |
| +1 :green_heart: | blanks | 0m 1s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 25s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 13s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 20m 38s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 21s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | | The patch does not
generate ASF License warnings. |
| | | 39m 10s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 8cf4818e13ab 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d138309786b0c8786c60725a79e2d57065a90d52 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 79 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/5/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
hgromer commented on PR #6961: URL: https://github.com/apache/hbase/pull/6961#issuecomment-2923012685 The hadoopcheck issue seems unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2920380186
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 43s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 56s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 22s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 20s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 24s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 9s | | the patch passed |
| +1 :green_heart: | compile | 0m 22s | | the patch passed |
| +1 :green_heart: | javac | 0m 22s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 18s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 18s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 16s | | hbase-client in the patch
passed. |
| | | 31m 17s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 02061fe1e90b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d138309786b0c8786c60725a79e2d57065a90d52 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/testReport/
|
| Max. process+thread count | 383 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2920337831
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 59s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 10s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 10s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 0m 25s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 1m 19s | | branch-2 passed |
| +1 :green_heart: | spotless | 1m 10s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 29s | | the patch passed |
| +1 :green_heart: | compile | 1m 16s | | the patch passed |
| +1 :green_heart: | javac | 1m 16s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 27s | | the patch passed |
| +1 :green_heart: | spotbugs | 1m 21s | | the patch passed |
| -1 :x: | hadoopcheck | 1m 2s | | The patch causes 15 errors with
Hadoop v2.10.2. |
| +1 :green_heart: | spotless | 1m 18s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 14s | | The patch does not
generate ASF License warnings. |
| | | 39m 33s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 5a8ab681ca4e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d138309786b0c8786c60725a79e2d57065a90d52 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| hadoopcheck |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/artifact/yetus-general-check/output/patch-javac-2.10.2.txt
|
| Max. process+thread count | 78 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2920334997
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 46s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 3s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 21s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 19s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 36s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 12s | | the patch passed |
| +1 :green_heart: | compile | 0m 20s | | the patch passed |
| +1 :green_heart: | javac | 0m 20s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 18s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 32s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 7m 46s | | hbase-client in the patch
passed. |
| | | 31m 22s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux abe305eb897f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d138309786b0c8786c60725a79e2d57065a90d52 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/testReport/
|
| Max. process+thread count | 370 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
Apache-HBase commented on PR #6961:
URL: https://github.com/apache/hbase/pull/6961#issuecomment-2920318594
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +1 :green_heart: | mvninstall | 3m 10s | | branch-2 passed |
| +1 :green_heart: | compile | 0m 19s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 17s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 28s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 2m 36s | | the patch passed |
| +1 :green_heart: | compile | 0m 19s | | the patch passed |
| +1 :green_heart: | javac | 0m 19s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 16s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 27s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 8s | | hbase-client in the patch
passed. |
| | | 27m 55s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/6961 |
| JIRA Issue | HBASE-29265 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 515798e0382c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d138309786b0c8786c60725a79e2d57065a90d52 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/testReport/
|
| Max. process+thread count | 359 (vs. ulimit of 3) |
| modules | C: hbase-client U: hbase-client |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6961/4/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29265: Meta cache clear metrics and logs shouldn't use "UnknownException" [hbase]
hgromer commented on PR #6961: URL: https://github.com/apache/hbase/pull/6961#issuecomment-2919546354 I've updated the PR to soleley add some logging and emitting the real meta cache clearing exception in meta cache clear metrics. cc @ndimiduk @droudnitsky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
