Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
virajjasani merged PR #7163: URL: https://github.com/apache/hbase/pull/7163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
virajjasani merged PR #7162: URL: https://github.com/apache/hbase/pull/7162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
virajjasani merged PR #7158: URL: https://github.com/apache/hbase/pull/7158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3089425091
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 5s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 29s | | branch-2.6 passed |
| +1 :green_heart: | compile | 1m 29s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 1m 1s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 6m 53s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 42s | | the patch passed |
| +1 :green_heart: | compile | 1m 40s | | the patch passed |
| +1 :green_heart: | javac | 1m 40s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 55s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 56s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 26s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 489m 15s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 548m 0s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 1385e98109ff 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / ee44c386f63cf68ac1d65bf21f9c99c1f725db2f |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/testReport/
|
| Max. process+thread count | 4083 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3089390099
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 14s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 50s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 54s | | branch-2 passed |
| +1 :green_heart: | javadoc | 1m 12s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 43s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 40s | | the patch passed |
| +1 :green_heart: | compile | 1m 55s | | the patch passed |
| +1 :green_heart: | javac | 1m 55s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 28s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 50s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 465m 37s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 535m 14s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux c62c9e8db9a1 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d5834cbfa2ce8e1c1f4d49872b9f0a0a7d937a52 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/testReport/
|
| Max. process+thread count | 4372 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3088917893
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 13s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 52s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 38s | | branch-2 passed |
| +1 :green_heart: | javadoc | 1m 2s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 30s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 34s | | the patch passed |
| +1 :green_heart: | compile | 1m 45s | | the patch passed |
| +1 :green_heart: | javac | 1m 45s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 31s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 9m 11s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 322m 47s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 377m 30s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 62933a3ccea9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d5834cbfa2ce8e1c1f4d49872b9f0a0a7d937a52 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/testReport/
|
| Max. process+thread count | 4307 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3088890945
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 37s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 7s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 35s | | branch-2 passed |
| +1 :green_heart: | javadoc | 1m 5s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 27s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 52s | | the patch passed |
| +1 :green_heart: | compile | 1m 29s | | the patch passed |
| +1 :green_heart: | javac | 1m 29s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 4s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 29s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 44s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 324m 6s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 369m 28s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 69285af65b53 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d5834cbfa2ce8e1c1f4d49872b9f0a0a7d937a52 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/testReport/
|
| Max. process+thread count | 4149 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3088895140
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 57s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 37s | | branch-2.6 passed |
| +1 :green_heart: | compile | 1m 39s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 0m 58s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 7m 24s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 32s | | the patch passed |
| +1 :green_heart: | compile | 1m 34s | | the patch passed |
| +1 :green_heart: | javac | 1m 34s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 1s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 29s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 38s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 321m 31s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 370m 21s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux a3a82c6aab8c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / ee44c386f63cf68ac1d65bf21f9c99c1f725db2f |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/testReport/
|
| Max. process+thread count | 4438 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7163:
URL: https://github.com/apache/hbase/pull/7163#issuecomment-3088849488
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 54s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.5 Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 5s | | branch-2.5 passed |
| +1 :green_heart: | compile | 1m 31s | | branch-2.5 passed |
| +1 :green_heart: | javadoc | 1m 2s | | branch-2.5 passed |
| +1 :green_heart: | shadedjars | 6m 21s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 49s | | the patch passed |
| +1 :green_heart: | compile | 1m 20s | | the patch passed |
| +1 :green_heart: | javac | 1m 20s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 3s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 24s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 21s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 300m 51s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 354m 3s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7163 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux d07f929398c7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.5 / f2817c24203350cddafb731bbd34f64349e4f198 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/testReport/
|
| Max. process+thread count | 4219 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7163:
URL: https://github.com/apache/hbase/pull/7163#issuecomment-3088285720
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 52s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.5 Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 56s | | branch-2.5 passed |
| +1 :green_heart: | compile | 1m 38s | | branch-2.5 passed |
| +1 :green_heart: | javadoc | 1m 2s | | branch-2.5 passed |
| +1 :green_heart: | shadedjars | 7m 49s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 55s | | the patch passed |
| +1 :green_heart: | compile | 1m 37s | | the patch passed |
| +1 :green_heart: | javac | 1m 37s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 58s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 47s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 44s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 210m 28s | | hbase-server in the patch
passed. |
| | | 256m 2s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7163 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 1d014cab6a35 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.5 / f2817c24203350cddafb731bbd34f64349e4f198 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/testReport/
|
| Max. process+thread count | 4290 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3088154883
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 53s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 16s | | branch-2.6 passed |
| +1 :green_heart: | compile | 1m 18s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 0m 45s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 6m 20s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 8s | | the patch passed |
| +1 :green_heart: | compile | 1m 19s | | the patch passed |
| +1 :green_heart: | javac | 1m 19s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 44s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 18s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 7m 40s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 207m 47s | | hbase-server in the patch
passed. |
| | | 244m 28s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 531bea0ba824 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / ee44c386f63cf68ac1d65bf21f9c99c1f725db2f |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/testReport/
|
| Max. process+thread count | 4071 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7163:
URL: https://github.com/apache/hbase/pull/7163#issuecomment-3087911387
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 53s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.5 Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 4s | | branch-2.5 passed |
| +1 :green_heart: | compile | 1m 13s | | branch-2.5 passed |
| +1 :green_heart: | javadoc | 0m 44s | | branch-2.5 passed |
| +1 :green_heart: | shadedjars | 6m 1s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 52s | | the patch passed |
| +1 :green_heart: | compile | 1m 13s | | the patch passed |
| +1 :green_heart: | javac | 1m 13s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 42s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 58s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 10s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 187m 45s | | hbase-server in the patch
passed. |
| | | 223m 20s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7163 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux cba7e3e94823 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.5 / f2817c24203350cddafb731bbd34f64349e4f198 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/testReport/
|
| Max. process+thread count | 4568 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3086739307
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 19s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 55s | | branch-2.6 passed |
| +1 :green_heart: | compile | 4m 55s | | branch-2.6 passed |
| +1 :green_heart: | checkstyle | 1m 8s | | branch-2.6 passed |
| +1 :green_heart: | spotbugs | 2m 58s | | branch-2.6 passed |
| +1 :green_heart: | spotless | 0m 54s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 3s | | the patch passed |
| +1 :green_heart: | compile | 4m 51s | | the patch passed |
| +1 :green_heart: | javac | 4m 51s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 4s | | the patch passed |
| +1 :green_heart: | spotbugs | 3m 14s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 23m 34s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 21s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 42s | | The patch does not
generate ASF License warnings. |
| | | 58m 54s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 449ea5a17ec9 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / ee44c386f63cf68ac1d65bf21f9c99c1f725db2f |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 78 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/3/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7163:
URL: https://github.com/apache/hbase/pull/7163#issuecomment-3086727530
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2.5 Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 33s | | branch-2.5 passed |
| +1 :green_heart: | compile | 3m 50s | | branch-2.5 passed |
| +1 :green_heart: | checkstyle | 1m 0s | | branch-2.5 passed |
| +1 :green_heart: | spotbugs | 2m 37s | | branch-2.5 passed |
| +1 :green_heart: | spotless | 0m 49s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 24s | | the patch passed |
| +1 :green_heart: | compile | 3m 44s | | the patch passed |
| +1 :green_heart: | javac | 3m 44s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 18s |
[/results-checkstyle-hbase-client.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/artifact/yetus-general-check/output/results-checkstyle-hbase-client.txt)
| hbase-client: The patch generated 4 new + 2 unchanged - 0 fixed = 6 total
(was 2) |
| +1 :green_heart: | spotbugs | 2m 53s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 23m 7s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 47s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | | The patch does not
generate ASF License warnings. |
| | | 50m 30s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7163 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 8e23fe626f48 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.5 / f2817c24203350cddafb731bbd34f64349e4f198 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 79 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/2/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3086697708
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 44s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 17s | | branch-2 passed |
| +1 :green_heart: | compile | 3m 47s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 0m 56s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 2m 22s | | branch-2 passed |
| +1 :green_heart: | spotless | 0m 48s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 7s | | the patch passed |
| +1 :green_heart: | compile | 3m 44s | | the patch passed |
| +1 :green_heart: | javac | 3m 44s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 56s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 45s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 17m 6s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 44s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 19s | | The patch does not
generate ASF License warnings. |
| | | 43m 3s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux fe79acca5e23 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d5834cbfa2ce8e1c1f4d49872b9f0a0a7d937a52 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 79 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/3/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3085773622
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 20s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 8s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 23s | | branch-2.6 passed |
| +1 :green_heart: | compile | 1m 43s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 1m 11s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 9m 19s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 14s | | the patch passed |
| +1 :green_heart: | compile | 1m 46s | | the patch passed |
| +1 :green_heart: | javac | 1m 46s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 8s | | the patch passed |
| +1 :green_heart: | shadedjars | 8m 39s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 9m 10s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 274m 22s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 324m 22s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux f3348ab12740 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / ee44c386f63cf68ac1d65bf21f9c99c1f725db2f |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/testReport/
|
| Max. process+thread count | 4311 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3085698072
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 12s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 17s | | branch-2.6 passed |
| +1 :green_heart: | compile | 2m 7s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 1m 22s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 9m 33s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 21s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 44s | | the patch passed |
| +1 :green_heart: | compile | 2m 9s | | the patch passed |
| +1 :green_heart: | javac | 2m 9s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 22s | | the patch passed |
| +1 :green_heart: | shadedjars | 9m 24s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 9m 0s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 236m 13s | | hbase-server in the patch
passed. |
| | | 287m 47s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux e69246d26f67 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / ee44c386f63cf68ac1d65bf21f9c99c1f725db2f |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/testReport/
|
| Max. process+thread count | 4395 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3085617899
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 49s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 9s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 11s | | branch-2.6 passed |
| +1 :green_heart: | compile | 1m 18s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 0m 46s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 6m 20s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 6s | | the patch passed |
| +1 :green_heart: | compile | 1m 19s | | the patch passed |
| +1 :green_heart: | javac | 1m 19s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 44s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 14s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 7m 39s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 210m 8s | | hbase-server in the patch
passed. |
| | | 246m 22s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 27baf5399930 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / ee44c386f63cf68ac1d65bf21f9c99c1f725db2f |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/testReport/
|
| Max. process+thread count | 4239 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7163:
URL: https://github.com/apache/hbase/pull/7163#issuecomment-3085399360
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 15s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.5 Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 37s | | branch-2.5 passed |
| +1 :green_heart: | compile | 2m 7s | | branch-2.5 passed |
| +1 :green_heart: | javadoc | 1m 11s | | branch-2.5 passed |
| +1 :green_heart: | shadedjars | 10m 25s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 23s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 23s | | the patch passed |
| +1 :green_heart: | compile | 2m 8s | | the patch passed |
| +1 :green_heart: | javac | 2m 8s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 26s | | the patch passed |
| +1 :green_heart: | shadedjars | 9m 8s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 9m 58s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 309m 57s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 365m 27s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7163 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 8daee0e9c516 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.5 / f2817c24203350cddafb731bbd34f64349e4f198 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/testReport/
|
| Max. process+thread count | 4166 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7163:
URL: https://github.com/apache/hbase/pull/7163#issuecomment-3085218140
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 11s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 8s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.5 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 54s | | branch-2.5 passed |
| +1 :green_heart: | compile | 1m 37s | | branch-2.5 passed |
| +1 :green_heart: | javadoc | 1m 3s | | branch-2.5 passed |
| +1 :green_heart: | shadedjars | 7m 39s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 0s | | the patch passed |
| +1 :green_heart: | compile | 1m 28s | | the patch passed |
| +1 :green_heart: | javac | 1m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 55s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 30s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 44s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 247m 53s | | hbase-server in the patch
passed. |
| | | 292m 37s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7163 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux bbeb974f1929 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.5 / f2817c24203350cddafb731bbd34f64349e4f198 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/testReport/
|
| Max. process+thread count | 4430 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3085018535
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 53s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 51s | | branch-2.6 passed |
| +1 :green_heart: | compile | 4m 0s | | branch-2.6 passed |
| +1 :green_heart: | checkstyle | 0m 57s | | branch-2.6 passed |
| +1 :green_heart: | spotbugs | 2m 27s | | branch-2.6 passed |
| +1 :green_heart: | spotless | 0m 49s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 2s | | the patch passed |
| +1 :green_heart: | compile | 3m 49s | | the patch passed |
| +1 :green_heart: | javac | 3m 49s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 56s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 38s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 16m 52s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 42s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 19s | | The patch does not
generate ASF License warnings. |
| | | 43m 58s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux d6436552af9d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / ee44c386f63cf68ac1d65bf21f9c99c1f725db2f |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 79 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/2/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7163:
URL: https://github.com/apache/hbase/pull/7163#issuecomment-3085017940
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 45s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.5 Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 17s | | branch-2.5 passed |
| +1 :green_heart: | compile | 1m 19s | | branch-2.5 passed |
| +1 :green_heart: | javadoc | 0m 46s | | branch-2.5 passed |
| +1 :green_heart: | shadedjars | 6m 23s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 13s | | the patch passed |
| +1 :green_heart: | compile | 1m 19s | | the patch passed |
| +1 :green_heart: | javac | 1m 19s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 45s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 23s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 15s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 193m 3s | | hbase-server in the patch
passed. |
| | | 231m 27s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7163 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux e6ff6d95c02c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.5 / f2817c24203350cddafb731bbd34f64349e4f198 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/testReport/
|
| Max. process+thread count | 4295 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3084977993
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 17s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 34s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 29s | | branch-2 passed |
| +1 :green_heart: | javadoc | 1m 3s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 41s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 27s | | the patch passed |
| +1 :green_heart: | compile | 1m 33s | | the patch passed |
| +1 :green_heart: | javac | 1m 33s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 7s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 49s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 23s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 324m 41s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 367m 3s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux ede3b3975b56 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d5834cbfa2ce8e1c1f4d49872b9f0a0a7d937a52 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/testReport/
|
| Max. process+thread count | 4256 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3084950026
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 17s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 13s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 57s | | branch-2 passed |
| +1 :green_heart: | javadoc | 1m 6s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 46s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 15s | | the patch passed |
| +1 :green_heart: | compile | 1m 49s | | the patch passed |
| +1 :green_heart: | javac | 1m 49s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 57s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 30s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 50s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 309m 54s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 357m 12s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 4d6e6f5380c2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d5834cbfa2ce8e1c1f4d49872b9f0a0a7d937a52 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/testReport/
|
| Max. process+thread count | 4583 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3084892833
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 11s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 55s | | branch-2.6 passed |
| +1 :green_heart: | compile | 1m 54s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 1m 6s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 8m 39s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 3s | | the patch passed |
| +1 :green_heart: | compile | 1m 53s | | the patch passed |
| +1 :green_heart: | javac | 1m 53s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 2s | | the patch passed |
| +1 :green_heart: | shadedjars | 8m 39s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 56s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 298m 24s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 349m 35s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux e48e7220ace3 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / d6f67856a7063c47698af8bb1add9b57cfa7ffeb |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/testReport/
|
| Max. process+thread count | 4443 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3084762450
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 49s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 20s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 13s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 44s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 41s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 8s | | the patch passed |
| +1 :green_heart: | compile | 1m 16s | | the patch passed |
| +1 :green_heart: | javac | 1m 16s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 44s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 36s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 20s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 254m 20s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 294m 12s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux cad1b1b6df2c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d5834cbfa2ce8e1c1f4d49872b9f0a0a7d937a52 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/testReport/
|
| Max. process+thread count | 4492 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3084613865
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 49s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 5s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 54s | | branch-2.6 passed |
| +1 :green_heart: | compile | 1m 5s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 0m 43s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 5m 43s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 36s | | the patch passed |
| +1 :green_heart: | compile | 1m 2s | | the patch passed |
| +1 :green_heart: | javac | 1m 2s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 41s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 37s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 12s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 222m 22s | | hbase-server in the patch
passed. |
| | | 257m 1s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 808fd66546f2 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / d6f67856a7063c47698af8bb1add9b57cfa7ffeb |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/testReport/
|
| Max. process+thread count | 4253 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3084609598
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 47s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 40s | | branch-2.6 passed |
| +1 :green_heart: | compile | 1m 26s | | branch-2.6 passed |
| +1 :green_heart: | javadoc | 0m 51s | | branch-2.6 passed |
| +1 :green_heart: | shadedjars | 6m 32s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 20s | | the patch passed |
| +1 :green_heart: | compile | 1m 27s | | the patch passed |
| +1 :green_heart: | javac | 1m 27s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 49s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 26s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 32s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 216m 46s | | hbase-server in the patch
passed. |
| | | 255m 54s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux e9c5350a3387 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / d6f67856a7063c47698af8bb1add9b57cfa7ffeb |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/testReport/
|
| Max. process+thread count | 4511 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7163:
URL: https://github.com/apache/hbase/pull/7163#issuecomment-3084476675
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 46s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2.5 Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 17s | | branch-2.5 passed |
| +1 :green_heart: | compile | 3m 36s | | branch-2.5 passed |
| +1 :green_heart: | checkstyle | 0m 54s | | branch-2.5 passed |
| +1 :green_heart: | spotbugs | 2m 18s | | branch-2.5 passed |
| +1 :green_heart: | spotless | 0m 44s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 8s | | the patch passed |
| +1 :green_heart: | compile | 3m 41s | | the patch passed |
| -0 :warning: | javac | 2m 54s |
[/results-compile-javac-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/artifact/yetus-general-check/output/results-compile-javac-hbase-server.txt)
| hbase-server generated 4 new + 191 unchanged - 4 fixed = 195 total (was
195) |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 16s |
[/results-checkstyle-hbase-client.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/artifact/yetus-general-check/output/results-checkstyle-hbase-client.txt)
| hbase-client: The patch generated 4 new + 2 unchanged - 0 fixed = 6 total
(was 2) |
| +1 :green_heart: | spotbugs | 2m 33s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 22m 16s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.2.4 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 44s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 19s | | The patch does not
generate ASF License warnings. |
| | | 47m 46s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7163 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux a87a724b1912 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.5 / f2817c24203350cddafb731bbd34f64349e4f198 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 76 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7163/1/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3083970902
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 46s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 50s | | branch-2 passed |
| +1 :green_heart: | compile | 4m 13s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 1m 3s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 3m 41s | | branch-2 passed |
| +1 :green_heart: | spotless | 1m 8s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 8s | | the patch passed |
| +1 :green_heart: | compile | 4m 37s | | the patch passed |
| +1 :green_heart: | javac | 4m 37s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 6s | | the patch passed |
| +1 :green_heart: | spotbugs | 3m 58s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 20m 31s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 56s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | | The patch does not
generate ASF License warnings. |
| | | 54m 15s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 18b812cdd19e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / d5834cbfa2ce8e1c1f4d49872b9f0a0a7d937a52 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 76 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/2/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7162:
URL: https://github.com/apache/hbase/pull/7162#issuecomment-3083948158
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 9s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2.6 Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 5m 50s | | branch-2.6 passed |
| +1 :green_heart: | compile | 5m 14s | | branch-2.6 passed |
| +1 :green_heart: | checkstyle | 1m 18s | | branch-2.6 passed |
| +1 :green_heart: | spotbugs | 3m 15s | | branch-2.6 passed |
| +1 :green_heart: | spotless | 1m 0s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 13s | | the patch passed |
| +1 :green_heart: | compile | 5m 15s | | the patch passed |
| +1 :green_heart: | javac | 5m 15s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 10s | | the patch passed |
| +1 :green_heart: | spotbugs | 3m 39s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 24m 17s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 24s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 44s | | The patch does not
generate ASF License warnings. |
| | | 62m 45s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7162 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux c66b8db4acfa 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2.6 / d6f67856a7063c47698af8bb1add9b57cfa7ffeb |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 79 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7162/1/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3081851859
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 57s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 7s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 19s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 31s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 55s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 7m 0s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 31s | | the patch passed |
| +1 :green_heart: | compile | 1m 34s | | the patch passed |
| +1 :green_heart: | javac | 1m 34s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 54s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 58s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 42s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 271m 22s | | hbase-server in the patch
passed. |
| | | 313m 42s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 4e4aac059a5e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / fa2043b5e7b015a5e707b34fd5c4d87c56045177 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/testReport/
|
| Max. process+thread count | 4502 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3081690953
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 51s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 28s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 12s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 44s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 6m 39s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 12s | | the patch passed |
| +1 :green_heart: | compile | 1m 11s | | the patch passed |
| +1 :green_heart: | javac | 1m 11s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 43s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 35s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 25s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 227m 0s | | hbase-server in the patch
passed. |
| | | 265m 26s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 140c93e7dd4f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / fa2043b5e7b015a5e707b34fd5c4d87c56045177 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/testReport/
|
| Max. process+thread count | (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3081645586
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 46s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 6s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 2m 57s | | branch-2 passed |
| +1 :green_heart: | compile | 1m 7s | | branch-2 passed |
| +1 :green_heart: | javadoc | 0m 47s | | branch-2 passed |
| +1 :green_heart: | shadedjars | 5m 37s | | branch has no errors when
building our shaded downstream artifacts. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 41s | | the patch passed |
| +1 :green_heart: | compile | 1m 4s | | the patch passed |
| +1 :green_heart: | javac | 1m 4s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 44s | | the patch passed |
| +1 :green_heart: | shadedjars | 5m 34s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 8m 10s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 218m 5s | | hbase-server in the patch
passed. |
| | | 253m 0s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux cc30d3488515 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / fa2043b5e7b015a5e707b34fd5c4d87c56045177 |
| Default Java | Temurin-1.8.0_412-b08 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/testReport/
|
| Max. process+thread count | 4316 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7158:
URL: https://github.com/apache/hbase/pull/7158#issuecomment-3080054476
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 50s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ branch-2 Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 50s | | branch-2 passed |
| +1 :green_heart: | compile | 5m 3s | | branch-2 passed |
| +1 :green_heart: | checkstyle | 1m 15s | | branch-2 passed |
| +1 :green_heart: | spotbugs | 3m 39s | | branch-2 passed |
| +1 :green_heart: | spotless | 1m 8s | | branch has no errors when
running spotless:check. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 18s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 43s | | the patch passed |
| +1 :green_heart: | compile | 5m 9s | | the patch passed |
| +1 :green_heart: | javac | 5m 9s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 18s | | the patch passed |
| +1 :green_heart: | spotbugs | 4m 4s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 23m 36s | | Patch does not cause any
errors with Hadoop 2.10.2 or 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 10s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 26s | | The patch does not
generate ASF License warnings. |
| | | 60m 16s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7158 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 51befa50af6c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | branch-2 / fa2043b5e7b015a5e707b34fd5c4d87c56045177 |
| Default Java | Eclipse Adoptium-11.0.23+9 |
| Max. process+thread count | 85 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7158/1/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
virajjasani merged PR #7136: URL: https://github.com/apache/hbase/pull/7136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2208522347
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##
@@ -1097,71 +1099,91 @@ public void setConf(Configuration conf) {
* Retrieve block from cache. Validates the retrieved block's type vs {@code
expectedBlockType}
* and its encoding vs. {@code expectedDataBlockEncoding}. Unpacks the block
as necessary.
*/
- private HFileBlock getCachedBlock(BlockCacheKey cacheKey, boolean
cacheBlock, boolean useLock,
+ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.UNITTEST)
+ public HFileBlock getCachedBlock(BlockCacheKey cacheKey, boolean cacheBlock,
boolean useLock,
boolean updateCacheMetrics, BlockType expectedBlockType,
DataBlockEncoding expectedDataBlockEncoding) throws IOException {
// Check cache for block. If found return.
BlockCache cache = cacheConf.getBlockCache().orElse(null);
+long cachedBlockBytesRead = 0;
if (cache != null) {
- HFileBlock cachedBlock = (HFileBlock) cache.getBlock(cacheKey,
cacheBlock, useLock,
-updateCacheMetrics, expectedBlockType);
- if (cachedBlock != null) {
-if
(cacheConf.shouldCacheCompressed(cachedBlock.getBlockType().getCategory())) {
- HFileBlock compressedBlock = cachedBlock;
- cachedBlock = compressedBlock.unpack(hfileContext, fsBlockReader);
- // In case of compressed block after unpacking we can release the
compressed block
- if (compressedBlock != cachedBlock) {
-compressedBlock.release();
+ HFileBlock cachedBlock = null;
+ boolean isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+ try {
+cachedBlock = (HFileBlock) cache.getBlock(cacheKey, cacheBlock,
useLock, updateCacheMetrics,
+ expectedBlockType);
+if (cachedBlock != null) {
+ if
(cacheConf.shouldCacheCompressed(cachedBlock.getBlockType().getCategory())) {
+HFileBlock compressedBlock = cachedBlock;
+cachedBlock = compressedBlock.unpack(hfileContext, fsBlockReader);
+// In case of compressed block after unpacking we can release the
compressed block
+if (compressedBlock != cachedBlock) {
+ compressedBlock.release();
+}
+ }
+ try {
+validateBlockType(cachedBlock, expectedBlockType);
+ } catch (IOException e) {
+returnAndEvictBlock(cache, cacheKey, cachedBlock);
+cachedBlock = null;
+throw e;
}
-}
-try {
- validateBlockType(cachedBlock, expectedBlockType);
-} catch (IOException e) {
- returnAndEvictBlock(cache, cacheKey, cachedBlock);
- throw e;
-}
-if (expectedDataBlockEncoding == null) {
- return cachedBlock;
-}
-DataBlockEncoding actualDataBlockEncoding =
cachedBlock.getDataBlockEncoding();
-// Block types other than data blocks always have
-// DataBlockEncoding.NONE. To avoid false negative cache misses, only
-// perform this check if cached block is a data block.
-if (
- cachedBlock.getBlockType().isData()
-&& !actualDataBlockEncoding.equals(expectedDataBlockEncoding)
-) {
- // This mismatch may happen if a Scanner, which is used for say a
- // compaction, tries to read an encoded block from the block cache.
- // The reverse might happen when an EncodedScanner tries to read
- // un-encoded blocks which were cached earlier.
- //
- // Because returning a data block with an implicit BlockType mismatch
- // will cause the requesting scanner to throw a disk read should be
- // forced here. This will potentially cause a significant number of
- // cache misses, so update so we should keep track of this as it
might
- // justify the work on a CompoundScanner.
+ if (expectedDataBlockEncoding == null) {
+return cachedBlock;
+ }
+ DataBlockEncoding actualDataBlockEncoding =
cachedBlock.getDataBlockEncoding();
+ // Block types other than data blocks always have
+ // DataBlockEncoding.NONE. To avoid false negative cache misses, only
+ // perform this check if cached block is a data block.
if (
-!expectedDataBlockEncoding.equals(DataBlockEncoding.NONE)
- && !actualDataBlockEncoding.equals(DataBlockEncoding.NONE)
+cachedBlock.getBlockType().isData()
+ && !actualDataBlockEncoding.equals(expectedDataBlockEncoding)
) {
-// If the block is encoded but the encoding does not match the
-// expected encoding it is likely the encoding was changed but the
-// block was not yet evicted. Evictions o
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Umeshkumar9414 commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2208510545
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##
@@ -1097,71 +1099,91 @@ public void setConf(Configuration conf) {
* Retrieve block from cache. Validates the retrieved block's type vs {@code
expectedBlockType}
* and its encoding vs. {@code expectedDataBlockEncoding}. Unpacks the block
as necessary.
*/
- private HFileBlock getCachedBlock(BlockCacheKey cacheKey, boolean
cacheBlock, boolean useLock,
+ @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.UNITTEST)
+ public HFileBlock getCachedBlock(BlockCacheKey cacheKey, boolean cacheBlock,
boolean useLock,
boolean updateCacheMetrics, BlockType expectedBlockType,
DataBlockEncoding expectedDataBlockEncoding) throws IOException {
// Check cache for block. If found return.
BlockCache cache = cacheConf.getBlockCache().orElse(null);
+long cachedBlockBytesRead = 0;
if (cache != null) {
- HFileBlock cachedBlock = (HFileBlock) cache.getBlock(cacheKey,
cacheBlock, useLock,
-updateCacheMetrics, expectedBlockType);
- if (cachedBlock != null) {
-if
(cacheConf.shouldCacheCompressed(cachedBlock.getBlockType().getCategory())) {
- HFileBlock compressedBlock = cachedBlock;
- cachedBlock = compressedBlock.unpack(hfileContext, fsBlockReader);
- // In case of compressed block after unpacking we can release the
compressed block
- if (compressedBlock != cachedBlock) {
-compressedBlock.release();
+ HFileBlock cachedBlock = null;
+ boolean isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+ try {
+cachedBlock = (HFileBlock) cache.getBlock(cacheKey, cacheBlock,
useLock, updateCacheMetrics,
+ expectedBlockType);
+if (cachedBlock != null) {
+ if
(cacheConf.shouldCacheCompressed(cachedBlock.getBlockType().getCategory())) {
+HFileBlock compressedBlock = cachedBlock;
+cachedBlock = compressedBlock.unpack(hfileContext, fsBlockReader);
+// In case of compressed block after unpacking we can release the
compressed block
+if (compressedBlock != cachedBlock) {
+ compressedBlock.release();
+}
+ }
+ try {
+validateBlockType(cachedBlock, expectedBlockType);
+ } catch (IOException e) {
+returnAndEvictBlock(cache, cacheKey, cachedBlock);
+cachedBlock = null;
+throw e;
}
-}
-try {
- validateBlockType(cachedBlock, expectedBlockType);
-} catch (IOException e) {
- returnAndEvictBlock(cache, cacheKey, cachedBlock);
- throw e;
-}
-if (expectedDataBlockEncoding == null) {
- return cachedBlock;
-}
-DataBlockEncoding actualDataBlockEncoding =
cachedBlock.getDataBlockEncoding();
-// Block types other than data blocks always have
-// DataBlockEncoding.NONE. To avoid false negative cache misses, only
-// perform this check if cached block is a data block.
-if (
- cachedBlock.getBlockType().isData()
-&& !actualDataBlockEncoding.equals(expectedDataBlockEncoding)
-) {
- // This mismatch may happen if a Scanner, which is used for say a
- // compaction, tries to read an encoded block from the block cache.
- // The reverse might happen when an EncodedScanner tries to read
- // un-encoded blocks which were cached earlier.
- //
- // Because returning a data block with an implicit BlockType mismatch
- // will cause the requesting scanner to throw a disk read should be
- // forced here. This will potentially cause a significant number of
- // cache misses, so update so we should keep track of this as it
might
- // justify the work on a CompoundScanner.
+ if (expectedDataBlockEncoding == null) {
+return cachedBlock;
+ }
+ DataBlockEncoding actualDataBlockEncoding =
cachedBlock.getDataBlockEncoding();
+ // Block types other than data blocks always have
+ // DataBlockEncoding.NONE. To avoid false negative cache misses, only
+ // perform this check if cached block is a data block.
if (
-!expectedDataBlockEncoding.equals(DataBlockEncoding.NONE)
- && !actualDataBlockEncoding.equals(DataBlockEncoding.NONE)
+cachedBlock.getBlockType().isData()
+ && !actualDataBlockEncoding.equals(expectedDataBlockEncoding)
) {
-// If the block is encoded but the encoding does not match the
-// expected encoding it is likely the encoding was changed but the
-// block was not yet evicted. Evictions
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
virajjasani commented on PR #7136: URL: https://github.com/apache/hbase/pull/7136#issuecomment-3074404883 Let me merge this today after few hours. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3073420602
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 29s | | master passed |
| +1 :green_heart: | compile | 1m 23s | | master passed |
| +1 :green_heart: | javadoc | 0m 50s | | master passed |
| +1 :green_heart: | shadedjars | 6m 17s | | branch has no errors when
building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 33s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 23s | | the patch passed |
| +1 :green_heart: | compile | 1m 29s | | the patch passed |
| +1 :green_heart: | javac | 1m 29s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 49s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 13s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 45s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 224m 21s | | hbase-server in the patch
passed. |
| | | 255m 45s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/10/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 2e03c45e4663 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a1b26b00239f9ebd259ea1d1740da9bf7402bce6 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/10/testReport/
|
| Max. process+thread count | 4993 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/10/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3072786054
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 26s | | master passed |
| +1 :green_heart: | compile | 4m 6s | | master passed |
| +1 :green_heart: | checkstyle | 0m 53s | | master passed |
| +1 :green_heart: | spotbugs | 2m 20s | | master passed |
| +1 :green_heart: | spotless | 0m 51s | | branch has no errors when
running spotless:check. |
| -0 :warning: | patch | 1m 4s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 7s | | the patch passed |
| +1 :green_heart: | compile | 4m 7s | | the patch passed |
| +1 :green_heart: | javac | 4m 7s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 52s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 31s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 12m 15s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 46s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 20s | | The patch does not
generate ASF License warnings. |
| | | 44m 19s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/10/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux beb96b1eb2bf 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a1b26b00239f9ebd259ea1d1740da9bf7402bce6 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 85 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/10/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3072363161
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 41s | | master passed |
| +1 :green_heart: | compile | 1m 25s | | master passed |
| +1 :green_heart: | javadoc | 0m 48s | | master passed |
| +1 :green_heart: | shadedjars | 6m 16s | | branch has no errors when
building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 33s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 20s | | the patch passed |
| +1 :green_heart: | compile | 1m 26s | | the patch passed |
| +1 :green_heart: | javac | 1m 26s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 48s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 14s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 45s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 224m 54s | | hbase-server in the patch
passed. |
| | | 256m 41s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/9/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 2cf8ab7c1ff7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / df1b9ee9c04b14aeaf18aaabb4cb8b9d8849d9a8 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/9/testReport/
|
| Max. process+thread count | 5362 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/9/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
virajjasani commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2206399653
##
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBytesReadServerSideScanMetrics.java:
##
@@ -0,0 +1,896 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.regionserver;
+
+import java.util.Collection;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.NavigableSet;
+import java.util.TreeSet;
+import java.util.concurrent.ThreadPoolExecutor;
+import java.util.function.Consumer;
+import org.apache.commons.lang3.mutable.MutableInt;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.hbase.CellComparator;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.HConstants;
+import org.apache.hadoop.hbase.KeyValue;
+import org.apache.hadoop.hbase.PrivateConstants;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder;
+import org.apache.hadoop.hbase.client.Put;
+import org.apache.hadoop.hbase.client.Result;
+import org.apache.hadoop.hbase.client.ResultScanner;
+import org.apache.hadoop.hbase.client.Scan;
+import org.apache.hadoop.hbase.client.Table;
+import org.apache.hadoop.hbase.client.TableDescriptorBuilder;
+import org.apache.hadoop.hbase.client.metrics.ScanMetrics;
+import org.apache.hadoop.hbase.executor.ExecutorType;
+import org.apache.hadoop.hbase.io.hfile.BlockCache;
+import org.apache.hadoop.hbase.io.hfile.BlockCacheKey;
+import org.apache.hadoop.hbase.io.hfile.BlockType;
+import org.apache.hadoop.hbase.io.hfile.CompoundBloomFilter;
+import org.apache.hadoop.hbase.io.hfile.FixedFileTrailer;
+import org.apache.hadoop.hbase.io.hfile.HFile;
+import org.apache.hadoop.hbase.io.hfile.HFileBlock;
+import org.apache.hadoop.hbase.io.hfile.HFileBlockIndex;
+import org.apache.hadoop.hbase.io.hfile.HFileContext;
+import org.apache.hadoop.hbase.io.hfile.LruBlockCache;
+import org.apache.hadoop.hbase.io.hfile.NoOpIndexBlockEncoder;
+import org.apache.hadoop.hbase.nio.ByteBuff;
+import org.apache.hadoop.hbase.testclassification.IOTests;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.util.BloomFilter;
+import org.apache.hadoop.hbase.util.BloomFilterUtil;
+import org.apache.hadoop.hbase.util.Bytes;
+import org.junit.Assert;
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.rules.TestName;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+@Category({ IOTests.class, LargeTests.class })
+public class TestBytesReadServerSideScanMetrics {
Review Comment:
Nice variety of tests!
##
hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/ThreadLocalServerSideScanMetrics.java:
##
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.monitoring;
+
+import java.util.concurrent.atomic.AtomicLong;
+import org.apache.hadoop.hbase.client.metrics.ServerSideScanMetrics;
+import org.apache.hadoop.hbase.regionserver.RegionScanner;
+import org.apache.hadoop.hbase.regionserver.ScannerContext;
+import org.apache.
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3071790886
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 19s | | master passed |
| +1 :green_heart: | compile | 4m 18s | | master passed |
| +1 :green_heart: | checkstyle | 0m 55s | | master passed |
| +1 :green_heart: | spotbugs | 2m 27s | | master passed |
| +1 :green_heart: | spotless | 0m 47s | | branch has no errors when
running spotless:check. |
| -0 :warning: | patch | 1m 0s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 19s | | the patch passed |
| +1 :green_heart: | compile | 4m 18s | | the patch passed |
| +1 :green_heart: | javac | 4m 18s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 55s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 43s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 12m 19s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 48s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 18s | | The patch does not
generate ASF License warnings. |
| | | 45m 25s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/9/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux afe0bf775e85 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / df1b9ee9c04b14aeaf18aaabb4cb8b9d8849d9a8 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/9/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3071728328
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 37s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 16s | | master passed |
| +1 :green_heart: | compile | 1m 38s | | master passed |
| +1 :green_heart: | javadoc | 1m 4s | | master passed |
| +1 :green_heart: | shadedjars | 7m 20s | | branch has no errors when
building our shaded downstream artifacts. |
| -0 :warning: | patch | 7m 39s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 53s | | the patch passed |
| +1 :green_heart: | compile | 1m 38s | | the patch passed |
| +1 :green_heart: | javac | 1m 38s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 52s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 16s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 59s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 227m 45s | | hbase-server in the patch
passed. |
| | | 263m 22s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/8/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 3d82dd3fe83d 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / df1b9ee9c04b14aeaf18aaabb4cb8b9d8849d9a8 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/8/testReport/
|
| Max. process+thread count | 5195 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/8/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
virajjasani commented on PR #7136: URL: https://github.com/apache/hbase/pull/7136#issuecomment-3071306384 @sanjeet006py i have this in my TODO list, i will get to it as soon as i can. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3071278333
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 35s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 25s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 17s | | master passed |
| +1 :green_heart: | compile | 5m 5s | | master passed |
| +1 :green_heart: | checkstyle | 1m 8s | | master passed |
| +1 :green_heart: | spotbugs | 3m 18s | | master passed |
| +1 :green_heart: | spotless | 1m 5s | | branch has no errors when
running spotless:check. |
| -0 :warning: | patch | 1m 21s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 4m 10s | | the patch passed |
| +1 :green_heart: | compile | 5m 27s | | the patch passed |
| +1 :green_heart: | javac | 5m 27s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 17s | | the patch passed |
| +1 :green_heart: | spotbugs | 3m 18s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 14m 50s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 55s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 21s | | The patch does not
generate ASF License warnings. |
| | | 55m 48s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/8/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 27551c49e137 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / df1b9ee9c04b14aeaf18aaabb4cb8b9d8849d9a8 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/8/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3068522759
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 37s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 32s | | master passed |
| +1 :green_heart: | compile | 1m 24s | | master passed |
| +1 :green_heart: | javadoc | 0m 45s | | master passed |
| +1 :green_heart: | shadedjars | 6m 7s | | branch has no errors when
building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 23s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 6s | | the patch passed |
| +1 :green_heart: | compile | 1m 22s | | the patch passed |
| +1 :green_heart: | javac | 1m 22s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 45s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 1s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 37s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 222m 42s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/7/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 253m 59s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/7/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux f0a2b646c365 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 75f90c67f5af657430e41c65e244af2705e9e911 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/7/testReport/
|
| Max. process+thread count | 5765 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/7/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3067890266
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 27s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 32s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 45s | | master passed |
| +1 :green_heart: | compile | 4m 25s | | master passed |
| +1 :green_heart: | checkstyle | 0m 58s | | master passed |
| +1 :green_heart: | spotbugs | 2m 33s | | master passed |
| +1 :green_heart: | spotless | 0m 52s | | branch has no errors when
running spotless:check. |
| -0 :warning: | patch | 1m 5s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 28s | | the patch passed |
| +1 :green_heart: | compile | 4m 15s | | the patch passed |
| +1 :green_heart: | javac | 4m 15s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 55s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 42s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 12m 29s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 48s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 18s | | The patch does not
generate ASF License warnings. |
| | | 46m 36s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/7/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 068bf91cc35e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 75f90c67f5af657430e41c65e244af2705e9e911 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 83 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/7/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3067446576
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 1m 1s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 38s | | master passed |
| +1 :green_heart: | compile | 2m 6s | | master passed |
| +1 :green_heart: | javadoc | 0m 46s | | master passed |
| +1 :green_heart: | shadedjars | 6m 26s | | branch has no errors when
building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 43s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 7s | | the patch passed |
| +1 :green_heart: | compile | 1m 18s | | the patch passed |
| +1 :green_heart: | javac | 1m 18s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 44s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 1s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 38s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 215m 45s | | hbase-server in the patch
passed. |
| | | 248m 54s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/6/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 77f22329613b 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b50414c0dd9e2073882eb84ffe8ff6a43d42da25 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/6/testReport/
|
| Max. process+thread count | 5114 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/6/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3067306254
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 26s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 36s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 49s | | master passed |
| +1 :green_heart: | compile | 4m 24s | | master passed |
| +1 :green_heart: | checkstyle | 0m 58s | | master passed |
| +1 :green_heart: | spotbugs | 2m 33s | | master passed |
| +1 :green_heart: | spotless | 0m 50s | | branch has no errors when
running spotless:check. |
| -0 :warning: | patch | 1m 3s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 22s | | the patch passed |
| +1 :green_heart: | compile | 4m 17s | | the patch passed |
| +1 :green_heart: | javac | 4m 17s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 39s |
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/6/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
| hbase-server: The patch generated 1 new + 32 unchanged - 0 fixed = 33 total
(was 32) |
| +1 :green_heart: | spotbugs | 2m 40s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 12m 26s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 49s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 18s | | The patch does not
generate ASF License warnings. |
| | | 46m 28s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/6/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux d94e36c8057f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / b50414c0dd9e2073882eb84ffe8ff6a43d42da25 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/6/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3062109065
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 15s | | master passed |
| +1 :green_heart: | compile | 1m 19s | | master passed |
| +1 :green_heart: | javadoc | 0m 44s | | master passed |
| +1 :green_heart: | shadedjars | 6m 2s | | branch has no errors when
building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 18s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 6s | | the patch passed |
| +1 :green_heart: | compile | 1m 19s | | the patch passed |
| +1 :green_heart: | javac | 1m 19s | | the patch passed |
| -0 :warning: | javadoc | 0m 17s |
[/results-javadoc-javadoc-hbase-client.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/5/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-hbase-client.txt)
| hbase-client generated 7 new + 28 unchanged - 0 fixed = 35 total (was 28) |
| +1 :green_heart: | shadedjars | 6m 1s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 38s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 214m 44s | | hbase-server in the patch
passed. |
| | | 244m 27s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 0241ea06fa30 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0b1da2dbbb7de0d8a71263468cbe6725aafda436 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/5/testReport/
|
| Max. process+thread count | 5170 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/5/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3061338514
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 19s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 6s | | master passed |
| +1 :green_heart: | compile | 4m 7s | | master passed |
| +1 :green_heart: | checkstyle | 0m 51s | | master passed |
| +1 :green_heart: | spotbugs | 2m 14s | | master passed |
| +1 :green_heart: | spotless | 0m 45s | | branch has no errors when
running spotless:check. |
| -0 :warning: | patch | 0m 57s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 8s | | the patch passed |
| +1 :green_heart: | compile | 4m 7s | | the patch passed |
| +1 :green_heart: | javac | 4m 7s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 51s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 26s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 11m 56s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 45s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 18s | | The patch does not
generate ASF License warnings. |
| | | 43m 23s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/5/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 227b470977ef 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 0b1da2dbbb7de0d8a71263468cbe6725aafda436 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 86 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/5/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3061092598
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 27s | | master passed |
| +1 :green_heart: | compile | 1m 19s | | master passed |
| +1 :green_heart: | javadoc | 0m 45s | | master passed |
| +1 :green_heart: | shadedjars | 6m 7s | | branch has no errors when
building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 23s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 9s | | the patch passed |
| +1 :green_heart: | compile | 1m 18s | | the patch passed |
| +1 :green_heart: | javac | 1m 18s | | the patch passed |
| -0 :warning: | javadoc | 0m 17s |
[/results-javadoc-javadoc-hbase-client.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/4/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-hbase-client.txt)
| hbase-client generated 7 new + 28 unchanged - 0 fixed = 35 total (was 28) |
| +1 :green_heart: | shadedjars | 6m 2s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 37s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 215m 3s | | hbase-server in the patch
passed. |
| | | 245m 16s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 94a7569572e0 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a0c4b7b91173ec9c012ec82e8eeaee4e87a159b2 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/4/testReport/
|
| Max. process+thread count | 5077 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/4/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3060453602
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 15s | | master passed |
| +1 :green_heart: | compile | 4m 4s | | master passed |
| +1 :green_heart: | checkstyle | 0m 52s | | master passed |
| +1 :green_heart: | spotbugs | 2m 14s | | master passed |
| +1 :green_heart: | spotless | 0m 49s | | branch has no errors when
running spotless:check. |
| -0 :warning: | patch | 1m 2s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 6s | | the patch passed |
| +1 :green_heart: | compile | 4m 5s | | the patch passed |
| +1 :green_heart: | javac | 4m 5s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 51s | | the patch passed |
| +1 :green_heart: | spotbugs | 2m 27s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 12m 0s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 45s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 18s | | The patch does not
generate ASF License warnings. |
| | | 43m 29s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/4/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 393f43ffec65 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / a0c4b7b91173ec9c012ec82e8eeaee4e87a159b2 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 85 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/4/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3059412991
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 33s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 16s | | master passed |
| +1 :green_heart: | compile | 1m 18s | | master passed |
| +1 :green_heart: | javadoc | 0m 46s | | master passed |
| +1 :green_heart: | shadedjars | 6m 5s | | branch has no errors when
building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 21s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 1s | | the patch passed |
| +1 :green_heart: | compile | 1m 17s | | the patch passed |
| +1 :green_heart: | javac | 1m 17s | | the patch passed |
| -0 :warning: | javadoc | 0m 17s |
[/results-javadoc-javadoc-hbase-client.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/3/artifact/yetus-jdk17-hadoop3-check/output/results-javadoc-javadoc-hbase-client.txt)
| hbase-client generated 7 new + 28 unchanged - 0 fixed = 35 total (was 28) |
| +1 :green_heart: | shadedjars | 6m 1s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 37s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 215m 11s | | hbase-server in the patch
passed. |
| | | 245m 18s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/3/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 7256dcd460a8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 2c5cedffb7469803cda9ca1e8a51226499ce2f19 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/3/testReport/
|
| Max. process+thread count | 5686 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/3/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3058728891
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 36s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 30s | | master passed |
| +1 :green_heart: | compile | 4m 12s | | master passed |
| +1 :green_heart: | checkstyle | 0m 54s | | master passed |
| +1 :green_heart: | spotbugs | 2m 22s | | master passed |
| +1 :green_heart: | spotless | 0m 49s | | branch has no errors when
running spotless:check. |
| -0 :warning: | patch | 1m 2s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 7s | | the patch passed |
| +1 :green_heart: | compile | 4m 14s | | the patch passed |
| +1 :green_heart: | javac | 4m 14s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 53s | | the patch passed |
| -1 :x: | spotbugs | 1m 42s |
[/new-spotbugs-hbase-server.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/3/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html)
| hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) |
| +1 :green_heart: | hadoopcheck | 12m 18s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 46s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 18s | | The patch does not
generate ASF License warnings. |
| | | 45m 13s | | |
| Reason | Tests |
|---:|:--|
| SpotBugs | module:hbase-server |
| | Write to static field
org.apache.hadoop.hbase.regionserver.StoreScanner.hasUpdatedReaders from
instance method
org.apache.hadoop.hbase.regionserver.StoreScanner.updateReaders(List, List) At
StoreScanner.java:from instance method
org.apache.hadoop.hbase.regionserver.StoreScanner.updateReaders(List, List) At
StoreScanner.java:[line 1040] |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux f8ea4e74f0ad 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 2c5cedffb7469803cda9ca1e8a51226499ce2f19 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/3/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on PR #7136: URL: https://github.com/apache/hbase/pull/7136#issuecomment-3058553141 @virajjasani the PR is ready for review. I have pushed the latest changes including suggestions from @haridsv. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
virajjasani commented on PR #7136: URL: https://github.com/apache/hbase/pull/7136#issuecomment-3055474649 I will start the review soon after @sanjeet006py pushes the latest changes. This is nice approach! The metrics are capturing some of the very fundamental details and should be quite helpful! FYI @Apache9 if you are also interested to look into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2190312631
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/ParallelSeekHandler.java:
##
@@ -46,12 +51,25 @@ public ParallelSeekHandler(KeyValueScanner scanner,
ExtendedCell keyValue, long
this.keyValue = keyValue;
this.readPoint = readPoint;
this.latch = latch;
+this.isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+this.bytesReadFromFs =
ThreadLocalServerSideScanMetrics.getBytesReadFromFsCounter();
+this.bytesReadFromBlockCache =
+ ThreadLocalServerSideScanMetrics.getBytesReadFromBlockCacheCounter();
}
@Override
public void process() {
try {
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+ if (isScanMetricsEnabled) {
+ThreadLocalServerSideScanMetrics.reset();
+ }
scanner.seek(keyValue);
Review Comment:
All the StoreFileScanners are placed at the row AtOrAfter the start row of
the scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2190271949
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##
@@ -145,7 +150,18 @@ private static boolean hasNonce(HRegion region, long
nonce) {
} finally {
region.smallestReadPointCalcLock.unlock(ReadPointCalculationLock.LockType.RECORDING_LOCK);
}
+boolean isScanMetricsEnabled = scan.isScanMetricsEnabled();
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+if (isScanMetricsEnabled) {
+ ThreadLocalServerSideScanMetrics.reset();
+}
initializeScanners(scan, additionalScanners);
+if (isScanMetricsEnabled) {
+ bytesReadFromFs +=
ThreadLocalServerSideScanMetrics.getBytesReadFromFsAndReset();
Review Comment:
I did step through these operations all the way to block read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
haridsv commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2190249013
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##
@@ -145,7 +150,18 @@ private static boolean hasNonce(HRegion region, long
nonce) {
} finally {
region.smallestReadPointCalcLock.unlock(ReadPointCalculationLock.LockType.RECORDING_LOCK);
}
+boolean isScanMetricsEnabled = scan.isScanMetricsEnabled();
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+if (isScanMetricsEnabled) {
+ ThreadLocalServerSideScanMetrics.reset();
+}
initializeScanners(scan, additionalScanners);
+if (isScanMetricsEnabled) {
+ bytesReadFromFs +=
ThreadLocalServerSideScanMetrics.getBytesReadFromFsAndReset();
Review Comment:
I meant from the logic, did you step through and see what read operations
were happening? Or is it just that you happened to see non-zero value at this
point and decided to capture the value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2190183481
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##
@@ -145,7 +150,18 @@ private static boolean hasNonce(HRegion region, long
nonce) {
} finally {
region.smallestReadPointCalcLock.unlock(ReadPointCalculationLock.LockType.RECORDING_LOCK);
}
+boolean isScanMetricsEnabled = scan.isScanMetricsEnabled();
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+if (isScanMetricsEnabled) {
+ ThreadLocalServerSideScanMetrics.reset();
+}
initializeScanners(scan, additionalScanners);
+if (isScanMetricsEnabled) {
+ bytesReadFromFs +=
ThreadLocalServerSideScanMetrics.getBytesReadFromFsAndReset();
Review Comment:
Currently, we can't but we can pass the context to identify if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
haridsv commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185777653
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##
@@ -145,7 +150,18 @@ private static boolean hasNonce(HRegion region, long
nonce) {
} finally {
region.smallestReadPointCalcLock.unlock(ReadPointCalculationLock.LockType.RECORDING_LOCK);
}
+boolean isScanMetricsEnabled = scan.isScanMetricsEnabled();
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+if (isScanMetricsEnabled) {
+ ThreadLocalServerSideScanMetrics.reset();
+}
initializeScanners(scan, additionalScanners);
+if (isScanMetricsEnabled) {
+ bytesReadFromFs +=
ThreadLocalServerSideScanMetrics.getBytesReadFromFsAndReset();
Review Comment:
That is true, trailer and load-on-open blocks should have been already
loaded at the time of the region open.
> Reads happening during StoreScanner init are not special in any way in my
opinion
Can you identify the exact reads that happen during this initialization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185574409
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##
@@ -145,7 +150,18 @@ private static boolean hasNonce(HRegion region, long
nonce) {
} finally {
region.smallestReadPointCalcLock.unlock(ReadPointCalculationLock.LockType.RECORDING_LOCK);
}
+boolean isScanMetricsEnabled = scan.isScanMetricsEnabled();
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+if (isScanMetricsEnabled) {
+ ThreadLocalServerSideScanMetrics.reset();
+}
initializeScanners(scan, additionalScanners);
+if (isScanMetricsEnabled) {
+ bytesReadFromFs +=
ThreadLocalServerSideScanMetrics.getBytesReadFromFsAndReset();
Review Comment:
Reads happening during StoreScanner init are not special in any way in my
opinion. They also add to the latency like how any other block seek will add.
So, I don't see a value add in tracking them separately. Also, for tracking
bytesRead for trailer and load-on-open section, as that will happen outside of
user triggered read path so, there also I feel we don't need to track
separately. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
haridsv commented on PR #7136: URL: https://github.com/apache/hbase/pull/7136#issuecomment-3036176193 As discussed offline, it would be nice to expose the seekCount from StoreFileScanner as a metric. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
haridsv commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185301441
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##
@@ -145,7 +150,18 @@ private static boolean hasNonce(HRegion region, long
nonce) {
} finally {
region.smallestReadPointCalcLock.unlock(ReadPointCalculationLock.LockType.RECORDING_LOCK);
}
+boolean isScanMetricsEnabled = scan.isScanMetricsEnabled();
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+if (isScanMetricsEnabled) {
+ ThreadLocalServerSideScanMetrics.reset();
+}
initializeScanners(scan, additionalScanners);
+if (isScanMetricsEnabled) {
+ bytesReadFromFs +=
ThreadLocalServerSideScanMetrics.getBytesReadFromFsAndReset();
Review Comment:
Got it! Never the less, my comment is mainly about this: "if we track it
separately, it can give insights into the occasional spikes in latencies that
are the result of these cache evictions."
If you agree on the above, we can also put the reads that happen during the
initialization of HStore also in the same bucket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
haridsv commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185282798
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##
@@ -1114,6 +1115,15 @@ private HFileBlock getCachedBlock(BlockCacheKey
cacheKey, boolean cacheBlock, bo
compressedBlock.release();
}
}
+boolean isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+if (isScanMetricsEnabled) {
+ int cachedBlockBytesRead = cachedBlock.getOnDiskSizeWithHeader();
+ // Account for the header size of the next block if it exists
+ if (cachedBlock.getNextBlockOnDiskSize() > 0) {
+cachedBlockBytesRead += cachedBlock.headerSize();
+ }
+
ThreadLocalServerSideScanMetrics.addBytesReadFromBlockCache(cachedBlockBytesRead);
+}
Review Comment:
The standalone count from MemStore/BlockCache is not important from
understanding the performance characteristics, as they don't cost much so I
feel these counts are more useful for accounting purpose (more for cross
checking), so it is better to represent the actual count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
haridsv commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185276378
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/ParallelSeekHandler.java:
##
@@ -46,12 +51,25 @@ public ParallelSeekHandler(KeyValueScanner scanner,
ExtendedCell keyValue, long
this.keyValue = keyValue;
this.readPoint = readPoint;
this.latch = latch;
+this.isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+this.bytesReadFromFs =
ThreadLocalServerSideScanMetrics.getBytesReadFromFsCounter();
+this.bytesReadFromBlockCache =
+ ThreadLocalServerSideScanMetrics.getBytesReadFromBlockCacheCounter();
}
@Override
public void process() {
try {
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+ if (isScanMetricsEnabled) {
+ThreadLocalServerSideScanMetrics.reset();
+ }
scanner.seek(keyValue);
Review Comment:
No, I mean to ask what disk read activity would happen as part of the seek().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
haridsv commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185274903
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java:
##
@@ -336,22 +337,40 @@ private Segment getSegment() {
*/
protected void updateCurrent() {
ExtendedCell next = null;
+boolean isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+int totalBytesRead = 0;
try {
while (iter.hasNext()) {
next = iter.next();
+if (isScanMetricsEnabled) {
+ // Batch collect bytes to reduce method call overhead
+ totalBytesRead += Segment.getCellLength(next);
+}
if (next.getSequenceId() <= this.readPoint) {
current = next;
+ // Add accumulated bytes before returning
+ if (isScanMetricsEnabled && totalBytesRead > 0) {
+
ThreadLocalServerSideScanMetrics.addBytesReadFromMemstore(totalBytesRead);
+ }
return;// skip irrelevant versions
}
// for backwardSeek() stay in the boundaries of a single row
if (stopSkippingKVsIfNextRow && segment.compareRows(next,
stopSkippingKVsRow) > 0) {
current = null;
+ // Add accumulated bytes before returning
+ if (isScanMetricsEnabled && totalBytesRead > 0) {
+
ThreadLocalServerSideScanMetrics.addBytesReadFromMemstore(totalBytesRead);
+ }
return;
}
} // end of while
current = null; // nothing found
+ // Add accumulated bytes at the end
+ if (isScanMetricsEnabled && totalBytesRead > 0) {
+
ThreadLocalServerSideScanMetrics.addBytesReadFromMemstore(totalBytesRead);
+ }
Review Comment:
OK, I misread it, but I guess this can also go away if you follow my above
recommendation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185162014
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/handler/ParallelSeekHandler.java:
##
@@ -46,12 +51,25 @@ public ParallelSeekHandler(KeyValueScanner scanner,
ExtendedCell keyValue, long
this.keyValue = keyValue;
this.readPoint = readPoint;
this.latch = latch;
+this.isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+this.bytesReadFromFs =
ThreadLocalServerSideScanMetrics.getBytesReadFromFsCounter();
+this.bytesReadFromBlockCache =
+ ThreadLocalServerSideScanMetrics.getBytesReadFromBlockCacheCounter();
}
@Override
public void process() {
try {
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+ if (isScanMetricsEnabled) {
+ThreadLocalServerSideScanMetrics.reset();
+ }
scanner.seek(keyValue);
Review Comment:
You mean when is `ParallelSeekHandler` used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185159074
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##
@@ -1114,6 +1115,15 @@ private HFileBlock getCachedBlock(BlockCacheKey
cacheKey, boolean cacheBlock, bo
compressedBlock.release();
}
}
+boolean isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+if (isScanMetricsEnabled) {
+ int cachedBlockBytesRead = cachedBlock.getOnDiskSizeWithHeader();
+ // Account for the header size of the next block if it exists
+ if (cachedBlock.getNextBlockOnDiskSize() > 0) {
+cachedBlockBytesRead += cachedBlock.headerSize();
+ }
+
ThreadLocalServerSideScanMetrics.addBytesReadFromBlockCache(cachedBlockBytesRead);
+}
Review Comment:
Actually, I intentionally placed the code such that those blocks are also
counted. I don't have any specific reason for current approach but intent was
to capture any bytes read whether useful or non-useful. But I do see value in
your suggestion. If we don't count invalid blocks then whenever such invalid
blocks be encountered we will see drop in `bytesReadFromBlockcache` metric
which won't happen in current approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185142986
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1754,6 +1758,9 @@ protected HFileBlock
readBlockDataInternal(FSDataInputStream is, long offset,
headerBuf = HEAP.allocate(hdrSize);
readAtOffset(is, headerBuf, hdrSize, false, offset, pread);
headerBuf.rewind();
+ if (isScanMetricsEnabled) {
+ThreadLocalServerSideScanMetrics.addBytesReadFromFs(hdrSize);
+ }
Review Comment:
Yeah, I also thought so but then I noticed (also mentioned in comment) that
this will typically be called when we open a HFile fresh for first time and
starting to read it from its load-on-open data section as at that time we
specify on disk size as -1. So, I don't expect this to happen in a user
triggered read path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185128891
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/CompoundBloomFilter.java:
##
@@ -120,7 +120,7 @@ private boolean containsInternal(byte[] key, int keyOffset,
int keyLength, ByteB
return result;
}
- private HFileBlock getBloomBlock(int block) {
+ public HFileBlock getBloomBlock(int block) {
Review Comment:
> You are making this and others and a few others public for the sake of
testing?
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185124589
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java:
##
@@ -336,22 +337,40 @@ private Segment getSegment() {
*/
protected void updateCurrent() {
ExtendedCell next = null;
+boolean isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+int totalBytesRead = 0;
try {
while (iter.hasNext()) {
next = iter.next();
+if (isScanMetricsEnabled) {
+ // Batch collect bytes to reduce method call overhead
+ totalBytesRead += Segment.getCellLength(next);
+}
if (next.getSequenceId() <= this.readPoint) {
current = next;
+ // Add accumulated bytes before returning
+ if (isScanMetricsEnabled && totalBytesRead > 0) {
+
ThreadLocalServerSideScanMetrics.addBytesReadFromMemstore(totalBytesRead);
+ }
return;// skip irrelevant versions
}
// for backwardSeek() stay in the boundaries of a single row
if (stopSkippingKVsIfNextRow && segment.compareRows(next,
stopSkippingKVsRow) > 0) {
current = null;
+ // Add accumulated bytes before returning
+ if (isScanMetricsEnabled && totalBytesRead > 0) {
+
ThreadLocalServerSideScanMetrics.addBytesReadFromMemstore(totalBytesRead);
+ }
return;
}
} // end of while
current = null; // nothing found
+ // Add accumulated bytes at the end
+ if (isScanMetricsEnabled && totalBytesRead > 0) {
+
ThreadLocalServerSideScanMetrics.addBytesReadFromMemstore(totalBytesRead);
+ }
Review Comment:
This is outside the loop, right? I didn't get what you meant by loop is
continuing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2185116384
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java:
##
@@ -145,7 +150,18 @@ private static boolean hasNonce(HRegion region, long
nonce) {
} finally {
region.smallestReadPointCalcLock.unlock(ReadPointCalculationLock.LockType.RECORDING_LOCK);
}
+boolean isScanMetricsEnabled = scan.isScanMetricsEnabled();
+
ThreadLocalServerSideScanMetrics.setScanMetricsEnabled(isScanMetricsEnabled);
+if (isScanMetricsEnabled) {
+ ThreadLocalServerSideScanMetrics.reset();
+}
initializeScanners(scan, additionalScanners);
+if (isScanMetricsEnabled) {
+ bytesReadFromFs +=
ThreadLocalServerSideScanMetrics.getBytesReadFromFsAndReset();
Review Comment:
> This corresponds to any bytes read for trailer and metadata, which will
only happen if the file is being read the first time or if the cached
information is ejected correct?
No, as part of init of RegionScanner we init the StoreScanner. Init of
StoreScanner involves reading bloom filters and seeking on StoreFileScanners
and memstore scanners to the start of first row in scan. Trailer and HFile
metadata is already loaded by this as I see its loaded when HStore is created
as part of region open or when its committed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on code in PR #7136: URL: https://github.com/apache/hbase/pull/7136#discussion_r2185084812 ## hbase-client/src/main/java/org/apache/hadoop/hbase/client/metrics/ThreadLocalServerSideScanMetrics.java: ## @@ -0,0 +1,117 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.client.metrics; + +import java.util.concurrent.atomic.AtomicInteger; +import org.apache.yetus.audience.InterfaceAudience; + [email protected] +public final class ThreadLocalServerSideScanMetrics { + private ThreadLocalServerSideScanMetrics() { + } + + private static final ThreadLocal isScanMetricsEnabled = new ThreadLocal<>() { +@Override +protected Boolean initialValue() { + return false; +} + }; + + private static final ThreadLocal bytesReadFromFs = new ThreadLocal<>() { +@Override +protected AtomicInteger initialValue() { + return new AtomicInteger(0); +} + }; + + private static final ThreadLocal bytesReadFromBlockCache = new ThreadLocal<>() { +@Override +protected AtomicInteger initialValue() { + return new AtomicInteger(0); +} + }; + + private static final ThreadLocal bytesReadFromMemstore = new ThreadLocal<>() { +@Override +protected AtomicInteger initialValue() { + return new AtomicInteger(0); +} + }; + + public static final void setScanMetricsEnabled(boolean enable) { +isScanMetricsEnabled.set(enable); + } + + public static final int addBytesReadFromFs(int bytes) { +return bytesReadFromFs.get().addAndGet(bytes); + } + + public static final int addBytesReadFromBlockCache(int bytes) { +return bytesReadFromBlockCache.get().addAndGet(bytes); + } + + public static final int addBytesReadFromMemstore(int bytes) { +return bytesReadFromMemstore.get().addAndGet(bytes); + } + + public static final boolean isScanMetricsEnabled() { +return isScanMetricsEnabled.get(); + } + + public static final AtomicInteger getBytesReadFromFsCounter() { +return bytesReadFromFs.get(); + } + + public static final AtomicInteger getBytesReadFromBlockCacheCounter() { +return bytesReadFromBlockCache.get(); + } + + public static final AtomicInteger getBytesReadFromMemstoreCounter() { +return bytesReadFromMemstore.get(); + } + + public static final int getBytesReadFromFsAndReset() { +return getBytesReadFromFsCounter().getAndSet(0); + } + + public static final int getBytesReadFromBlockCacheAndReset() { +return getBytesReadFromBlockCacheCounter().getAndSet(0); + } + + public static final int getBytesReadFromMemstoreAndReset() { +return getBytesReadFromMemstoreCounter().getAndSet(0); + } + + public static final void reset() { +getBytesReadFromFsAndReset(); +getBytesReadFromBlockCacheAndReset(); +getBytesReadFromMemstoreAndReset(); Review Comment: Yes these are the handler threads on RS used for scans and gets. I don't think these threads will be used for any other purpose apart from scans and gets. This `reset` method is typically called by the thread at the start of execution to make sure it starts fresh. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
haridsv commented on code in PR #7136:
URL: https://github.com/apache/hbase/pull/7136#discussion_r2184703931
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java:
##
@@ -1754,6 +1758,9 @@ protected HFileBlock
readBlockDataInternal(FSDataInputStream is, long offset,
headerBuf = HEAP.allocate(hdrSize);
readAtOffset(is, headerBuf, hdrSize, false, offset, pread);
headerBuf.rewind();
+ if (isScanMetricsEnabled) {
+ThreadLocalServerSideScanMetrics.addBytesReadFromFs(hdrSize);
+ }
Review Comment:
Per the comment above, this block should get executed very rarely and when
that happens it would end up being costly. I wonder if we should actually have
a warning and monitor for such occurrences. This is of course unrelated to the
current PR, but starting a discussion anyway.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SegmentScanner.java:
##
@@ -336,22 +337,40 @@ private Segment getSegment() {
*/
protected void updateCurrent() {
ExtendedCell next = null;
+boolean isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+int totalBytesRead = 0;
try {
while (iter.hasNext()) {
next = iter.next();
+if (isScanMetricsEnabled) {
+ // Batch collect bytes to reduce method call overhead
+ totalBytesRead += Segment.getCellLength(next);
+}
if (next.getSequenceId() <= this.readPoint) {
current = next;
+ // Add accumulated bytes before returning
+ if (isScanMetricsEnabled && totalBytesRead > 0) {
+
ThreadLocalServerSideScanMetrics.addBytesReadFromMemstore(totalBytesRead);
+ }
return;// skip irrelevant versions
}
// for backwardSeek() stay in the boundaries of a single row
if (stopSkippingKVsIfNextRow && segment.compareRows(next,
stopSkippingKVsRow) > 0) {
current = null;
+ // Add accumulated bytes before returning
+ if (isScanMetricsEnabled && totalBytesRead > 0) {
+
ThreadLocalServerSideScanMetrics.addBytesReadFromMemstore(totalBytesRead);
+ }
return;
}
} // end of while
current = null; // nothing found
+ // Add accumulated bytes at the end
+ if (isScanMetricsEnabled && totalBytesRead > 0) {
+
ThreadLocalServerSideScanMetrics.addBytesReadFromMemstore(totalBytesRead);
+ }
Review Comment:
The loop is continuing so might accumulate more, so adding here seems
incorrect especially that we are not reseting `totalBytesRead`, besides it will
get added again anyway when the loop ends, am I missing something?
##
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java:
##
@@ -1114,6 +1115,15 @@ private HFileBlock getCachedBlock(BlockCacheKey
cacheKey, boolean cacheBlock, bo
compressedBlock.release();
}
}
+boolean isScanMetricsEnabled =
ThreadLocalServerSideScanMetrics.isScanMetricsEnabled();
+if (isScanMetricsEnabled) {
+ int cachedBlockBytesRead = cachedBlock.getOnDiskSizeWithHeader();
+ // Account for the header size of the next block if it exists
+ if (cachedBlock.getNextBlockOnDiskSize() > 0) {
+cachedBlockBytesRead += cachedBlock.headerSize();
+ }
+
ThreadLocalServerSideScanMetrics.addBytesReadFromBlockCache(cachedBlockBytesRead);
+}
Review Comment:
A nit observation is that the block may get evicted if the block encoding
doesn't match expected encoding, which I think will happen in case the encoding
format gets changed since the time the blocks were cached. This should result
in the block getting read from the disk anyway, so we could avoid counting
these blocks.
##
hbase-client/src/main/java/org/apache/hadoop/hbase/client/metrics/ThreadLocalServerSideScanMetrics.java:
##
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.client.metrics;
+
+import java.util.concurrent.atomic.Atomi
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3033358771
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 31s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 19s | | master passed |
| +1 :green_heart: | compile | 1m 20s | | master passed |
| +1 :green_heart: | javadoc | 0m 45s | | master passed |
| +1 :green_heart: | shadedjars | 6m 9s | | branch has no errors when
building our shaded downstream artifacts. |
| -0 :warning: | patch | 6m 25s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 13s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 7s | | the patch passed |
| +1 :green_heart: | compile | 1m 18s | | the patch passed |
| +1 :green_heart: | javac | 1m 18s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 44s | | the patch passed |
| +1 :green_heart: | shadedjars | 6m 3s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 1m 37s | | hbase-client in the patch
passed. |
| -1 :x: | unit | 234m 34s |
[/patch-unit-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt)
| hbase-server in the patch failed. |
| | | 266m 11s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux 4c887bb2879c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 33f19628c56bc5a7b599c78953cd435f100759bd |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/2/testReport/
|
| Max. process+thread count | 4791 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/2/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3032757363
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 36s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 6s | | master passed |
| +1 :green_heart: | compile | 4m 43s | | master passed |
| +1 :green_heart: | checkstyle | 0m 57s | | master passed |
| +1 :green_heart: | spotbugs | 2m 45s | | master passed |
| +1 :green_heart: | spotless | 1m 2s | | branch has no errors when
running spotless:check. |
| -0 :warning: | patch | 1m 17s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 47s | | the patch passed |
| +1 :green_heart: | compile | 5m 0s | | the patch passed |
| +1 :green_heart: | javac | 5m 0s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 50s |
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/2/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
| hbase-server: The patch generated 2 new + 25 unchanged - 0 fixed = 27 total
(was 25) |
| +1 :green_heart: | spotbugs | 3m 43s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 15m 3s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 0m 59s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 25s | | The patch does not
generate ASF License warnings. |
| | | 54m 6s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/2/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux 98aa35ae6200 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 33f19628c56bc5a7b599c78953cd435f100759bd |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 84 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/2/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
sanjeet006py commented on PR #7136: URL: https://github.com/apache/hbase/pull/7136#issuecomment-3032051689 @virajjasani I did performance testing also for the new metrics added to ensure the read paths where we are reading from in-memory have not regressed: https://docs.google.com/document/d/14IPxbdHQq1TBXbVJHVv-MmJfYH2QI2SluXv5y_q_Fpg/edit?usp=sharing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3021569653
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 35s | | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | | Unprocessed flag(s):
--brief-report-file --spotbugs-strict-precheck --author-ignore-list
--blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck |
_ Prechecks _ |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 11s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 4m 11s | | master passed |
| +1 :green_heart: | compile | 1m 41s | | master passed |
| +1 :green_heart: | javadoc | 0m 56s | | master passed |
| +1 :green_heart: | shadedjars | 7m 20s | | branch has no errors when
building our shaded downstream artifacts. |
| -0 :warning: | patch | 7m 41s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 14s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 53s | | the patch passed |
| +1 :green_heart: | compile | 1m 39s | | the patch passed |
| +1 :green_heart: | javac | 1m 39s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 52s | | the patch passed |
| +1 :green_heart: | shadedjars | 7m 5s | | patch has no errors when
building our shaded downstream artifacts. |
_ Other Tests _ |
| +1 :green_heart: | unit | 2m 18s | | hbase-client in the patch
passed. |
| +1 :green_heart: | unit | 242m 44s | | hbase-server in the patch
passed. |
| | | 279m 15s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | javac javadoc unit compile shadedjars |
| uname | Linux ce2f4d2cdad7 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 01b7bf3e2525ddbd61512ccf1d8a5873c6c67515 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Test Results |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/1/testReport/
|
| Max. process+thread count | 4492 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/1/console
|
| versions | git=2.34.1 maven=3.9.8 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29398: Server side scan metrics for bytes read from FS vs Block cache vs memstore [hbase]
Apache-HBase commented on PR #7136:
URL: https://github.com/apache/hbase/pull/7136#issuecomment-3021092889
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|::|--:|:|::|:---:|
| +0 :ok: | reexec | 0m 30s | | Docker mode activated. |
_ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | hbaseanti | 0m 0s | | Patch does not have any
anti-patterns. |
_ master Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 3m 14s | | master passed |
| +1 :green_heart: | compile | 4m 13s | | master passed |
| -0 :warning: | checkstyle | 0m 12s |
[/buildtool-branch-checkstyle-hbase-client.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/1/artifact/yetus-general-check/output/buildtool-branch-checkstyle-hbase-client.txt)
| The patch fails to run checkstyle in hbase-client |
| +1 :green_heart: | spotbugs | 2m 17s | | master passed |
| +1 :green_heart: | spotless | 0m 50s | | branch has no errors when
running spotless:check. |
| -0 :warning: | patch | 1m 2s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
_ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 12s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 3m 24s | | the patch passed |
| +1 :green_heart: | compile | 5m 9s | | the patch passed |
| +1 :green_heart: | javac | 5m 9s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| -0 :warning: | checkstyle | 0m 18s |
[/buildtool-patch-checkstyle-hbase-client.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-hbase-client.txt)
| The patch fails to run checkstyle in hbase-client |
| -0 :warning: | checkstyle | 1m 0s |
[/results-checkstyle-hbase-server.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/1/artifact/yetus-general-check/output/results-checkstyle-hbase-server.txt)
| hbase-server: The patch generated 2 new + 25 unchanged - 0 fixed = 27 total
(was 25) |
| +1 :green_heart: | spotbugs | 3m 3s | | the patch passed |
| +1 :green_heart: | hadoopcheck | 15m 53s | | Patch does not cause any
errors with Hadoop 3.3.6 3.4.0. |
| +1 :green_heart: | spotless | 1m 4s | | patch has no errors when
running spotless:check. |
_ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 21s | | The patch does not
generate ASF License warnings. |
| | | 52m 15s | | |
| Subsystem | Report/Notes |
|--:|:-|
| Docker | ClientAPI=1.43 ServerAPI=1.43 base:
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/hbase/pull/7136 |
| JIRA Issue | HBASE-29398 |
| Optional Tests | dupname asflicense javac spotbugs checkstyle codespell
detsecrets compile hadoopcheck hbaseanti spotless |
| uname | Linux fe7bdce12c1f 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May
23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 01b7bf3e2525ddbd61512ccf1d8a5873c6c67515 |
| Default Java | Eclipse Adoptium-17.0.11+9 |
| Max. process+thread count | 85 (vs. ulimit of 3) |
| modules | C: hbase-client hbase-server U: . |
| Console output |
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7136/1/console
|
| versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 |
| Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
