Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid merged PR #7952: URL: https://github.com/apache/hbase/pull/7952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on code in PR #7952:
URL: https://github.com/apache/hbase/pull/7952#discussion_r3467979874
##
dev-support/hbase-personality.sh:
##
@@ -290,6 +290,60 @@ function personality_modules
done
}
+# This is a workaround to fix the author check until YETUS-1266 is released.
+# TODO: Remove this when we upgraded to Yetus having YETUS-1266!
+## @description Check the current directory for author tags
+## @audience private
+## @stabilityevolving
+## @replaceable no
+## @return 0 on success
+## @return 1 on failure
+function author_postcompile
+{
+ # shellcheck disable=SC2155
+ declare -r appname=$(basename "${BASH_SOURCE-$0}")
+ declare -a globalignore
+
+ if [[ "${BUILDMODE}" != full ]]; then
+return
+ fi
+
+ big_console_header "Checking for @author tags: ${BUILDMODE}"
+
+ start_clock
+
+ if [[ -f "${PATCH_DIR}/excluded.txt" ]]; then
+globalignore=("${GREP}" "-v" "-f" "${PATCH_DIR}/excluded.txt")
+ else
+globalignore=("cat")
+ fi
+
+ "${GIT}" grep -n -I --extended-regexp -i -e '^[^-].*@author' \
+| "${GREP}" -v "${appname}" \
+| "${globalignore[@]}" \
+>> "${PATCH_DIR}/author-tags-git.txt"
+
+ if [[ -z "${AUTHOR_IGNORE_LIST[0]}" ]]; then
+cp -p "${PATCH_DIR}/author-tags-git.txt" "${PATCH_DIR}/${AUTHOR_LOGNAME}"
+ else
+for i in "${AUTHOR_IGNORE_LIST[@]}"; do
+ printf "%s\n" "${i}"
+done \
+ | "${SED}" 's/[][\\.^$*+?{}()|]/\\&/g' \
+ | "${SED}" 's/^/^/' \
+ > "${PATCH_DIR}/author-tags-filter.txt"
+
+cat "${PATCH_DIR}/author-tags-filter.txt"
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on code in PR #7952:
URL: https://github.com/apache/hbase/pull/7952#discussion_r3467950791
##
dev-support/hbase-personality.sh:
##
@@ -290,6 +290,60 @@ function personality_modules
done
}
+# This is a workaround to fix the author check until YETUS-1266 is released.
+# TODO: Remove this when we upgraded to Yetus having YETUS-1266!
+## @description Check the current directory for author tags
+## @audience private
+## @stabilityevolving
+## @replaceable no
+## @return 0 on success
+## @return 1 on failure
+function author_postcompile
+{
+ # shellcheck disable=SC2155
+ declare -r appname=$(basename "${BASH_SOURCE-$0}")
+ declare -a globalignore
+
+ if [[ "${BUILDMODE}" != full ]]; then
+return
+ fi
+
+ big_console_header "Checking for @author tags: ${BUILDMODE}"
+
+ start_clock
+
+ if [[ -f "${PATCH_DIR}/excluded.txt" ]]; then
+globalignore=("${GREP}" "-v" "-f" "${PATCH_DIR}/excluded.txt")
+ else
+globalignore=("cat")
+ fi
+
+ "${GIT}" grep -n -I --extended-regexp -i -e '^[^-].*@author' \
+| "${GREP}" -v "${appname}" \
+| "${globalignore[@]}" \
+>> "${PATCH_DIR}/author-tags-git.txt"
+
+ if [[ -z "${AUTHOR_IGNORE_LIST[0]}" ]]; then
+cp -p "${PATCH_DIR}/author-tags-git.txt" "${PATCH_DIR}/${AUTHOR_LOGNAME}"
+ else
+for i in "${AUTHOR_IGNORE_LIST[@]}"; do
+ printf "%s\n" "${i}"
+done \
+ | "${SED}" 's/[][\\.^$*+?{}()|]/\\&/g' \
+ | "${SED}" 's/^/^/' \
+ > "${PATCH_DIR}/author-tags-filter.txt"
+
+cat "${PATCH_DIR}/author-tags-filter.txt"
Review Comment:
Nice catch, thanks. Will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
ndimiduk commented on code in PR #7952:
URL: https://github.com/apache/hbase/pull/7952#discussion_r3467661545
##
dev-support/hbase-personality.sh:
##
@@ -290,6 +290,60 @@ function personality_modules
done
}
+# This is a workaround to fix the author check until YETUS-1266 is released.
+# TODO: Remove this when we upgraded to Yetus having YETUS-1266!
+## @description Check the current directory for author tags
+## @audience private
+## @stabilityevolving
+## @replaceable no
+## @return 0 on success
+## @return 1 on failure
+function author_postcompile
+{
+ # shellcheck disable=SC2155
+ declare -r appname=$(basename "${BASH_SOURCE-$0}")
+ declare -a globalignore
+
+ if [[ "${BUILDMODE}" != full ]]; then
+return
+ fi
+
+ big_console_header "Checking for @author tags: ${BUILDMODE}"
+
+ start_clock
+
+ if [[ -f "${PATCH_DIR}/excluded.txt" ]]; then
+globalignore=("${GREP}" "-v" "-f" "${PATCH_DIR}/excluded.txt")
+ else
+globalignore=("cat")
+ fi
+
+ "${GIT}" grep -n -I --extended-regexp -i -e '^[^-].*@author' \
+| "${GREP}" -v "${appname}" \
+| "${globalignore[@]}" \
+>> "${PATCH_DIR}/author-tags-git.txt"
+
+ if [[ -z "${AUTHOR_IGNORE_LIST[0]}" ]]; then
+cp -p "${PATCH_DIR}/author-tags-git.txt" "${PATCH_DIR}/${AUTHOR_LOGNAME}"
+ else
+for i in "${AUTHOR_IGNORE_LIST[@]}"; do
+ printf "%s\n" "${i}"
+done \
+ | "${SED}" 's/[][\\.^$*+?{}()|]/\\&/g' \
+ | "${SED}" 's/^/^/' \
+ > "${PATCH_DIR}/author-tags-filter.txt"
+
+cat "${PATCH_DIR}/author-tags-filter.txt"
Review Comment:
Remove this line also?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4789742522 @ndimiduk and @Apache9 can you please have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on code in PR #7952:
URL: https://github.com/apache/hbase/pull/7952#discussion_r3467406569
##
dev-support/hbase-personality.sh:
##
@@ -290,6 +290,64 @@ function personality_modules
done
}
+# This is a workaround to fix the author check until YETUS-1266 is released.
+# TODO: Remove this when we upgraded to Yetus having YETUS-1266!
+## @description Check the current directory for @author tags
+## @audience private
+## @stabilityevolving
+## @replaceable no
+## @return 0 on success
+## @return 1 on failure
+function author_postcompile
+{
+ # shellcheck disable=SC2155
+ declare -r appname=$(basename "${BASH_SOURCE-$0}")
+ declare -a globalignore
+
+ big_console_header "*** HBase Monkey-Patch: author_postcompile ***"
Review Comment:
Removed the debug logging now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4789586306 I tried to hack something for the `author_patchfile` function (which is for patch mode) with Claude Code as I'm not too experienced with Yetus but it was not successful unfortunately. :cry: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on code in PR #7952:
URL: https://github.com/apache/hbase/pull/7952#discussion_r3467239168
##
dev-support/hbase-personality.sh:
##
@@ -290,6 +290,64 @@ function personality_modules
done
}
+# This is a workaround to fix the author check until YETUS-1266 is released.
+# TODO: Remove this when we upgraded to Yetus having YETUS-1266!
+## @description Check the current directory for @author tags
+## @audience private
+## @stabilityevolving
+## @replaceable no
+## @return 0 on success
+## @return 1 on failure
+function author_postcompile
+{
+ # shellcheck disable=SC2155
+ declare -r appname=$(basename "${BASH_SOURCE-$0}")
+ declare -a globalignore
+
+ big_console_header "*** HBase Monkey-Patch: author_postcompile ***"
Review Comment:
So this proves that the monkey-patch function IS actually invoked:
https://github.com/user-attachments/assets/4b90cae6-c122-4e0d-9790-70b1431d6670";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4789531269 General question: Turns out for GitHup PR-s, the `author_patchfile` function is invoked which is for patch mode. So that is a different function than what we have the fix in yetus and the monkey-patch for. This means that the author check will fail on the PR. But the nightly author check should be fixed by this patch. Is it OK to merge it like this (as I hope it will fix the nightly)? What do you all think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on code in PR #7952:
URL: https://github.com/apache/hbase/pull/7952#discussion_r3467210833
##
dev-support/hbase-personality.sh:
##
@@ -290,6 +290,64 @@ function personality_modules
done
}
+# This is a workaround to fix the author check until YETUS-1266 is released.
+# TODO: Remove this when we upgraded to Yetus having YETUS-1266!
+## @description Check the current directory for @author tags
+## @audience private
+## @stabilityevolving
+## @replaceable no
+## @return 0 on success
+## @return 1 on failure
+function author_postcompile
+{
+ # shellcheck disable=SC2155
+ declare -r appname=$(basename "${BASH_SOURCE-$0}")
+ declare -a globalignore
+
+ big_console_header "*** HBase Monkey-Patch: author_postcompile ***"
Review Comment:
Thanks, yes, I'll need to remove this. :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
ndimiduk commented on code in PR #7952:
URL: https://github.com/apache/hbase/pull/7952#discussion_r3467198086
##
dev-support/hbase-personality.sh:
##
@@ -290,6 +290,64 @@ function personality_modules
done
}
+# This is a workaround to fix the author check until YETUS-1266 is released.
+# TODO: Remove this when we upgraded to Yetus having YETUS-1266!
+## @description Check the current directory for @author tags
+## @audience private
+## @stabilityevolving
+## @replaceable no
+## @return 0 on success
+## @return 1 on failure
+function author_postcompile
+{
+ # shellcheck disable=SC2155
+ declare -r appname=$(basename "${BASH_SOURCE-$0}")
+ declare -a globalignore
+
+ big_console_header "*** HBase Monkey-Patch: author_postcompile ***"
Review Comment:
Lolsob
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
Apache9 commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4272933461 We can try to use the lastest master of yetus to see if it helps? If so, we can push yetus to release a new version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4143063731 Hi @ndimiduk, I tried to do the monkey-patching thing but to be honest I'm not sure if I'm doing it right. It does not work for sure. I cannot see my newly added debug messages in the output log. :see_no_evil: Can you please help in this a bit? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
ndimiduk commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4116963841 > Many thanks @ndimiduk for your fix in Yetus! đź‘Ť > > I guess we will have to wait until the new Yetus release and then upgrade Yetus in HBase, right? Yes, unfortunately. Maybe you can re-implement the fix as a function override in our personality file -- bash is extremely monkey-patchable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4116853072 Many thanks @ndimiduk for your fix in Yetus! :+1: I guess we will have to wait until the new Yetus release and then upgrade Yetus in HBase, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
ndimiduk commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4097707636 https://github.com/apache/yetus/pull/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
ndimiduk commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4097554446 https://issues.apache.org/jira/browse/YETUS-1266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4074343522 Maybe we need space separator, let's see. :see_no_evil: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
Apache9 commented on PR #7952:
URL: https://github.com/apache/hbase/pull/7952#issuecomment-4074324764
Strange, it is comma separated... @ndimiduk do you have any ideas on this?
```
function author_parse_args
{
declare i
for i in "$@"; do
case ${i} in
--author-ignore-list=*)
delete_parameter "${i}"
yetus_comma_to_array AUTHOR_IGNORE_LIST "${i#*=}"
;;
esac
done
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
Apache9 commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4074297786 Oh wait a minute, what is the syntax for passing multiple ignore files in? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
Apache9 commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4074291105 This is the log console output, seems we have already used the new config? ``` AUTHOR_IGNORE_LIST=hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/building-and-developing/developer-guidelines.mdx,hbase-website/public/book.html ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
Apache9 commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4074288402 ``` 13:hbase-website/app/pages/_docs/docs/_mdx/(multi-page)/building-and-developing/developer-guidelines.mdx:154:Also, no `@author` tags - that's a rule. 14:hbase-website/public/book.html:40827:Also, no @author tags - that’s a rule. ``` Seems still the same error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] HBASE-29878 Improve the Documentation UI (addendum) - fix author check in nightly [hbase]
PDavid commented on PR #7952: URL: https://github.com/apache/hbase/pull/7952#issuecomment-4074169614 Hmm, it seems that the `@author` check is still failing in the general check. Does it checks it on master or on the branch? :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
