[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-05-01 Thread Hive QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523238#comment-14523238
 ] 

Hive QA commented on HIVE-10140:




{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12729525/HIVE-10140.patch

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 8881 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udaf_histogram_numeric
org.apache.hive.jdbc.TestSSL.testSSLConnectionWithProperty
{noformat}

Test results: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3681/testReport
Console output: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3681/console
Test logs: 
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3681/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12729525 - PreCommit-HIVE-TRUNK-Build

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor
 Attachments: HIVE-10140.patch


 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-05-01 Thread Aihua Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523257#comment-14523257
 ] 

Aihua Xu commented on HIVE-10140:
-

The unit tests are not related to the change.

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor
 Attachments: HIVE-10140.patch


 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-05-01 Thread Aihua Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523261#comment-14523261
 ] 

Aihua Xu commented on HIVE-10140:
-

[~ashutoshc] Can you help review the change? The change is to make the 
supported window boundary to between 10 preceding and 2 preceding. I notice 
window boundary with preceding only doesn't work properly and will fix in 
HIVE-10555.

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor
 Attachments: HIVE-10140.patch


 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-05-01 Thread Ashutosh Chauhan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523705#comment-14523705
 ] 

Ashutosh Chauhan commented on HIVE-10140:
-

It will be great if you can test these cases with oracle and/or postgres and 
check whats their behavior for such queries.

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor
 Attachments: HIVE-10140.patch


 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-05-01 Thread Ashutosh Chauhan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523700#comment-14523700
 ] 

Ashutosh Chauhan commented on HIVE-10140:
-

You are right. In existing Hive implementation we got it backwards. Patch looks 
good except for one thing. If I am reading the oracle documentation you pointed 
correctly, than for either of {{ROWS between 10 preceding and 2 preceding}} or 
{{ROWS between 2 preceding and 10 preceding}} your patch will treat them as 
{{ROWS between 10 preceding and 2 preceding}}, whereas oracle seems to consider 
{{ROWS between 2 preceding and 10 preceding}} as illegal expression and throws 
error of similar effect which Hive was throwing (although for opposite case).

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor
 Attachments: HIVE-10140.patch


 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-05-01 Thread Aihua Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523751#comment-14523751
 ] 

Aihua Xu commented on HIVE-10140:
-

In my patch, {{ROWS between 2 preceding and 10 preceding}} will be treated as 
illegal expression as well. 

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor
 Attachments: HIVE-10140.patch


 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-05-01 Thread Aihua Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523754#comment-14523754
 ] 

Aihua Xu commented on HIVE-10140:
-

{{Window range invalid, start boundary is greater than end boundary: 
window(start=range(2 PRECEDING), end=range(10 PRECEDING))}} error will be 
thrown. 

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor
 Attachments: HIVE-10140.patch


 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-05-01 Thread Aihua Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523756#comment-14523756
 ] 

Aihua Xu commented on HIVE-10140:
-

Yes. I verified against Oracle. Trying to follow what Oracle has. Seems what 
Oracle has makes sense and more straightforward.

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor
 Attachments: HIVE-10140.patch


 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-05-01 Thread Ashutosh Chauhan (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14523952#comment-14523952
 ] 

Ashutosh Chauhan commented on HIVE-10140:
-

Ok.. Thanks for testing this out. +1

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor
 Attachments: HIVE-10140.patch


 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-04-30 Thread Aihua Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14521531#comment-14521531
 ] 

Aihua Xu commented on HIVE-10140:
-

Yes, we have some issues in there. It should work like the oracle analytic 
windows functions as follows.

http://docs.oracle.com/cd/E11882_01/server.112/e41084/functions004.htm#SQLRF06174
http://www.orafaq.com/node/55

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor

 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-04-30 Thread Aihua Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14521651#comment-14521651
 ] 

Aihua Xu commented on HIVE-10140:
-

We should fix this before HIVE-10555.

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor

 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (HIVE-10140) Window boundary is not compared correctly

2015-04-28 Thread Aihua Xu (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-10140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518017#comment-14518017
 ] 

Aihua Xu commented on HIVE-10140:
-

Let me take a look. 

 Window boundary is not compared correctly
 -

 Key: HIVE-10140
 URL: https://issues.apache.org/jira/browse/HIVE-10140
 Project: Hive
  Issue Type: Bug
  Components: PTF-Windowing
Affects Versions: 1.0.0
Reporter: Yi Zhang
Assignee: Aihua Xu
Priority: Minor

 “ROWS between 10 preceding and 2 preceding” is not handled correctly.
 Underlying error: Window range invalid, start boundary is greater than end 
 boundary: window(start=range(10 PRECEDING), end=range(2 PRECEDING))
 If I change it to “2 preceding and 10 preceding”, the syntax works but the 
 results are 0 of course.
 Reason for the function: during analysis, it is sometimes desired to design 
 the window to filter the most recent events, in the case of the events' 
 responses are not available yet. There is a workaround for this, but it is 
 better/more proper to fix the bug. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)