[
https://issues.apache.org/jira/browse/HIVE-18588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350163#comment-16350163
]
Peter Vary edited comment on HIVE-18588 at 2/2/18 10:55 AM:
------------------------------------------------------------
Hi [~alangates],
Tried to activate the {{checkin}} profile, but Sir Maven was helpfull :) enough
to merge the default plugin configuration with the plugin defined
configuration, so I ended up with this effective pom:
{code:java}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
[..]
<includes>
<include>**/Test*</include>
</includes>
[..]
<groups>org.apache.hadoop.hive.metastore.annotation.MetastoreUnitTest</groups>
<plugin>{code}
This is not what we planned :)
We can solve it by {{combine.self}}, like this:
{code:java}
<profile>
<id>checkin</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven.surefire.version}</version>
<configuration combine.self="override">{code}
But then we have to duplicate the whole plugin configuration - which is not
good.
So I suggest to add a new profile which is activated by default which add the
{{groups}} to the configuration, like this:
{code:java}
<profile>
<id>smokes</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven.surefire.version}</version>
<configuration>
<groups>${test.groups}</groups>
</configuration>
</plugin>
</plugins>
</build>
</profile>{code}
So we can run the normal tests with:
{code:java}
mvn test{code}
And we can run every test with deactivating the {{smokes}} profile:
{code:java}
mvn test -P-smokes{code}
What do you think?
Thanks,
Peter
was (Author: pvary):
Hi [~alangates],
Tried to activate the {{checkin}} profile, but Sir Maven was helpfull :) enough
to merge the default plugin configuration with the plugin defined
configuration, so I ended up with this effective pom:
{code:java}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
[..]
<includes>
<include>**/Test*</include>
</includes>
[..]
<groups>org.apache.hadoop.hive.metastore.annotation.MetastoreUnitTest</groups>
<plugin>{code}
This is not what we planned :)
We can solve it by {{combine.self}}, like this:
{code:java}
<profile>
<id>checkin</id>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven.surefire.version}</version>
<configuration combine.self="override">{code}
But then we have to duplicate the whole plugin configuration - which is not
good.
So I suggest to add a new profile which is activated by default which add the
{{groups}} to the configuration, like this:
{code:java}
<profile>
<id>smokes</id>
<activation>
<activeByDefault>true</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${maven.surefire.version}</version>
<configuration>
<groups>${test.groups}</groups>
</configuration>
</plugin>
</plugins>
</build>
</profile>{code}
So we can run the normal tests with:
{code:java}
mvn test{code}
And we can run every test with deactivating the smokes profile:
{code:java}
mvn test -P-smoke{code}
What do you think?
Thanks,
Peter
> Add 'checkin' profile that runs slower tests in standalone-metastore
> --------------------------------------------------------------------
>
> Key: HIVE-18588
> URL: https://issues.apache.org/jira/browse/HIVE-18588
> Project: Hive
> Issue Type: Test
> Components: Standalone Metastore
> Affects Versions: 3.0.0
> Reporter: Alan Gates
> Assignee: Alan Gates
> Priority: Major
> Attachments: HIVE-18588.2.patch, HIVE-18588.patch
>
>
> Runtime for unit tests in standalone-metastore are now exceeding 25 minutes.
> Ideally unit tests should finish within 2-3 minutes so users will run them
> frequently. To solve this I propose to carve off many of the slower tests to
> run in a new 'checkin' profile. This profile should be run before checkin
> and by the ptest infrastructure.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
