[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[ https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385042#comment-14385042 ] Aihua Xu commented on HIVE-10093: - Thanks Szehon. > Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > - > > Key: HIVE-10093 > URL: https://issues.apache.org/jira/browse/HIVE-10093 > Project: Hive > Issue Type: Bug >Reporter: Szehon Ho >Assignee: Aihua Xu >Priority: Minor > Fix For: 1.2.0 > > Attachments: HIVE-10093.patch > > > When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler > unnecessarily right before the call to: > HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the > DelegationTokenStore is configured to be a memoryTokenStore, this step is not > needed. > Side effect is creation of useless derby database file on HiveServer2 in > secure clusters, causing confusion. This could potentially be skipped if > MemoryTokenStore is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[ https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385033#comment-14385033 ] Aihua Xu commented on HIVE-10093: - Whoops. I included it by accident. > Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > - > > Key: HIVE-10093 > URL: https://issues.apache.org/jira/browse/HIVE-10093 > Project: Hive > Issue Type: Bug >Reporter: Szehon Ho >Assignee: Aihua Xu >Priority: Minor > Attachments: HIVE-10093.patch > > > When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler > unnecessarily right before the call to: > HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the > DelegationTokenStore is configured to be a memoryTokenStore, this step is not > needed. > Side effect is creation of useless derby database file on HiveServer2 in > secure clusters, causing confusion. This could potentially be skipped if > MemoryTokenStore is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[ https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385016#comment-14385016 ] Szehon Ho commented on HIVE-10093: -- Aihua, .reviewboardrc is modified by mistake right? If so I can commit the patch without it. Thanks > Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > - > > Key: HIVE-10093 > URL: https://issues.apache.org/jira/browse/HIVE-10093 > Project: Hive > Issue Type: Bug >Reporter: Szehon Ho >Assignee: Aihua Xu >Priority: Minor > Attachments: HIVE-10093.patch > > > When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler > unnecessarily right before the call to: > HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the > DelegationTokenStore is configured to be a memoryTokenStore, this step is not > needed. > Side effect is creation of useless derby database file on HiveServer2 in > secure clusters, causing confusion. This could potentially be skipped if > MemoryTokenStore is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[ https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383993#comment-14383993 ] Aihua Xu commented on HIVE-10093: - I ran those tests locally and didn't see the issues. Seems random failures as well. > Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > - > > Key: HIVE-10093 > URL: https://issues.apache.org/jira/browse/HIVE-10093 > Project: Hive > Issue Type: Bug >Reporter: Szehon Ho >Assignee: Aihua Xu >Priority: Minor > Attachments: HIVE-10093.patch > > > When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler > unnecessarily right before the call to: > HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the > DelegationTokenStore is configured to be a memoryTokenStore, this step is not > needed. > Side effect is creation of useless derby database file on HiveServer2 in > secure clusters, causing confusion. This could potentially be skipped if > MemoryTokenStore is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[
https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383559#comment-14383559
]
Hive QA commented on HIVE-10093:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12707669/HIVE-10093.patch
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 8678 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.thrift.TestHadoop20SAuthBridge.testMetastoreProxyUser
org.apache.hadoop.hive.thrift.TestHadoop20SAuthBridge.testSaslWithHiveMetaStore
org.apache.hive.jdbc.TestSSL.testSSLFetchHttp
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3178/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3178/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3178/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12707669 - PreCommit-HIVE-TRUNK-Build
> Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
> -
>
> Key: HIVE-10093
> URL: https://issues.apache.org/jira/browse/HIVE-10093
> Project: Hive
> Issue Type: Bug
>Reporter: Szehon Ho
>Assignee: Aihua Xu
>Priority: Minor
> Attachments: HIVE-10093.patch
>
>
> When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler
> unnecessarily right before the call to:
> HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the
> DelegationTokenStore is configured to be a memoryTokenStore, this step is not
> needed.
> Side effect is creation of useless derby database file on HiveServer2 in
> secure clusters, causing confusion. This could potentially be skipped if
> MemoryTokenStore is used.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[ https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14383199#comment-14383199 ] Szehon Ho commented on HIVE-10093: -- Thanks, +1 on latest patch pending test > Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > - > > Key: HIVE-10093 > URL: https://issues.apache.org/jira/browse/HIVE-10093 > Project: Hive > Issue Type: Bug >Reporter: Szehon Ho >Assignee: Aihua Xu >Priority: Minor > Attachments: HIVE-10093.patch > > > When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler > unnecessarily right before the call to: > HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the > DelegationTokenStore is configured to be a memoryTokenStore, this step is not > needed. > Side effect is creation of useless derby database file on HiveServer2 in > secure clusters, causing confusion. This could potentially be skipped if > MemoryTokenStore is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[ https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382771#comment-14382771 ] Aihua Xu commented on HIVE-10093: - RB: https://reviews.apache.org/r/32551/ > Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > - > > Key: HIVE-10093 > URL: https://issues.apache.org/jira/browse/HIVE-10093 > Project: Hive > Issue Type: Bug >Reporter: Szehon Ho >Assignee: Aihua Xu >Priority: Minor > Attachments: HIVE-10093.patch > > > When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler > unnecessarily right before the call to: > HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the > DelegationTokenStore is configured to be a memoryTokenStore, this step is not > needed. > Side effect is creation of useless derby database file on HiveServer2 in > secure clusters, causing confusion. This could potentially be skipped if > MemoryTokenStore is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[ https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382730#comment-14382730 ] Szehon Ho commented on HIVE-10093: -- Can you create a rb for this? > Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > - > > Key: HIVE-10093 > URL: https://issues.apache.org/jira/browse/HIVE-10093 > Project: Hive > Issue Type: Bug >Reporter: Szehon Ho >Assignee: Aihua Xu >Priority: Minor > Attachments: HIVE-10093.patch > > > When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler > unnecessarily right before the call to: > HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the > DelegationTokenStore is configured to be a memoryTokenStore, this step is not > needed. > Side effect is creation of useless derby database file on HiveServer2 in > secure clusters, causing confusion. This could potentially be skipped if > MemoryTokenStore is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[ https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382727#comment-14382727 ] Aihua Xu commented on HIVE-10093: - [~szehon] Can you take a look at the change? > Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > - > > Key: HIVE-10093 > URL: https://issues.apache.org/jira/browse/HIVE-10093 > Project: Hive > Issue Type: Bug >Reporter: Szehon Ho >Assignee: Aihua Xu >Priority: Minor > Attachments: HIVE-10093.patch > > > When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler > unnecessarily right before the call to: > HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the > DelegationTokenStore is configured to be a memoryTokenStore, this step is not > needed. > Side effect is creation of useless derby database file on HiveServer2 in > secure clusters, causing confusion. This could potentially be skipped if > MemoryTokenStore is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[ https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382418#comment-14382418 ] Aihua Xu commented on HIVE-10093: - I will work on that. > Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > - > > Key: HIVE-10093 > URL: https://issues.apache.org/jira/browse/HIVE-10093 > Project: Hive > Issue Type: Bug >Reporter: Szehon Ho >Assignee: Aihua Xu >Priority: Minor > > When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler > unnecessarily right before the call to: > HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the > DelegationTokenStore is configured to be a memoryTokenStore, this step is not > needed. > Side effect is creation of useless derby database file on HiveServer2 in > secure clusters, causing confusion. This could potentially be skipped if > MemoryTokenStore is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-10093) Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2
[ https://issues.apache.org/jira/browse/HIVE-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14382401#comment-14382401 ] Szehon Ho commented on HIVE-10093: -- FYI [~aihuaxu] > Unnecessary HMSHandler initialization for default MemoryTokenStore on HS2 > - > > Key: HIVE-10093 > URL: https://issues.apache.org/jira/browse/HIVE-10093 > Project: Hive > Issue Type: Bug >Reporter: Szehon Ho >Priority: Minor > > When the HiveAuthFactory is constructed in HS2, it initializes a HMSHandler > unnecessarily right before the call to: > HadoopThriftAuthBridge.startDelegationTokenSecretManager(). If the > DelegationTokenStore is configured to be a memoryTokenStore, this step is not > needed. > Side effect is creation of useless derby database file on HiveServer2 in > secure clusters, causing confusion. This could potentially be skipped if > MemoryTokenStore is used. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
