[jira] [Commented] (HIVE-11448) Support vectorization of Multi-OR and Multi-AND
[ https://issues.apache.org/jira/browse/HIVE-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14679489#comment-14679489 ] Matt McCline commented on HIVE-11448: - Ok, fixed branch-1. Thanks [~prasanth_j]. Support vectorization of Multi-OR and Multi-AND --- Key: HIVE-11448 URL: https://issues.apache.org/jira/browse/HIVE-11448 Project: Hive Issue Type: Bug Components: Hive Reporter: Matt McCline Assignee: Matt McCline Priority: Critical Fix For: 2.0.0 Attachments: HIVE-11448.01.patch, HIVE-11448.02.patch, HIVE-11448.03.patch Support more than 2 children for OR and AND when all children are expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11448) Support vectorization of Multi-OR and Multi-AND
[ https://issues.apache.org/jira/browse/HIVE-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662834#comment-14662834 ] Lefty Leverenz commented on HIVE-11448: --- Fix version should include 1.3.0. (In general, should I make such changes myself or just add comments?) Support vectorization of Multi-OR and Multi-AND --- Key: HIVE-11448 URL: https://issues.apache.org/jira/browse/HIVE-11448 Project: Hive Issue Type: Bug Components: Hive Reporter: Matt McCline Assignee: Matt McCline Priority: Critical Fix For: 2.0.0 Attachments: HIVE-11448.01.patch, HIVE-11448.02.patch, HIVE-11448.03.patch Support more than 2 children for OR and AND when all children are expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11448) Support vectorization of Multi-OR and Multi-AND
[ https://issues.apache.org/jira/browse/HIVE-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662547#comment-14662547 ] Gopal V commented on HIVE-11448: Tested against latest from HIVE-11398, LGTM - +1. Support vectorization of Multi-OR and Multi-AND --- Key: HIVE-11448 URL: https://issues.apache.org/jira/browse/HIVE-11448 Project: Hive Issue Type: Bug Components: Hive Reporter: Matt McCline Assignee: Matt McCline Priority: Critical Attachments: HIVE-11448.01.patch, HIVE-11448.02.patch, HIVE-11448.03.patch Support more than 2 children for OR and AND when all children are expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11448) Support vectorization of Multi-OR and Multi-AND
[ https://issues.apache.org/jira/browse/HIVE-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14660569#comment-14660569 ] Gunther Hagleitner commented on HIVE-11448: --- [~mmccline] looks like there are a couple of plan changes now. Are those real issues or just need golden update? (cc [~gopalv]) Support vectorization of Multi-OR and Multi-AND --- Key: HIVE-11448 URL: https://issues.apache.org/jira/browse/HIVE-11448 Project: Hive Issue Type: Bug Components: Hive Reporter: Matt McCline Assignee: Matt McCline Priority: Critical Attachments: HIVE-11448.01.patch, HIVE-11448.02.patch, HIVE-11448.03.patch Support more than 2 children for OR and AND when all children are expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11448) Support vectorization of Multi-OR and Multi-AND
[
https://issues.apache.org/jira/browse/HIVE-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653687#comment-14653687
]
Hive QA commented on HIVE-11448:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12748620/HIVE-11448.03.patch
{color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 9321 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_convert_enum_to_string
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_dynamic_rdd_cache
org.apache.hive.jdbc.TestSSL.testSSLVersion
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4817/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4817/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4817/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 3 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12748620 - PreCommit-HIVE-TRUNK-Build
Support vectorization of Multi-OR and Multi-AND
---
Key: HIVE-11448
URL: https://issues.apache.org/jira/browse/HIVE-11448
Project: Hive
Issue Type: Bug
Components: Hive
Reporter: Matt McCline
Assignee: Matt McCline
Priority: Critical
Attachments: HIVE-11448.01.patch, HIVE-11448.02.patch,
HIVE-11448.03.patch
Support more than 2 children for OR and AND when all children are expressions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11448) Support vectorization of Multi-OR and Multi-AND
[ https://issues.apache.org/jira/browse/HIVE-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653133#comment-14653133 ] Gopal V commented on HIVE-11448: This is failing somewhere in the subtract() inner loop, which I suspect is due to the lack of the deep-copy of the arrays when generating the OR + XOR divisions Support vectorization of Multi-OR and Multi-AND --- Key: HIVE-11448 URL: https://issues.apache.org/jira/browse/HIVE-11448 Project: Hive Issue Type: Bug Components: Hive Reporter: Matt McCline Assignee: Matt McCline Priority: Critical Attachments: HIVE-11448.01.patch, HIVE-11448.02.patch Support more than 2 children for OR and AND when all children are expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11448) Support vectorization of Multi-OR and Multi-AND
[
https://issues.apache.org/jira/browse/HIVE-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653182#comment-14653182
]
Gopal V commented on HIVE-11448:
[~mmccline]: I found that under some conditions - subtract() args are mixed up.
The assert that you need to trigger is that none of the inputs overlap each
other.
Preconditions.check((all != remove) || (remove != difference) || (difference !=
all));
Under some conditions, I found that remove == difference, which was triggering
most of the errors which start with.
{code}
Caused by: java.lang.RuntimeException: Not all batch indices removed
at
org.apache.hadoop.hive.ql.exec.vector.expressions.FilterExprOrExpr.subtract(FilterExprOrExpr.java:108)
at
org.apache.hadoop.hive.ql.exec.vector.expressions.FilterExprOrExpr.evaluate(FilterExprOrExpr.java:214)
at
org.apache.hadoop.hive.ql.exec.vector.VectorFilterOperator.process(VectorFilterOperator.java:106)
at org.apache.hadoop.hive.ql.exec.Operator.forward(Operator.java:837)
at
org.apache.hadoop.hive.ql.exec.TableScanOperator.process(TableScanOperator.java:97)
at
org.apache.hadoop.hive.ql.exec.MapOperator$MapOpCtx.forward(MapOperator.java:162)
at
org.apache.hadoop.hive.ql.exec.vector.VectorMapOperator.process(VectorMapOperator.java:45)
... 18 more
{code}
Support vectorization of Multi-OR and Multi-AND
---
Key: HIVE-11448
URL: https://issues.apache.org/jira/browse/HIVE-11448
Project: Hive
Issue Type: Bug
Components: Hive
Reporter: Matt McCline
Assignee: Matt McCline
Priority: Critical
Attachments: HIVE-11448.01.patch, HIVE-11448.02.patch
Support more than 2 children for OR and AND when all children are expressions.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-11448) Support vectorization of Multi-OR and Multi-AND
[ https://issues.apache.org/jira/browse/HIVE-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653239#comment-14653239 ] Matt McCline commented on HIVE-11448: - Original op did swap the selected array which is questionable. New patch will not swap selected array. Added Precondition. Thanks for Gopal for debugging the problem. Sorry for the trouble. Support vectorization of Multi-OR and Multi-AND --- Key: HIVE-11448 URL: https://issues.apache.org/jira/browse/HIVE-11448 Project: Hive Issue Type: Bug Components: Hive Reporter: Matt McCline Assignee: Matt McCline Priority: Critical Attachments: HIVE-11448.01.patch, HIVE-11448.02.patch, HIVE-11448.03.patch Support more than 2 children for OR and AND when all children are expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11448) Support vectorization of Multi-OR and Multi-AND
[ https://issues.apache.org/jira/browse/HIVE-11448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14653052#comment-14653052 ] Gopal V commented on HIVE-11448: Added to my build for the night, thanks [~mmccline]. Support vectorization of Multi-OR and Multi-AND --- Key: HIVE-11448 URL: https://issues.apache.org/jira/browse/HIVE-11448 Project: Hive Issue Type: Bug Components: Hive Reporter: Matt McCline Assignee: Matt McCline Priority: Critical Attachments: HIVE-11448.01.patch, HIVE-11448.02.patch Support more than 2 children for OR and AND when all children are expressions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
