[jira] [Commented] (HIVE-14262) Inherit writetype from partition WriteEntity for table WriteEntity
[
https://issues.apache.org/jira/browse/HIVE-14262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383270#comment-15383270
]
Hive QA commented on HIVE-14262:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12818612/HIVE-14262.2.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 8 failed/errored test(s), 10336 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_acid_globallimit
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_13
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_list_bucket
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_subquery_multiinsert
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_acid_globallimit
org.apache.hadoop.hive.llap.daemon.impl.TestLlapTokenChecker.testCheckPermissions
org.apache.hadoop.hive.llap.daemon.impl.TestLlapTokenChecker.testGetToken
org.apache.hadoop.hive.metastore.TestMetaStoreMetrics.testConnections
{noformat}
Test results:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/568/testReport
Console output:
https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/568/console
Test logs:
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-568/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 8 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12818612 - PreCommit-HIVE-MASTER-Build
> Inherit writetype from partition WriteEntity for table WriteEntity
> --
>
> Key: HIVE-14262
> URL: https://issues.apache.org/jira/browse/HIVE-14262
> Project: Hive
> Issue Type: Bug
>Reporter: Thejas M Nair
>Assignee: Thejas M Nair
> Attachments: HIVE-14262.1.patch, HIVE-14262.2.patch
>
>
> For partitioned table operations, a Table WriteEntity is being added to the
> list to be authorized if there is a partition in the output list from
> semantic analyzer.
> However, it is being added with a default WriteType of DDL_NO_TASK.
> The new Table WriteEntity should be created with the WriteType of the
> partition WriteEntity.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-14262) Inherit writetype from partition WriteEntity for table WriteEntity
[ https://issues.apache.org/jira/browse/HIVE-14262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382991#comment-15382991 ] Sushanth Sowmyan commented on HIVE-14262: - (We should still let the test runs finish with .2.patch though, I think, for verification) > Inherit writetype from partition WriteEntity for table WriteEntity > -- > > Key: HIVE-14262 > URL: https://issues.apache.org/jira/browse/HIVE-14262 > Project: Hive > Issue Type: Bug >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-14262.1.patch, HIVE-14262.2.patch > > > For partitioned table operations, a Table WriteEntity is being added to the > list to be authorized if there is a partition in the output list from > semantic analyzer. > However, it is being added with a default WriteType of DDL_NO_TASK. > The new Table WriteEntity should be created with the WriteType of the > partition WriteEntity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14262) Inherit writetype from partition WriteEntity for table WriteEntity
[ https://issues.apache.org/jira/browse/HIVE-14262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382989#comment-15382989 ] Sushanth Sowmyan commented on HIVE-14262: - Ah, makes sense. +1. I remember now that I had a similar issue with that bit a while back. > Inherit writetype from partition WriteEntity for table WriteEntity > -- > > Key: HIVE-14262 > URL: https://issues.apache.org/jira/browse/HIVE-14262 > Project: Hive > Issue Type: Bug >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-14262.1.patch, HIVE-14262.2.patch > > > For partitioned table operations, a Table WriteEntity is being added to the > list to be authorized if there is a partition in the output list from > semantic analyzer. > However, it is being added with a default WriteType of DDL_NO_TASK. > The new Table WriteEntity should be created with the WriteType of the > partition WriteEntity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14262) Inherit writetype from partition WriteEntity for table WriteEntity
[ https://issues.apache.org/jira/browse/HIVE-14262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382952#comment-15382952 ] Thejas M Nair commented on HIVE-14262: -- The 2.patch won't need the .q.out files to be updated. In 1.patch, I changed the WriteEntity.equals method thinking that it is necessary to prevent any writeentity getting added as part of the loop over partitions from overwriting ones already added by SemanticAnalyzer, just in case it has the more accurate writeType. But on taking a closer look at the Sets.union method, that wasn't necessary, and I added comment around that in 2.patch. > Inherit writetype from partition WriteEntity for table WriteEntity > -- > > Key: HIVE-14262 > URL: https://issues.apache.org/jira/browse/HIVE-14262 > Project: Hive > Issue Type: Bug >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-14262.1.patch, HIVE-14262.2.patch > > > For partitioned table operations, a Table WriteEntity is being added to the > list to be authorized if there is a partition in the output list from > semantic analyzer. > However, it is being added with a default WriteType of DDL_NO_TASK. > The new Table WriteEntity should be created with the WriteType of the > partition WriteEntity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14262) Inherit writetype from partition WriteEntity for table WriteEntity
[ https://issues.apache.org/jira/browse/HIVE-14262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15382905#comment-15382905 ] Sushanth Sowmyan commented on HIVE-14262: - +1 for the code change, but it looks like this impacts a lot of .q.out files that also need to be updated. > Inherit writetype from partition WriteEntity for table WriteEntity > -- > > Key: HIVE-14262 > URL: https://issues.apache.org/jira/browse/HIVE-14262 > Project: Hive > Issue Type: Bug >Reporter: Thejas M Nair >Assignee: Thejas M Nair > Attachments: HIVE-14262.1.patch, HIVE-14262.2.patch > > > For partitioned table operations, a Table WriteEntity is being added to the > list to be authorized if there is a partition in the output list from > semantic analyzer. > However, it is being added with a default WriteType of DDL_NO_TASK. > The new Table WriteEntity should be created with the WriteType of the > partition WriteEntity. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-14262) Inherit writetype from partition WriteEntity for table WriteEntity
[
https://issues.apache.org/jira/browse/HIVE-14262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381612#comment-15381612
]
Hive QA commented on HIVE-14262:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12818477/HIVE-14262.1.patch
{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 871 failed/errored test(s), 10334 tests
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_acid_globallimit
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_acid_table_stats
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_add_part_exist
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter4
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter5
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_char1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_char2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_file_format
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_merge
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_merge_2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_merge_2_orc
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_merge_3
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_merge_orc
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_merge_stats
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_merge_stats_orc
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_numbuckets_partitioned_table2_h23
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_numbuckets_partitioned_table_h23
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_partition_change_col
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_partition_clusterby_sortby
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_partition_coltype
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_partition_format_loc
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_rename_partition
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_rename_partition_authorization
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_skewed_table
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_table_cascade
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_table_invalidate_column_stats
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_table_location
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_table_not_sorted
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_table_partition_drop
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_table_serde
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_table_serde2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_varchar1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_varchar2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_view_as_select
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_view_rename
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_analyze_table_null_partition
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_filter
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_groupby
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_groupby2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_join_pkfk
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_limit
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_select
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_table
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_annotate_stats_union
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_archive_excludeHadoop20
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_1_sql_std
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_4
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_6
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_7
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_admin_almighty1
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_admin_almighty2
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_cli_nonsql
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_create_temp_table
