[jira] [Commented] (HIVE-14814) metastoreClient is used directly in Hive cause NPE

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15512009#comment-15512009
 ] 

Hive QA commented on HIVE-14814:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12829731/HIVE-14814.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 10554 tests 
executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[acid_mapjoin]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ctas]
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[vector_join_part_col_char]
org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3]
org.apache.hadoop.hive.metastore.TestMetaStoreMetrics.testMetaDataCounts
org.apache.hive.jdbc.TestJdbcWithMiniHS2.testAddJarConstructorUnCaching
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1265/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1265/console
Test logs: 
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-Build-1265/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12829731 - PreCommit-HIVE-Build

> metastoreClient is used directly in Hive cause NPE
> --
>
> Key: HIVE-14814
> URL: https://issues.apache.org/jira/browse/HIVE-14814
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 1.3.0, 2.1.0, 2.2.0
>Reporter: Dileep Kumar Chiguruvada
>Assignee: Prasanth Jayachandran
> Attachments: HIVE-14814.1.patch
>
>
> Changes introduced by HIVE-13622 uses metastoreClient directly in Hive.java 
> which may be null causing NPE. Instead it should use getMSC() which will 
> initialize metastoreClient variable when null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-14814) metastoreClient is used directly in Hive cause NPE

[Prasanth Jayachandran (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511780#comment-15511780
 ] 

Prasanth Jayachandran commented on HIVE-14814:
--

Yeah. Updated. Will backport them.

> metastoreClient is used directly in Hive cause NPE
> --
>
> Key: HIVE-14814
> URL: https://issues.apache.org/jira/browse/HIVE-14814
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 1.3.0, 2.1.0, 2.2.0
>Reporter: Dileep Kumar Chiguruvada
>Assignee: Prasanth Jayachandran
> Attachments: HIVE-14814.1.patch
>
>
> Changes introduced by HIVE-13622 uses metastoreClient directly in Hive.java 
> which may be null causing NPE. Instead it should use getMSC() which will 
> initialize metastoreClient variable when null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-14814) metastoreClient is used directly in Hive cause NPE

[Eugene Koifman (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511757#comment-15511757
 ] 

Eugene Koifman commented on HIVE-14814:
---

+1 patch 1
but since HIVE-13622 this would have to go into 2.1.1 and 1.3, right?

> metastoreClient is used directly in Hive cause NPE
> --
>
> Key: HIVE-14814
> URL: https://issues.apache.org/jira/browse/HIVE-14814
> Project: Hive
>  Issue Type: Bug
>Affects Versions: 2.2.0
>Reporter: Dileep Kumar Chiguruvada
>Assignee: Prasanth Jayachandran
> Attachments: HIVE-14814.1.patch
>
>
> Changes introduced by HIVE-13622 uses metastoreClient directly in Hive.java 
> which may be null causing NPE. Instead it should use getMSC() which will 
> initialize metastoreClient variable when null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)