[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893187#comment-15893187
]
Thejas M Nair commented on HIVE-15291:
--
[~xupeng1226]
Shouldn't "" be treated as a null timestamp ? A
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763367#comment-15763367
]
徐鹏 commented on HIVE-15291:
---
Problem still exist if empty string is provided.
query:select cast("2016-12-31
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711714#comment-15711714
]
Dhiraj Kumar commented on HIVE-15291:
-
It was put from the perspective of result being incompatible
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15711569#comment-15711569
]
Peter Vary commented on HIVE-15291:
---
Am I right when I think we should remove the "Incompatible change"
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15709324#comment-15709324
]
Jason Dere commented on HIVE-15291:
---
+1
cc [~ashutoshc]
> Comparison of timestamp fails if only date
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708531#comment-15708531
]
Hive QA commented on HIVE-15291:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708407#comment-15708407
]
Dhiraj Kumar commented on HIVE-15291:
-
Added the .q test.
> Comparison of timestamp fails if only
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708409#comment-15708409
]
Dhiraj Kumar commented on HIVE-15291:
-
Added the .q test.
> Comparison of timestamp fails if only
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706200#comment-15706200
]
Jason Dere commented on HIVE-15291:
---
Can you add a .q test so we can see this fix work in a SQL
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706046#comment-15706046
]
Hive QA commented on HIVE-15291:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705823#comment-15705823
]
Dhiraj Kumar commented on HIVE-15291:
-
Hello [~pvary],
I am removing extraneous test case. Agree
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15705632#comment-15705632
]
Peter Vary commented on HIVE-15291:
---
Hi Dhiraj,
Good job with the tests.
It is just nitpicking, but I
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704997#comment-15704997
]
Hive QA commented on HIVE-15291:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15703931#comment-15703931
]
徐鹏 commented on HIVE-15291:
---
@Test
public void testGetTimestampFromString(){
[
https://issues.apache.org/jira/browse/HIVE-15291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15702274#comment-15702274
]
Peter Vary commented on HIVE-15291:
---
[~dhiraj.kumar]: Do you mind adding a unit test for this case as
15 matches
Mail list logo