[jira] [Commented] (HIVE-15727) Add pre insert work to give storage handler the possibility to perform pre insert checking
[ https://issues.apache.org/jira/browse/HIVE-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16709110#comment-16709110 ] ASF GitHub Bot commented on HIVE-15727: --- Github user b-slim closed the pull request at: https://github.com/apache/hive/pull/139 > Add pre insert work to give storage handler the possibility to perform pre > insert checking > -- > > Key: HIVE-15727 > URL: https://issues.apache.org/jira/browse/HIVE-15727 > Project: Hive > Issue Type: Sub-task > Components: Druid integration >Reporter: slim bouguerra >Assignee: slim bouguerra >Priority: Major > Labels: pull-request-available > Fix For: 2.2.0 > > Attachments: HIVE-15727.2.patch, HIVE-15727.3.patch, > HIVE-15727.4.patch, HIVE-15727.patch > > > Add pre insert work stage to give storage handler the possibility to perform > pre insert checking. For instance for the druid storage handler this will > block the statement INSERT INTO statement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-15727) Add pre insert work to give storage handler the possibility to perform pre insert checking
[ https://issues.apache.org/jira/browse/HIVE-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852516#comment-15852516 ] Hive QA commented on HIVE-15727: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12850902/HIVE-15727.4.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10226 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=140) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_varchar_simple] (batchId=153) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=223) org.apache.hadoop.hive.llap.daemon.impl.TestTaskExecutorService.testWaitQueuePreemption (batchId=277) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3367/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3367/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3367/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12850902 - PreCommit-HIVE-Build > Add pre insert work to give storage handler the possibility to perform pre > insert checking > -- > > Key: HIVE-15727 > URL: https://issues.apache.org/jira/browse/HIVE-15727 > Project: Hive > Issue Type: Sub-task > Components: Druid integration >Reporter: slim bouguerra >Assignee: slim bouguerra > Fix For: 2.2.0 > > Attachments: HIVE-15727.2.patch, HIVE-15727.3.patch, > HIVE-15727.4.patch, HIVE-15727.patch > > > Add pre insert work stage to give storage handler the possibility to perform > pre insert checking. For instance for the druid storage handler this will > block the statement INSERT INTO statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15727) Add pre insert work to give storage handler the possibility to perform pre insert checking
[ https://issues.apache.org/jira/browse/HIVE-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852358#comment-15852358 ] Hive QA commented on HIVE-15727: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12850902/HIVE-15727.4.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 7 failed/errored test(s), 10226 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_if_expr] (batchId=140) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_varchar_simple] (batchId=153) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_3] (batchId=93) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) org.apache.hadoop.hive.llap.daemon.impl.TestTaskExecutorService.testWaitQueuePreemption (batchId=278) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3362/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3362/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3362/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 7 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12850902 - PreCommit-HIVE-Build > Add pre insert work to give storage handler the possibility to perform pre > insert checking > -- > > Key: HIVE-15727 > URL: https://issues.apache.org/jira/browse/HIVE-15727 > Project: Hive > Issue Type: Sub-task > Components: Druid integration >Reporter: slim bouguerra >Assignee: slim bouguerra > Fix For: 2.2.0 > > Attachments: HIVE-15727.2.patch, HIVE-15727.3.patch, > HIVE-15727.4.patch, HIVE-15727.patch > > > Add pre insert work stage to give storage handler the possibility to perform > pre insert checking. For instance for the druid storage handler this will > block the statement INSERT INTO statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15727) Add pre insert work to give storage handler the possibility to perform pre insert checking
[ https://issues.apache.org/jira/browse/HIVE-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852255#comment-15852255 ] Ashutosh Chauhan commented on HIVE-15727: - +1 > Add pre insert work to give storage handler the possibility to perform pre > insert checking > -- > > Key: HIVE-15727 > URL: https://issues.apache.org/jira/browse/HIVE-15727 > Project: Hive > Issue Type: Sub-task > Components: Druid integration >Reporter: slim bouguerra >Assignee: slim bouguerra > Fix For: 2.2.0 > > Attachments: HIVE-15727.2.patch, HIVE-15727.3.patch, > HIVE-15727.4.patch, HIVE-15727.patch > > > Add pre insert work stage to give storage handler the possibility to perform > pre insert checking. For instance for the druid storage handler this will > block the statement INSERT INTO statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15727) Add pre insert work to give storage handler the possibility to perform pre insert checking
[ https://issues.apache.org/jira/browse/HIVE-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852195#comment-15852195 ] slim bouguerra commented on HIVE-15727: --- [~ashutoshc] you are right i havn't rebased my branch > Add pre insert work to give storage handler the possibility to perform pre > insert checking > -- > > Key: HIVE-15727 > URL: https://issues.apache.org/jira/browse/HIVE-15727 > Project: Hive > Issue Type: Sub-task > Components: Druid integration >Reporter: slim bouguerra >Assignee: slim bouguerra > Fix For: 2.2.0 > > Attachments: HIVE-15727.2.patch, HIVE-15727.3.patch, > HIVE-15727.4.patch, HIVE-15727.patch > > > Add pre insert work stage to give storage handler the possibility to perform > pre insert checking. For instance for the druid storage handler this will > block the statement INSERT INTO statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15727) Add pre insert work to give storage handler the possibility to perform pre insert checking
[ https://issues.apache.org/jira/browse/HIVE-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852190#comment-15852190 ] Ashutosh Chauhan commented on HIVE-15727: - [~bslim] Incorrectly generated patch? 1.4 MB ? > Add pre insert work to give storage handler the possibility to perform pre > insert checking > -- > > Key: HIVE-15727 > URL: https://issues.apache.org/jira/browse/HIVE-15727 > Project: Hive > Issue Type: Sub-task > Components: Druid integration >Reporter: slim bouguerra >Assignee: slim bouguerra > Fix For: 2.2.0 > > Attachments: HIVE-15727.2.patch, HIVE-15727.3.patch, HIVE-15727.patch > > > Add pre insert work stage to give storage handler the possibility to perform > pre insert checking. For instance for the druid storage handler this will > block the statement INSERT INTO statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15727) Add pre insert work to give storage handler the possibility to perform pre insert checking
[ https://issues.apache.org/jira/browse/HIVE-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850275#comment-15850275 ] Ashutosh Chauhan commented on HIVE-15727: - This looks good. One suggestion I have is instead of having interface HiveMetaHookV2, make it abstract class DefaultHiveMetaHook so that we can add new methods in it future without breaking compatibility. > Add pre insert work to give storage handler the possibility to perform pre > insert checking > -- > > Key: HIVE-15727 > URL: https://issues.apache.org/jira/browse/HIVE-15727 > Project: Hive > Issue Type: Sub-task > Components: Druid integration >Reporter: slim bouguerra >Assignee: slim bouguerra > Fix For: 2.2.0 > > Attachments: HIVE-15727.2.patch, HIVE-15727.patch > > > Add pre insert work stage to give storage handler the possibility to perform > pre insert checking. For instance for the druid storage handler this will > block the statement INSERT INTO statement. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-15727) Add pre insert work to give storage handler the possibility to perform pre insert checking
[ https://issues.apache.org/jira/browse/HIVE-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843301#comment-15843301 ] Hive QA commented on HIVE-15727: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12849627/HIVE-15727.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 11003 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] (batchId=93) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3219/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3219/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3219/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12849627 - PreCommit-HIVE-Build > Add pre insert work to give storage handler the possibility to perform pre > insert checking > -- > > Key: HIVE-15727 > URL: https://issues.apache.org/jira/browse/HIVE-15727 > Project: Hive > Issue Type: Sub-task > Components: Druid integration >Reporter: slim bouguerra >Assignee: slim bouguerra > Fix For: 2.2.0 > > Attachments: HIVE-15727.2.patch, HIVE-15727.patch > > > Add pre insert work stage to give storage handler the possibility to perform > pre insert checking. For instance for the druid storage handler this will > block the statement INSERT INTO statement. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15727) Add pre insert work to give storage handler the possibility to perform pre insert checking
[ https://issues.apache.org/jira/browse/HIVE-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838784#comment-15838784 ] Hive QA commented on HIVE-15727: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12849372/HIVE-15727.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 12 failed/errored test(s), 10999 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_queries] (batchId=219) org.apache.hadoop.hive.cli.TestAccumuloCliDriver.testCliDriver[accumulo_single_sourced_multi_insert] (batchId=219) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys] (batchId=159) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_queries] (batchId=90) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbase_single_sourced_multi_insert] (batchId=91) org.apache.hadoop.hive.cli.TestHBaseCliDriver.testCliDriver[hbasestats] (batchId=89) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[schema_evol_text_vec_part] (batchId=149) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_char_simple] (batchId=147) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vector_varchar_simple] (batchId=153) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainuser_3] (batchId=93) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3183/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3183/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3183/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 12 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12849372 - PreCommit-HIVE-Build > Add pre insert work to give storage handler the possibility to perform pre > insert checking > -- > > Key: HIVE-15727 > URL: https://issues.apache.org/jira/browse/HIVE-15727 > Project: Hive > Issue Type: Sub-task > Components: Druid integration >Reporter: slim bouguerra >Assignee: slim bouguerra > Fix For: 2.2.0 > > Attachments: HIVE-15727.patch > > > Add pre insert work stage to give storage handler the possibility to perform > pre insert checking. For instance for the druid storage handler this will > block the statement INSERT INTO statement. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-15727) Add pre insert work to give storage handler the possibility to perform pre insert checking
[ https://issues.apache.org/jira/browse/HIVE-15727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838388#comment-15838388 ] slim bouguerra commented on HIVE-15727: --- https://github.com/apache/hive/pull/139 > Add pre insert work to give storage handler the possibility to perform pre > insert checking > -- > > Key: HIVE-15727 > URL: https://issues.apache.org/jira/browse/HIVE-15727 > Project: Hive > Issue Type: Sub-task > Components: Druid integration >Reporter: slim bouguerra >Assignee: slim bouguerra > Fix For: 2.2.0 > > > Add pre insert work stage to give storage handler the possibility to perform > pre insert checking. For instance for the druid storage handler this will > block the statement INSERT INTO statement. -- This message was sent by Atlassian JIRA (v6.3.4#6332)