[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session in HTTP mode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865511#comment-15865511
 ] 

ASF GitHub Bot commented on HIVE-15858:
---

Github user sankarh closed the pull request at:

https://github.com/apache/hive/pull/144


> Beeline ^C doesn't close the session in HTTP mode
> -
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Fix For: 2.2.0
>
> Attachments: HIVE-15858.01.patch, HIVE-15858.02.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session in HTTP mode

[Sankar Hariappan (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865509#comment-15865509
 ] 

Sankar Hariappan commented on HIVE-15858:
-

Thanks [~thejas] for the commit!

> Beeline ^C doesn't close the session in HTTP mode
> -
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Fix For: 2.2.0
>
> Attachments: HIVE-15858.01.patch, HIVE-15858.02.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Thejas M Nair (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863258#comment-15863258
 ] 

Thejas M Nair commented on HIVE-15858:
--

+1
Thanks for also adding the test.


> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch, HIVE-15858.02.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862982#comment-15862982
 ] 

Hive QA commented on HIVE-15858:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12852264/HIVE-15858.02.patch

{color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10222 tests 
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) 
(batchId=235)
TestSparkCliDriver - did not produce a TEST-*.xml file (likely timed out) 
(batchId=131)

[union_remove_15.q,bucket_map_join_tez1.q,scriptfile1.q,groupby7_noskew.q,bucketmapjoin1.q,subquery_multiinsert.q,auto_join8.q,auto_join6.q,groupby2_map_skew.q,lateral_view_explode2.q,join28.q,load_dyn_part1.q,skewjoinopt17.q,union_remove_20.q,bucketmapjoin5.q]
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
 (batchId=159)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] 
(batchId=223)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] 
(batchId=223)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3509/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3509/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3509/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12852264 - PreCommit-HIVE-Build

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch, HIVE-15858.02.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Sankar Hariappan (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862940#comment-15862940
 ] 

Sankar Hariappan commented on HIVE-15858:
-

[~thejas]
Added a unit test case and the new patch is attached for your review.

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Thejas M Nair (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15862561#comment-15862561
 ] 

Thejas M Nair commented on HIVE-15858:
--

[~sankarh]
Added a comment in github pull request. 
Can you also add a unit test case for this ? Doing it for shutdown hook might 
not be feasible, so maybe create a separate runnable object in Beeline which 
shutdownhook would invoke, and also that can be accessed from test case. Add a 
mocked connetion object to Beeline.connections and verify that when this 
runnable is invoked there are no more connections ? (or something else you can 
think of)



> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Vihang Karajgaonkar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861651#comment-15861651
 ] 

Vihang Karajgaonkar commented on HIVE-15858:


bq. For the desired behavior described in HIVE-15626 for ^C, that would need to 
be dealt with in signalhandler. So I think it makes sense to handle this two 
different requirements in two different places.

Got it. In that case patch looks good to me too. Thanks [~thejas] and [~sankarh]

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Sankar Hariappan (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861073#comment-15861073
 ] 

Sankar Hariappan commented on HIVE-15858:
-

Thanks for the review [~xuefuz]! I shall see the test results right below your 
comment. Seems few failures not related to the patch. 

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Sankar Hariappan (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15861064#comment-15861064
 ] 

Sankar Hariappan commented on HIVE-15858:
-

Thanks [~vihangk1] for the comment! I do agree with [~thejas] point that these 
changes are meant for different reasons. 

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Thejas M Nair (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15860814#comment-15860814
 ] 

Thejas M Nair commented on HIVE-15858:
--

bq.  It looks like we have two places in Beeline code to handles signals like 
Ctrl^C. 1. SunSignalHandler and the code section which is modified by the 
patch. Do you think it would be a good idea modify the code so that they are 
all handled at the same place?

While the description talks about ^C, I think this closing of session is 
something we should be doing on any reason for exit. So the shutdownhook is the 
better place for that in my opinion.
For the desired behavior described in HIVE-15626  for ^C, that would need to be 
dealt with in signalhandler.
So I think it makes sense to handle this two different requirements in two 
different places.


> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Hive QA (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859873#comment-15859873
 ] 

Hive QA commented on HIVE-15858:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12851831/HIVE-15858.01.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10242 tests 
executed
*Failed tests:*
{noformat}
TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) 
(batchId=235)
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_join_with_different_encryption_keys]
 (batchId=159)
org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] 
(batchId=223)
org.apache.hive.hcatalog.pig.TestTextFileHCatStorer.testWriteDate3 (batchId=173)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3466/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3466/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3466/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 4 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12851831 - PreCommit-HIVE-Build

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Vihang Karajgaonkar (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859748#comment-15859748
 ] 

Vihang Karajgaonkar commented on HIVE-15858:


Thanks [~sankarh] for the patch. It looks like we have two places in Beeline 
code to handles signals like Ctrl^C. 1. SunSignalHandler and the code section 
which is modified by the patch. Do you think it would be a good idea modify the 
code so that they are all handled at the same place?

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Xuefu Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859412#comment-15859412
 ] 

Xuefu Zhang commented on HIVE-15858:


+1 for the change. However, I think a patch is expected here to trigger tests.

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859328#comment-15859328
 ] 

ASF GitHub Bot commented on HIVE-15858:
---

GitHub user sankarh opened a pull request:

https://github.com/apache/hive/pull/144

HIVE-15858: Beeline ^C doesn't close the session

HIVE-15858: Beeline ^C doesn't close the session
Fixed by closing the sessions through ShutdownHook.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sankarh/hive HIVE-15858

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/hive/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #144


commit 07624a9328f9f8256aeb2f10a22058f4cf1aa693
Author: Sankar Hariappan 
Date:   2017-02-09T10:29:23Z

HIVE-15858: Beeline ^C doesn't close the session




> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Sankar Hariappan (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859319#comment-15859319
 ] 

Sankar Hariappan commented on HIVE-15858:
-

[~xuefuz] Please review the patch where I closed all open sessions through 
ShutdownHook.

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
> Attachments: HIVE-15858.01.patch
>
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Sankar Hariappan (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859271#comment-15859271
 ] 

Sankar Hariappan commented on HIVE-15858:
-

Hi Xuefu Zhang, HIVE-15626 supports the smooth cancellation of running query 
when we hit Ctrl-C. But, this ticket talks about the case, where no queries are 
running currently and if we hit either !quit or Ctrl-C, then the beeline client 
closes but the sessions remain open in the server side. Also, I noticed this 
issue occurs only with HTTP mode of transport.

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> This behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (HIVE-15858) Beeline ^C doesn't close the session

[Xuefu Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/HIVE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15859225#comment-15859225
 ] 

Xuefu Zhang commented on HIVE-15858:


Does HIVE-15626 help?

> Beeline ^C doesn't close the session
> 
>
> Key: HIVE-15858
> URL: https://issues.apache.org/jira/browse/HIVE-15858
> Project: Hive
>  Issue Type: Bug
>  Components: Beeline
>Reporter: Sankar Hariappan
>Assignee: Sankar Hariappan
>
> When open multiple connections through Beeline to Hiveserver2 and if tries to 
> close the client using !quit or ^C command, it looks like all the 
> connections/sessions are not getting closed.
> !quit seems to close the current active connection but fails to close other 
> open sessions.
> ^C doesn't close any session.
> The above behaviour is noticed only with the HTTP mode of transport 
> (hive.server2.transport.mode=http). In case of BINARY mode, server triggers 
> the close session when a tcp connection is closed by peer.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)