[jira] [Commented] (HIVE-16028) Fail UPDATE/DELETE/MERGE queries when Ranger authorization manager is used
[ https://issues.apache.org/jira/browse/HIVE-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882218#comment-15882218 ] Hive QA commented on HIVE-16028: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12854300/HIVE-16028.2.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10242 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver (batchId=162) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3745/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3745/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3745/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12854300 - PreCommit-HIVE-Build > Fail UPDATE/DELETE/MERGE queries when Ranger authorization manager is used > -- > > Key: HIVE-16028 > URL: https://issues.apache.org/jira/browse/HIVE-16028 > Project: Hive > Issue Type: Bug > Components: Authorization, Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-16028.1.patch, HIVE-16028.2.patch > > > This is a followup of HIVE-15891. In that jira an error-out logic was added, > but the assumption that we need to do row filtering/column masking for > entries in a non-empty list of tables returned by > applyRowFilterAndColumnMasking is wrong, because on Ranger side, > RangerHiveAuthorizer#applyRowFilterAndColumnMasking will unconditionally > return a list of tables no matter whether row filtering/column masking is > applicable on the tables. > The fix for Hive for now will be to move the error-out logic after we figure > out there's no replacement text for the query. But ideally we should consider > modifying Ranger logic to only return tables that need to be masked. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16028) Fail UPDATE/DELETE/MERGE queries when Ranger authorization manager is used
[ https://issues.apache.org/jira/browse/HIVE-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881901#comment-15881901 ] Hive QA commented on HIVE-16028: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12854300/HIVE-16028.2.patch {color:green}SUCCESS:{color} +1 due to 2 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 10258 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=235) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=223) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3739/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3739/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3739/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12854300 - PreCommit-HIVE-Build > Fail UPDATE/DELETE/MERGE queries when Ranger authorization manager is used > -- > > Key: HIVE-16028 > URL: https://issues.apache.org/jira/browse/HIVE-16028 > Project: Hive > Issue Type: Bug > Components: Authorization, Transactions >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-16028.1.patch, HIVE-16028.2.patch > > > This is a followup of HIVE-15891. In that jira an error-out logic was added, > but the assumption that we need to do row filtering/column masking for > entries in a non-empty list of tables returned by > applyRowFilterAndColumnMasking is wrong, because on Ranger side, > RangerHiveAuthorizer#applyRowFilterAndColumnMasking will unconditionally > return a list of tables no matter whether row filtering/column masking is > applicable on the tables. > The fix for Hive for now will be to move the error-out logic after we figure > out there's no replacement text for the query. But ideally we should consider > modifying Ranger logic to only return tables that need to be masked. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (HIVE-16028) Fail UPDATE/DELETE/MERGE queries when Ranger authorization manager is used
[ https://issues.apache.org/jira/browse/HIVE-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881077#comment-15881077 ] Pengcheng Xiong commented on HIVE-16028: LGTM +1, please add a test. :) > Fail UPDATE/DELETE/MERGE queries when Ranger authorization manager is used > -- > > Key: HIVE-16028 > URL: https://issues.apache.org/jira/browse/HIVE-16028 > Project: Hive > Issue Type: Bug > Components: Authorization >Affects Versions: 2.2.0 >Reporter: Wei Zheng >Assignee: Wei Zheng > Attachments: HIVE-16028.1.patch > > > This is a followup of HIVE-15891. In that jira an error-out logic was added, > but the assumption that we need to do row filtering/column masking for > entries in a non-empty list of tables returned by > applyRowFilterAndColumnMasking is wrong, because on Ranger side, > RangerHiveAuthorizer#applyRowFilterAndColumnMasking will unconditionally > return a list of tables no matter whether row filtering/column masking is > applicable on the tables. > The fix for Hive for now will be to move the error-out logic after we figure > out there's no replacement text for the query. But ideally we should consider > modifying Ranger logic to only return tables that need to be masked. -- This message was sent by Atlassian JIRA (v6.3.15#6346)