[jira] [Commented] (HIVE-16494) udaf percentile_approx() may fail on CBO

2018-02-26 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377449#comment-16377449 ] Ashutosh Chauhan commented on HIVE-16494: - Patch looks good. Can you check TestNegativeCliDriver

[jira] [Commented] (HIVE-16494) udaf percentile_approx() may fail on CBO

2018-02-26 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377246#comment-16377246 ] Hive QA commented on HIVE-16494: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16494) udaf percentile_approx() may fail on CBO

2018-02-26 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16377150#comment-16377150 ] Hive QA commented on HIVE-16494: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-16494) udaf percentile_approx() may fail on CBO

2018-02-26 Thread Miklos Gergely (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16376991#comment-16376991 ] Miklos Gergely commented on HIVE-16494: --- covered map and struct too > udaf percentile_approx() may

[jira] [Commented] (HIVE-16494) udaf percentile_approx() may fail on CBO

2018-02-22 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373565#comment-16373565 ] Hive QA commented on HIVE-16494: Here are the results of testing the latest attachment:

[jira] [Commented] (HIVE-16494) udaf percentile_approx() may fail on CBO

2018-02-22 Thread Hive QA (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373466#comment-16373466 ] Hive QA commented on HIVE-16494: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HIVE-16494) udaf percentile_approx() may fail on CBO

2018-02-22 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373356#comment-16373356 ] Ashutosh Chauhan commented on HIVE-16494: - Other complex types are map and struct. Lets cover

[jira] [Commented] (HIVE-16494) udaf percentile_approx() may fail on CBO

2018-02-22 Thread Miklos Gergely (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372846#comment-16372846 ] Miklos Gergely commented on HIVE-16494: --- The issue was that TypeCheckProcFactory did not handle

[jira] [Commented] (HIVE-16494) udaf percentile_approx() may fail on CBO

2017-04-20 Thread Ashutosh Chauhan (JIRA)
[ https://issues.apache.org/jira/browse/HIVE-16494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978014#comment-15978014 ] Ashutosh Chauhan commented on HIVE-16494: - unit test in: udaf_percentile_approx_23.q > udaf